All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	UNGLinuxDriver@microchip.com, davem@davemloft.net,
	kuba@kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next] net: lan966x: Fix when CONFIG_IPV6 is not set
Date: Wed, 9 Feb 2022 14:54:23 +0100	[thread overview]
Message-ID: <YgPHjxpo0N4ND1ch@lunn.ch> (raw)
In-Reply-To: <20220209101823.1270489-1-horatiu.vultur@microchip.com>

On Wed, Feb 09, 2022 at 11:18:23AM +0100, Horatiu Vultur wrote:
> When CONFIG_IPV6 is not set, then the compilation of the lan966x driver
> fails with the following error:
> 
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:444: undefined
> reference to `ipv6_mc_check_mld'
> 
> The fix consists in adding #ifdef around this code.

It might be better to add a stub function for when IPv6 is
disabled. We try to avoid #if in C code.

	  Andrew

  reply	other threads:[~2022-02-09 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 10:18 [PATCH net-next] net: lan966x: Fix when CONFIG_IPV6 is not set Horatiu Vultur
2022-02-09 13:54 ` Andrew Lunn [this message]
2022-02-10  2:06   ` Jakub Kicinski
2022-02-10  8:36     ` Horatiu Vultur
2022-02-10 13:14       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgPHjxpo0N4ND1ch@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.