From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6C6C433FE for ; Wed, 9 Feb 2022 18:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238665AbiBISLI (ORCPT ); Wed, 9 Feb 2022 13:11:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238684AbiBISK4 (ORCPT ); Wed, 9 Feb 2022 13:10:56 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD5CEC0613C9 for ; Wed, 9 Feb 2022 10:10:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A44261990 for ; Wed, 9 Feb 2022 18:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92932C340E7; Wed, 9 Feb 2022 18:10:55 +0000 (UTC) Date: Wed, 9 Feb 2022 18:10:52 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, frederic@kernel.org, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 6/7] arm64: entry: centralize premeption decision Message-ID: References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209153535.818830-7-mark.rutland@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 03:35:34PM +0000, Mark Rutland wrote: > For historical reasons, the decision of whether or not to preempt is > spread across arm64_preempt_schedule_irq() and __el1_irq(), and it would > be clearer if this were all in one place. > > Also, arm64_preempt_schedule_irq() calls lockdep_assert_irqs_disabled(), > but this is redundant, as we have a subsequent identical assertion in > __exit_to_kernel_mode(), and preempt_schedule_irq() will > BUG_ON(!irqs_disabled()) anyway. > > This patch removes the redundant assertion and centralizes the > preemption decision making within arm64_preempt_schedule_irq(). > > Other than the slight change to assertion behaviour, there should be no > functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: James Morse > Cc: Joey Gouly > Cc: Valentin Schneider > Cc: Will Deacon I acked this patch in v2, has anything changed? Well, here it is again: Acked-by: Catalin Marinas BTW, you have a typo in the subject. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD7B5C433FE for ; Wed, 9 Feb 2022 18:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y/6qPkjL4w/orhfBn97KrcjbO/7REiAagjphRT8OWsU=; b=CUqM7SpNrucl7z uT8Hf03gSWt3prHkIqnDDjkZfAaSIM8YN9iXXhAvkeT4+qV2JM6pslIPqH30OVg3b2sUl7c4IEuwR vXWMthJLxgDOtZfBiOcRCKj/+53bEzJnCdCjmUBsjXCmsn2AcGHIOWtXw6ZCbIsnjWK/HSflfz6tW EcoGgSXekGdjCt7OiG3WAjJrwRybkpv7MpUVLKuBdGYjObz9POHj1EgYoIKI80blSibHHR0x9TAXP 5SIloPw0q6c7Y9EsPV6IOq93l6nfUFbb7tJibeDGyvWhk0HLmBW0GjtdvTlUnAaGjDTVX2crSruhI tZMFPFURh405UgKhLfFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHrQn-001489-Cj; Wed, 09 Feb 2022 18:11:05 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHrQj-00147R-Sz for linux-arm-kernel@lists.infradead.org; Wed, 09 Feb 2022 18:11:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DCC6AB82377; Wed, 9 Feb 2022 18:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92932C340E7; Wed, 9 Feb 2022 18:10:55 +0000 (UTC) Date: Wed, 9 Feb 2022 18:10:52 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, frederic@kernel.org, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 6/7] arm64: entry: centralize premeption decision Message-ID: References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220209153535.818830-7-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_101102_123278_C5565C61 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 03:35:34PM +0000, Mark Rutland wrote: > For historical reasons, the decision of whether or not to preempt is > spread across arm64_preempt_schedule_irq() and __el1_irq(), and it would > be clearer if this were all in one place. > > Also, arm64_preempt_schedule_irq() calls lockdep_assert_irqs_disabled(), > but this is redundant, as we have a subsequent identical assertion in > __exit_to_kernel_mode(), and preempt_schedule_irq() will > BUG_ON(!irqs_disabled()) anyway. > > This patch removes the redundant assertion and centralizes the > preemption decision making within arm64_preempt_schedule_irq(). > > Other than the slight change to assertion behaviour, there should be no > functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: James Morse > Cc: Joey Gouly > Cc: Valentin Schneider > Cc: Will Deacon I acked this patch in v2, has anything changed? Well, here it is again: Acked-by: Catalin Marinas BTW, you have a typo in the subject. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel