From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB77C4332F for ; Wed, 9 Feb 2022 20:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbiBIUTl (ORCPT ); Wed, 9 Feb 2022 15:19:41 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:40434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiBIUTh (ORCPT ); Wed, 9 Feb 2022 15:19:37 -0500 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14914E010DBE; Wed, 9 Feb 2022 12:19:40 -0800 (PST) Received: by mail-oo1-f43.google.com with SMTP id u47-20020a4a9732000000b00316d0257de0so3809929ooi.7; Wed, 09 Feb 2022 12:19:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wq4vdKGMeXoIRNXOtMWhnncER4U349yKDpCvUwhL4uI=; b=KGt3Uyvqq9FK1vwl86Rn8TtyKKo9PoYRqeB5kRyYYukVKJRXQ1DJO12h79UKF0rRv4 6DzAtLN5WtOpdHO4XeqgDV6h/bBAcskHLeoDGh1XGapVkFEnoHWmiDosi2L3QwnEHZaJ 6Czp7gqAL5sEHkiUr6bWfzk7gC3mVpDzm0vUnwkChrCUjxdy1FJiDMRBpJgWRdme5b+j ayvInv08P6QeVVz8hq5A+TWru1eLAY/wiqgjFhlX+FT0eohxDUfj28is60CnlI9zPh0p 6IYlceS6bCOJQTinGAPP/CaawOJMcTKemZCf2D4Ck/68EbB7hh3MvC87+okT2x8hT6Z9 xEDQ== X-Gm-Message-State: AOAM533v1P/CJMjtdtCSkzMM3ktQ/1jMhIONcQMBiL5nACEqLKpKwA9P SChhWj2jejrsnV4T/DNev0DsqC19Xw== X-Google-Smtp-Source: ABdhPJwkGIFmvi/YRXr/h/wnQirAhEqYAsd5AzUXVjmhqfax7kfjOA+NyA0T6LZenez6U6kRp4zfUg== X-Received: by 2002:a05:6870:a583:: with SMTP id c3mr1452455oam.197.1644437979384; Wed, 09 Feb 2022 12:19:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id d21sm6939901otq.68.2022.02.09.12.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 12:19:38 -0800 (PST) Received: (nullmailer pid 828716 invoked by uid 1000); Wed, 09 Feb 2022 20:19:36 -0000 Date: Wed, 9 Feb 2022 14:19:36 -0600 From: Rob Herring To: Brian Norris Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, Derek Basehore , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner Subject: Re: [PATCH v2 03/15] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 03:07:14PM -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > (no changes since v1) > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74A85C433F5 for ; Wed, 9 Feb 2022 20:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=krKJ2E5ALxJ1iYF5gCqtU+o+2CjLYMGwojMcN/5UiB4=; b=Z1OhVCuExFk6EZ AmktzUazOIYtefC89Q7fZOU7KT3withX8Jhh+w3p1oGPdZfhefmOhT16y/bSqSFFR3BBjIm/37FKA 1oLCZ88Rh5/GF53y3hGTUhAkly0r0OuXj7tpVr7zyok/4sDuh6R88KMHwP3CzHNjhGH7L/gYU2Gy2 xURH/YND2goDRJVlZyLT/55ap1obxIQ/SCe28aN29LZtxUmAvg6DzDy4OP+r3odMi6fqKq2HxcLur petnVlDS43LYHPIBdRUhqWwu/179q9b8JAvVF4aLNDmuEO/nYAQyNuz1kotNmVSr/n8XXonaKtk2A ROBM0kgEeUforkjPg9Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHtRJ-001X5Z-Ar; Wed, 09 Feb 2022 20:19:45 +0000 Received: from mail-oo1-f44.google.com ([209.85.161.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHtRE-001X4G-QN; Wed, 09 Feb 2022 20:19:43 +0000 Received: by mail-oo1-f44.google.com with SMTP id v17-20020a4ac911000000b002eac41bb3f4so3773370ooq.10; Wed, 09 Feb 2022 12:19:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wq4vdKGMeXoIRNXOtMWhnncER4U349yKDpCvUwhL4uI=; b=6iWjuiPB3r/IE9ndpOBWzRxhbeUl89NH8rzBzufQGsmy709Idmh5lht6SAu3ZYarfw ZmEIcBA2WCBNGkPhmWjGggVii3Nqf8RWn1p46AwNwEHbM5HHrOB42LpL4yS2RyYLd4uK y2IZJJyVShe7CDKiZ72eg9gr/jIEEOhdGdglLbb9kQLUo1LpzJv4dViUPjNAepIOer4V HxkRxaBwViiCMeqPPdO4NW1eYDJRlcjos0MPdMQm0NtX56GH+Tsnp8ZOvHPyNChVnMyX VwFSirIaMSVyWeUr76w5EgnVXZ70IqBAlhQxZCgP8LwXi13eVMKwUKDroJ6LoC0aV/tY sLXA== X-Gm-Message-State: AOAM531HbbPGJNWuoWnVzOSqZndBdIBZ9UOyDnwLe7JlZr/eUvnTQTQ5 BxYAxakrksL4yuuH/7oXkQ== X-Google-Smtp-Source: ABdhPJwkGIFmvi/YRXr/h/wnQirAhEqYAsd5AzUXVjmhqfax7kfjOA+NyA0T6LZenez6U6kRp4zfUg== X-Received: by 2002:a05:6870:a583:: with SMTP id c3mr1452455oam.197.1644437979384; Wed, 09 Feb 2022 12:19:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id d21sm6939901otq.68.2022.02.09.12.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 12:19:38 -0800 (PST) Received: (nullmailer pid 828716 invoked by uid 1000); Wed, 09 Feb 2022 20:19:36 -0000 Date: Wed, 9 Feb 2022 14:19:36 -0600 From: Rob Herring To: Brian Norris Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, Derek Basehore , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner Subject: Re: [PATCH v2 03/15] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_121940_899259_36B2A173 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Jan 27, 2022 at 03:07:14PM -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > (no changes since v1) > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Rob Herring _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EF39C433F5 for ; Wed, 9 Feb 2022 20:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+EgH7DgwzcBXjyzg2WRIM2QH4Y8uuD5TQ3+9WxLQy1Y=; b=2FTfdROw0ngBVD vbp8LJTG0B5Bk0W6hbHg+XdMPmVQhKMNKJxbZAiqXRE402zUyEoqmxjzYH34Gil6f7bNNisuxjRG7 SF38HDLUlo8QmZ2ZjcFW/TJvtjrvVhoX+eeTcODyXdtTeAs2I58MF8nGCUEvyn2TEZmfexS8wkMVd NAUr59eRUAzFe11j+xHSM9UOu50vgHVxmj1OHzkHq1mUfqzjSWSHQ3RAx3EDhwSzh8IqbLMt5C1ei ji3OxEXSCOnuBvtV1ljNCQjCME5zgSnPqkfcWap3dXPyLs0o5wqIVz/bXFOG+r+jzLUGzc2jvXQGq N1KW+bp9VVbDP1R7wjhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHtRL-001X5y-04; Wed, 09 Feb 2022 20:19:47 +0000 Received: from mail-oo1-f44.google.com ([209.85.161.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHtRE-001X4G-QN; Wed, 09 Feb 2022 20:19:43 +0000 Received: by mail-oo1-f44.google.com with SMTP id v17-20020a4ac911000000b002eac41bb3f4so3773370ooq.10; Wed, 09 Feb 2022 12:19:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wq4vdKGMeXoIRNXOtMWhnncER4U349yKDpCvUwhL4uI=; b=6iWjuiPB3r/IE9ndpOBWzRxhbeUl89NH8rzBzufQGsmy709Idmh5lht6SAu3ZYarfw ZmEIcBA2WCBNGkPhmWjGggVii3Nqf8RWn1p46AwNwEHbM5HHrOB42LpL4yS2RyYLd4uK y2IZJJyVShe7CDKiZ72eg9gr/jIEEOhdGdglLbb9kQLUo1LpzJv4dViUPjNAepIOer4V HxkRxaBwViiCMeqPPdO4NW1eYDJRlcjos0MPdMQm0NtX56GH+Tsnp8ZOvHPyNChVnMyX VwFSirIaMSVyWeUr76w5EgnVXZ70IqBAlhQxZCgP8LwXi13eVMKwUKDroJ6LoC0aV/tY sLXA== X-Gm-Message-State: AOAM531HbbPGJNWuoWnVzOSqZndBdIBZ9UOyDnwLe7JlZr/eUvnTQTQ5 BxYAxakrksL4yuuH/7oXkQ== X-Google-Smtp-Source: ABdhPJwkGIFmvi/YRXr/h/wnQirAhEqYAsd5AzUXVjmhqfax7kfjOA+NyA0T6LZenez6U6kRp4zfUg== X-Received: by 2002:a05:6870:a583:: with SMTP id c3mr1452455oam.197.1644437979384; Wed, 09 Feb 2022 12:19:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id d21sm6939901otq.68.2022.02.09.12.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 12:19:38 -0800 (PST) Received: (nullmailer pid 828716 invoked by uid 1000); Wed, 09 Feb 2022 20:19:36 -0000 Date: Wed, 9 Feb 2022 14:19:36 -0600 From: Rob Herring To: Brian Norris Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, Derek Basehore , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner Subject: Re: [PATCH v2 03/15] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220127230727.3369358-1-briannorris@chromium.org> <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220127150615.v2.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_121940_899259_36B2A173 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 27, 2022 at 03:07:14PM -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > (no changes since v1) > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel