From: Mark Brown <broonie@kernel.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
ying.xue@windriver.com
Subject: Re: [PATCH] spi: disable chipselect after complete transfer
Date: Thu, 10 Feb 2022 11:18:57 +0000 [thread overview]
Message-ID: <YgT0oU/5SMViNRu7@sirena.org.uk> (raw)
In-Reply-To: <07aca74d-c74e-c2a3-b8eb-bdcf9ed21a55@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Thu, Feb 10, 2022 at 10:03:16AM +0800, Yun Zhou wrote:
> if the last xfer->cs_change is true, keep_cs will be true, and it will not
> call spi_set_cs() to set CS to false. Do you mean to keep CS enabled in this
> case?
Yes, that's exactly what is supposed to happen in that case.
> I do not think it will break cs_change support. In my understanding,
> cs_change indicates whether or not change CS after an xfer completed. But at
> present if the last xfer->cs_change is true, we will not change CS to
> disabled state. Is this the result we want? I'm confused.
Yes, it behaves differently on the last transfer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-02-10 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 10:00 [PATCH] spi: disable chipselect after complete transfer Yun Zhou
2022-02-09 13:40 ` Mark Brown
2022-02-10 2:03 ` Yun Zhou
2022-02-10 11:18 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgT0oU/5SMViNRu7@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ying.xue@windriver.com \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.