From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4ECC433F5 for ; Thu, 10 Feb 2022 11:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240860AbiBJL0f (ORCPT ); Thu, 10 Feb 2022 06:26:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237809AbiBJL0b (ORCPT ); Thu, 10 Feb 2022 06:26:31 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF25C15; Thu, 10 Feb 2022 03:26:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8F1A4CE243B; Thu, 10 Feb 2022 11:26:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5FBCC004E1; Thu, 10 Feb 2022 11:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644492387; bh=uGn5sWCwfvSpb9avSSWCJHzaK458xm1a3dY7suR6Wq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bmP8EM8H7RyB9Ym3qK7Ab0iB7yxWmeZuQHOTX1sfiP/hya1Anr35ncQb2AAxMyiCR AwxffvC9428xp4W3x1H65MJVHavyI2k+lZGZkdiW//uY+5lBWEVlbTKXHjVBGtld66 BGjb1rR3IP5tpyINKARQjp9TSExlzCX7Ne2si5nMpt1UkacdN4O4e+ChsOKxMCUaca mPbSXUTWrGUxqNLwo/kMVaWEUn4A/hdvDBHuWmq3DSW/1hlIybZjJliSnWaG6qacxV WtAIy2jd3v0CZJF8Pjg+h3cWTXmRe0fYVl1KhtP4Pq61JIoV6AGYdTdGkD/QXcREG8 8nF94wXPl+K5w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nI7aR-0005EK-SH; Thu, 10 Feb 2022 12:26:08 +0100 Date: Thu, 10 Feb 2022 12:26:07 +0100 From: Johan Hovold To: Andy Shevchenko Cc: davidcomponentone@gmail.com, Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Yang Guang , "open list:SERIAL DRIVERS" , linux-arm Mailing List , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Linux Kernel Mailing List , Zeal Robot Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote: > On Thu, Feb 10, 2022 at 12:54 PM wrote: > > > > From: Yang Guang > > > > coccinelle report: > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: > > WARNING: use scnprintf or sprintf > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: > > WARNING: use scnprintf or sprintf > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: > > WARNING: use scnprintf or sprintf > > > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > sysfs_emit() > scnprintf() > sprintf() > > ... > > > CC: David Yang > > > - Use the CC for patch sender > > This is incorrect. The submitter must have (the last) SoB tag. > Question was about authorship just to be clear. Please fix up the subject prefix too ("8059"). Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51A5AC433EF for ; Thu, 10 Feb 2022 11:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3oYVyL6kNg8EvTjGPNsyYdsFQPUcg1SS8iMn4rbm/tY=; b=nx0m9wVBOW9Z7S /OaeHG1aeVLmXwCHAW95+5hu2dPZ3ei08zMTiLE7ohvA6tmfnEH/B8+Hil4Cz/UkjifMHivUStQw7 fPekdZRHAmm0ER3avY45wpWb0iGkmBxF2ClMyDoD6OX4bZqvf7930HnPoRaH9xW/HeKWvrgb6Udly 0fWtlRvzxILBjJwTbTfayAmZ1XkSdw5KnHoCRZHeTCgjy74h/JtF7/ezgd5CSqkfjFyY8zTK6o6um 3tsgGBe+pfekZ8B4zyhClQbIhF2O9WQEcawA2AmUObMDrfsSEzFMCDsDdo/4X0Fh14qCeTKBVwDsY Fci9DTZdf5fkvWbucHrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI7av-003Zml-KB; Thu, 10 Feb 2022 11:26:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI7ar-003Zm3-9n for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 11:26:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6BE3FCE239F; Thu, 10 Feb 2022 11:26:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5FBCC004E1; Thu, 10 Feb 2022 11:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644492387; bh=uGn5sWCwfvSpb9avSSWCJHzaK458xm1a3dY7suR6Wq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bmP8EM8H7RyB9Ym3qK7Ab0iB7yxWmeZuQHOTX1sfiP/hya1Anr35ncQb2AAxMyiCR AwxffvC9428xp4W3x1H65MJVHavyI2k+lZGZkdiW//uY+5lBWEVlbTKXHjVBGtld66 BGjb1rR3IP5tpyINKARQjp9TSExlzCX7Ne2si5nMpt1UkacdN4O4e+ChsOKxMCUaca mPbSXUTWrGUxqNLwo/kMVaWEUn4A/hdvDBHuWmq3DSW/1hlIybZjJliSnWaG6qacxV WtAIy2jd3v0CZJF8Pjg+h3cWTXmRe0fYVl1KhtP4Pq61JIoV6AGYdTdGkD/QXcREG8 8nF94wXPl+K5w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nI7aR-0005EK-SH; Thu, 10 Feb 2022 12:26:08 +0100 Date: Thu, 10 Feb 2022 12:26:07 +0100 From: Johan Hovold To: Andy Shevchenko Cc: davidcomponentone@gmail.com, Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Yang Guang , "open list:SERIAL DRIVERS" , linux-arm Mailing List , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Linux Kernel Mailing List , Zeal Robot Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_032633_897132_5FBD5A7C X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote: > On Thu, Feb 10, 2022 at 12:54 PM wrote: > > > > From: Yang Guang > > > > coccinelle report: > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: > > WARNING: use scnprintf or sprintf > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: > > WARNING: use scnprintf or sprintf > > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: > > WARNING: use scnprintf or sprintf > > > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > sysfs_emit() > scnprintf() > sprintf() > > ... > > > CC: David Yang > > > - Use the CC for patch sender > > This is incorrect. The submitter must have (the last) SoB tag. > Question was about authorship just to be clear. Please fix up the subject prefix too ("8059"). Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel