From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB2EC433EF for ; Thu, 10 Feb 2022 09:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238390AbiBJJTd (ORCPT ); Thu, 10 Feb 2022 04:19:33 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235240AbiBJJTb (ORCPT ); Thu, 10 Feb 2022 04:19:31 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D2C4F5 for ; Thu, 10 Feb 2022 01:19:33 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B02B3113E; Thu, 10 Feb 2022 01:19:32 -0800 (PST) Received: from FVFF77S0Q05N (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1E173F718; Thu, 10 Feb 2022 01:19:28 -0800 (PST) Date: Thu, 10 Feb 2022 09:19:10 +0000 From: Mark Rutland To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, frederic@kernel.org, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 6/7] arm64: entry: centralize premeption decision Message-ID: References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 06:10:52PM +0000, Catalin Marinas wrote: > On Wed, Feb 09, 2022 at 03:35:34PM +0000, Mark Rutland wrote: > > For historical reasons, the decision of whether or not to preempt is > > spread across arm64_preempt_schedule_irq() and __el1_irq(), and it would > > be clearer if this were all in one place. > > > > Also, arm64_preempt_schedule_irq() calls lockdep_assert_irqs_disabled(), > > but this is redundant, as we have a subsequent identical assertion in > > __exit_to_kernel_mode(), and preempt_schedule_irq() will > > BUG_ON(!irqs_disabled()) anyway. > > > > This patch removes the redundant assertion and centralizes the > > preemption decision making within arm64_preempt_schedule_irq(). > > > > Other than the slight change to assertion behaviour, there should be no > > functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland > > Cc: Catalin Marinas > > Cc: James Morse > > Cc: Joey Gouly > > Cc: Valentin Schneider > > Cc: Will Deacon > > I acked this patch in v2, has anything changed? Well, here it is again: Sorry; I had meant to add your acks. This patch is the same as in v2; the other patch has some minor changes as in the cover letter (adding includes and always exposing a couple of function prototypes). > Acked-by: Catalin Marinas Thanks! > BTW, you have a typo in the subject. I'll go fix that now. Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 722F3C433F5 for ; Thu, 10 Feb 2022 09:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=16gXRaOe+DPrq+SuvzKSnzZx+PYYMBEUr1JIO5OQSWk=; b=X1ZTT1UM3FLSH2 2Gn61DrAMAk8ltlh8kJJ+r0aThvhhl0VoWlsNJrKl7eRbpfMi36xD2zvxdknScbydFGUkyTlA51ik wBu4WWjgT38DyWjlqJ1l+Zttn9D7mdTeUtXnr78Cj1LSplfMxJqNvfDkehVP23nuB60xhgTUVEcSy VHc4FIDQuaFY6ZlYd5ugg/MiT9MHURcFkjWvE6KR+Bwp231keNNmO4ksURJWvKvjY2Bgu8YZsFgsp e3XiGkB4grKS2jmxdN7vRQ9t6dxAY3GwN2oCbyFxh2Eh7ysJWxi49dDO5reJIvRRkK0ViWMn32hzD uKc2i7dRyjbVqObE5zDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI5c3-003FnJ-5Z; Thu, 10 Feb 2022 09:19:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI5by-003Fm4-MV for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 09:19:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B02B3113E; Thu, 10 Feb 2022 01:19:32 -0800 (PST) Received: from FVFF77S0Q05N (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1E173F718; Thu, 10 Feb 2022 01:19:28 -0800 (PST) Date: Thu, 10 Feb 2022 09:19:10 +0000 From: Mark Rutland To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, frederic@kernel.org, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 6/7] arm64: entry: centralize premeption decision Message-ID: References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_011934_803646_444A0E40 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 06:10:52PM +0000, Catalin Marinas wrote: > On Wed, Feb 09, 2022 at 03:35:34PM +0000, Mark Rutland wrote: > > For historical reasons, the decision of whether or not to preempt is > > spread across arm64_preempt_schedule_irq() and __el1_irq(), and it would > > be clearer if this were all in one place. > > > > Also, arm64_preempt_schedule_irq() calls lockdep_assert_irqs_disabled(), > > but this is redundant, as we have a subsequent identical assertion in > > __exit_to_kernel_mode(), and preempt_schedule_irq() will > > BUG_ON(!irqs_disabled()) anyway. > > > > This patch removes the redundant assertion and centralizes the > > preemption decision making within arm64_preempt_schedule_irq(). > > > > Other than the slight change to assertion behaviour, there should be no > > functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland > > Cc: Catalin Marinas > > Cc: James Morse > > Cc: Joey Gouly > > Cc: Valentin Schneider > > Cc: Will Deacon > > I acked this patch in v2, has anything changed? Well, here it is again: Sorry; I had meant to add your acks. This patch is the same as in v2; the other patch has some minor changes as in the cover letter (adding includes and always exposing a couple of function prototypes). > Acked-by: Catalin Marinas Thanks! > BTW, you have a typo in the subject. I'll go fix that now. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel