From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33CCC4332F for ; Thu, 10 Feb 2022 13:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242185AbiBJN12 (ORCPT ); Thu, 10 Feb 2022 08:27:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242168AbiBJN1T (ORCPT ); Thu, 10 Feb 2022 08:27:19 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D891B5 for ; Thu, 10 Feb 2022 05:27:20 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id k1so9562559wrd.8 for ; Thu, 10 Feb 2022 05:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=ppLX4h1TEy8PBW7a4orzxmSRVpkxMMzDVgFrPPO+f6wmqSNbpVbyd980agqXUsmsK4 1t3S3V3yoGn5PBZR2wXsNiBwTiBg+7IWH1M5aJJPZiGs155neECX0Xdc2i3WXR7UwbMM aT3Xtfs00uZGf1TbnMYWNrEUtQHMZ5qRjlmiRc0/xqYQhMq8duwRHg0U0Z9pXtKzJ45Q hYfhYVE/1cZLNyTrYw1GNDxUZjkYoAd3FPrsD2ljbrv3HGwfrkyETIATbgIB71TaTNDV dnfvww2HWwcMyGbOkxaLGF8pIQWjKAPbfSCnWB56bK0zNRSMtsjTh7NuJVkUEYKppMbv lTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=0z31NOR+o7yyOcc4H62t47McRGKvq2tBTqS/36GDSQvRT1+RkbdtsRWPw+FAFXgfxJ 75ji0xP5SRFCe5u3AW4F48nJ+DtVrwgStiWf2RtN7YxdgEzWKV8f0b5bAML1FqZHf9uY 2CLLZWnqrGztmq9n+dey8AwpbzrkOCu5zRN+beNYxU822av0IqwSd680yPEdJlHeXr8I 2FxiFDDGQZgLmHvqwB8+T/zkGCXKHAZnQZPU0HOCHruR4U7xekC32hbQlpSQ0HFABq3y imCfPE6OtLmLeDK/H2jqYgZoSl88HBaejb1aNvHY6I5IXVd/w3Ag//0ovQ41amB3uII2 kefg== X-Gm-Message-State: AOAM533om7OZVTE8gLJ7TZ9cYe0TcQxMl0XZKSAdelTOc4H+ug5315ft 8NcBM244tphN+8BYm+DzXL3Tdw== X-Google-Smtp-Source: ABdhPJzKId3yDGkhp6bPVmSqb71G1h0/VzUuaq+GY1xoayMe32i7GhkM4V+qZRiTEWVDWxES+I9IMA== X-Received: by 2002:a5d:4745:: with SMTP id o5mr485824wrs.275.1644499638587; Thu, 10 Feb 2022 05:27:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id h6sm1559790wmq.26.2022.02.10.05.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 05:27:18 -0800 (PST) Date: Thu, 10 Feb 2022 14:27:15 +0100 From: LABBE Corentin To: Rob Herring Cc: linus.walleij@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2] dt-bindings: mtd: drop mtd/cortina,gemini-flash.txt Message-ID: References: <20220131080858.1777518-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, Feb 09, 2022 at 03:18:41PM -0600, Rob Herring a écrit : > On Mon, Jan 31, 2022 at 08:08:58AM +0000, Corentin Labbe wrote: > > Drop mtd/cortina,gemini-flash.txt since it is nearly already handled by > > Documentation/devicetree/bindings/mtd/mtd-physmap.yaml. > > > > Reviewed-by: Linus Walleij > > Signed-off-by: Corentin Labbe > > --- > > Change since v1: > > - fixed typo on syscon > > > > .../bindings/mtd/cortina,gemini-flash.txt | 24 ------------------- > > .../devicetree/bindings/mtd/mtd-physmap.yaml | 18 +++++++++++++- > > 2 files changed, 17 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt b/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > deleted file mode 100644 > > index efa5b2aba829..000000000000 > > --- a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Flash device on Cortina Systems Gemini SoC > > - > > -This flash is regular CFI compatible (Intel or AMD extended) flash chips with > > -some special bits that can be controlled by the machine's system controller. > > - > > -Required properties: > > -- compatible : must be "cortina,gemini-flash", "cfi-flash"; > > -- reg : memory address for the flash chip > > -- syscon : must be a phandle to the system controller > > -- bank-width : width in bytes of flash interface, should be <2> > > - > > -For the rest of the properties, see mtd-physmap.yaml. > > - > > -The device tree may optionally contain sub-nodes describing partitions of the > > -address space. See partition.txt for more detail. > > - > > -Example: > > - > > -flash@30000000 { > > - compatible = "cortina,gemini-flash", "cfi-flash"; > > - reg = <0x30000000 0x01000000>; > > - syscon = <&syscon>; > > - bank-width = <2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > index f827984936f6..82eb4e0f453b 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > @@ -44,7 +44,9 @@ properties: > > - numonyx,js28f128 > > - sst,sst39vf320 > > - xlnx,xps-mch-emc-2.00.a > > - - const: cfi-flash > > + - enum: > > + - cfi-flash > > + - jedec-flash > > Why is jedec-flash being added? The old doc made no mention of it. > Because one board (gemini-dlink-dns-313.dts) use it. See commit a10d862e585e06aacc3a03e230fdf8faf6b1caf0 """ The flash on the DNS-313 needs to be probed as JEDEC, it does not conform to the common CFI standard. """ I will add this (the addition of jedec-flash) in commmit log. Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82D9DC433EF for ; Thu, 10 Feb 2022 13:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JZmPrwGXw6eVvelzEOB1xDMfIFHfxDlouYjgzOk9zuk=; b=pPs4b9JkZ3/iqt lxF5omqs1lI1d7uQvbLcsYSa01m1DqO/A7yRJ9Faqgd3fylalZxgIPVod3QGewKCy66iaxyEi1cQs ZrWBXq3HH4yrkGAs4EEuMLpJWo7wi/+eb932vfjmn4AkyVD19W+cpaTVU0+4LMxo8KJllFCwilzgO lPSPo4cP8WS93GLK6wGUx35WxwOwxWmOy/xOeLRHG3zh2XGmHfSUaNCnyvOGacMj2NptAPxjFG2Or aHXi2lIKqPQZTRH0cgZvuhzTBJxz8d7tuktGC38o+PxOnh1NbNrhGHmW78ZfkTq3hcnckX2pVyiEr Rc4ZlZW9LXLXLzGB2SsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9Tx-003sha-BC; Thu, 10 Feb 2022 13:27:33 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9Tl-003seU-5q for linux-mtd@lists.infradead.org; Thu, 10 Feb 2022 13:27:25 +0000 Received: by mail-wr1-x42d.google.com with SMTP id q7so9487594wrc.13 for ; Thu, 10 Feb 2022 05:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=ppLX4h1TEy8PBW7a4orzxmSRVpkxMMzDVgFrPPO+f6wmqSNbpVbyd980agqXUsmsK4 1t3S3V3yoGn5PBZR2wXsNiBwTiBg+7IWH1M5aJJPZiGs155neECX0Xdc2i3WXR7UwbMM aT3Xtfs00uZGf1TbnMYWNrEUtQHMZ5qRjlmiRc0/xqYQhMq8duwRHg0U0Z9pXtKzJ45Q hYfhYVE/1cZLNyTrYw1GNDxUZjkYoAd3FPrsD2ljbrv3HGwfrkyETIATbgIB71TaTNDV dnfvww2HWwcMyGbOkxaLGF8pIQWjKAPbfSCnWB56bK0zNRSMtsjTh7NuJVkUEYKppMbv lTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=hsv51y5YuwjO1Gk4WF5AWDDScbN+R6bsbAZGIgMQT02YWhWIHVINmSaINq5o32GsL/ 5n1vldnuLcpxAaRb+5dB745ALAJnNyn82conbgPirFU9LiSsX+jox5ecT7R8Y4sMlsRl OtLSa7srGo91n9SOSlOXI7+kcG1XBcEE5HoIxy4HG9jYhO8IYVJ+lBhGHaFtPRFsGgfw LG53ARwEoIWDOTrredwHSecg5d0VSIbGP6bmC36bcFhNamLCPhpdcKtZs2Q4tpbvXbZO l8jyWblqvNS8zry1GCwKqiRUZn+mBImp+el9n1OCqCiIDK+O6T+ReFtndaBrMrMB7+Uk TJsQ== X-Gm-Message-State: AOAM533ifXtLrk2m+0EYvWn6XwCbnQqwNuiBaXotNQgVhyq7ep8Htt2e DqOE8dZA7ejRFfNwQPt3zkf4yg== X-Google-Smtp-Source: ABdhPJzKId3yDGkhp6bPVmSqb71G1h0/VzUuaq+GY1xoayMe32i7GhkM4V+qZRiTEWVDWxES+I9IMA== X-Received: by 2002:a5d:4745:: with SMTP id o5mr485824wrs.275.1644499638587; Thu, 10 Feb 2022 05:27:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id h6sm1559790wmq.26.2022.02.10.05.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 05:27:18 -0800 (PST) Date: Thu, 10 Feb 2022 14:27:15 +0100 From: LABBE Corentin To: Rob Herring Cc: linus.walleij@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2] dt-bindings: mtd: drop mtd/cortina,gemini-flash.txt Message-ID: References: <20220131080858.1777518-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_052721_247386_ED279245 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Le Wed, Feb 09, 2022 at 03:18:41PM -0600, Rob Herring a =E9crit : > On Mon, Jan 31, 2022 at 08:08:58AM +0000, Corentin Labbe wrote: > > Drop mtd/cortina,gemini-flash.txt since it is nearly already handled by > > Documentation/devicetree/bindings/mtd/mtd-physmap.yaml. > > = > > Reviewed-by: Linus Walleij > > Signed-off-by: Corentin Labbe > > --- > > Change since v1: > > - fixed typo on syscon > > = > > .../bindings/mtd/cortina,gemini-flash.txt | 24 ------------------- > > .../devicetree/bindings/mtd/mtd-physmap.yaml | 18 +++++++++++++- > > 2 files changed, 17 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mtd/cortina,gemin= i-flash.txt > > = > > diff --git a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash= .txt b/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > deleted file mode 100644 > > index efa5b2aba829..000000000000 > > --- a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Flash device on Cortina Systems Gemini SoC > > - > > -This flash is regular CFI compatible (Intel or AMD extended) flash chi= ps with > > -some special bits that can be controlled by the machine's system contr= oller. > > - > > -Required properties: > > -- compatible : must be "cortina,gemini-flash", "cfi-flash"; > > -- reg : memory address for the flash chip > > -- syscon : must be a phandle to the system controller > > -- bank-width : width in bytes of flash interface, should be <2> > > - > > -For the rest of the properties, see mtd-physmap.yaml. > > - > > -The device tree may optionally contain sub-nodes describing partitions= of the > > -address space. See partition.txt for more detail. > > - > > -Example: > > - > > -flash@30000000 { > > - compatible =3D "cortina,gemini-flash", "cfi-flash"; > > - reg =3D <0x30000000 0x01000000>; > > - syscon =3D <&syscon>; > > - bank-width =3D <2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml b/D= ocumentation/devicetree/bindings/mtd/mtd-physmap.yaml > > index f827984936f6..82eb4e0f453b 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > @@ -44,7 +44,9 @@ properties: > > - numonyx,js28f128 > > - sst,sst39vf320 > > - xlnx,xps-mch-emc-2.00.a > > - - const: cfi-flash > > + - enum: > > + - cfi-flash > > + - jedec-flash > = > Why is jedec-flash being added? The old doc made no mention of it. > = Because one board (gemini-dlink-dns-313.dts) use it. See commit a10d862e585e06aacc3a03e230fdf8faf6b1caf0 = """ The flash on the DNS-313 needs to be probed as JEDEC, it does not conform to the common CFI standard. """ I will add this (the addition of jedec-flash) in commmit log. Regards ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2CEFC433F5 for ; Thu, 10 Feb 2022 13:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYhH770XrLHkrfPA38U+aYbMcoR6oJNf+4IFzSoAWbw=; b=qkbQRM7HLX90tP DqKHJ4V+7c2jf9Ey0uHLBoCQYjemA0XwDvyF5ajtcWrJ/0E+93SB5qtyN3otGnGy0I5mbSNFnzuD9 E72ZGAk8NISyfVc17RPT3C1feyHba2aI2BOC7NeAel+gblufM68X+ZwaTnnZWMPZw0caiwH4Fnwe3 lNgqZSZSRFt7whMuth/z0axFOu91zpOum1cirdk/cW3yPzzIvwMJ/bf4qLlKWUzwhOhnGx7uWwBnZ u+KEj2j7jL37lwU6kyedmemeTdJBDdegDtsHrwU2xuJL9S0hlmefkWChTfaDZk/DGDGaozLW0UGlY Da3BWkf8hKwAkbRhoofQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9To-003sfi-MW; Thu, 10 Feb 2022 13:27:24 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI9Tl-003seV-6P for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 13:27:22 +0000 Received: by mail-wr1-x436.google.com with SMTP id v12so9630492wrv.2 for ; Thu, 10 Feb 2022 05:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=ppLX4h1TEy8PBW7a4orzxmSRVpkxMMzDVgFrPPO+f6wmqSNbpVbyd980agqXUsmsK4 1t3S3V3yoGn5PBZR2wXsNiBwTiBg+7IWH1M5aJJPZiGs155neECX0Xdc2i3WXR7UwbMM aT3Xtfs00uZGf1TbnMYWNrEUtQHMZ5qRjlmiRc0/xqYQhMq8duwRHg0U0Z9pXtKzJ45Q hYfhYVE/1cZLNyTrYw1GNDxUZjkYoAd3FPrsD2ljbrv3HGwfrkyETIATbgIB71TaTNDV dnfvww2HWwcMyGbOkxaLGF8pIQWjKAPbfSCnWB56bK0zNRSMtsjTh7NuJVkUEYKppMbv lTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lccT1vDs39uO4OztszPn43naV87bgv8lF79Kis/tyDI=; b=U7VqsALFJZ2tJYclFPQAOeDoZAfNg4iJeqWR7V/LZ+N7zfkvyVrxJI292MkKKVKLDy /N8IUyLLtWyXLcnNAOJJr15NGphhLgqOqHeA2ogyiK5zZfah/jjm2ft+tSO3LBQ/eboI QTLQMcMiT1PE31dOsvkUekLNMqI8POaDJ5ZCs9fN6ipP0LupyBcgcty4BenQz8Es+Q6z On5tcA0y8I5nhQXqxx+z4cm7m4AVkZrSx0tIOkJNL8qpG03QYwHKcXFo83K4fCZ7Qx/o wacvRLFzVMxOOk+rf7po4Jby/89ISMIjcujnn9aZXNiUTGOwdsKhqkxZYgsTqK/f6oKr mLZQ== X-Gm-Message-State: AOAM530IriXBuy8GRURhC/WXpPB4t3SFKQUMRDFrOQxjT/Gy66M/C5aF Tk2nRB7d1oYHovQIyK9S65ATRg== X-Google-Smtp-Source: ABdhPJzKId3yDGkhp6bPVmSqb71G1h0/VzUuaq+GY1xoayMe32i7GhkM4V+qZRiTEWVDWxES+I9IMA== X-Received: by 2002:a5d:4745:: with SMTP id o5mr485824wrs.275.1644499638587; Thu, 10 Feb 2022 05:27:18 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id h6sm1559790wmq.26.2022.02.10.05.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 05:27:18 -0800 (PST) Date: Thu, 10 Feb 2022 14:27:15 +0100 From: LABBE Corentin To: Rob Herring Cc: linus.walleij@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2] dt-bindings: mtd: drop mtd/cortina,gemini-flash.txt Message-ID: References: <20220131080858.1777518-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_052721_248853_B65AD439 X-CRM114-Status: GOOD ( 24.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Wed, Feb 09, 2022 at 03:18:41PM -0600, Rob Herring a =E9crit : > On Mon, Jan 31, 2022 at 08:08:58AM +0000, Corentin Labbe wrote: > > Drop mtd/cortina,gemini-flash.txt since it is nearly already handled by > > Documentation/devicetree/bindings/mtd/mtd-physmap.yaml. > > = > > Reviewed-by: Linus Walleij > > Signed-off-by: Corentin Labbe > > --- > > Change since v1: > > - fixed typo on syscon > > = > > .../bindings/mtd/cortina,gemini-flash.txt | 24 ------------------- > > .../devicetree/bindings/mtd/mtd-physmap.yaml | 18 +++++++++++++- > > 2 files changed, 17 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mtd/cortina,gemin= i-flash.txt > > = > > diff --git a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash= .txt b/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > deleted file mode 100644 > > index efa5b2aba829..000000000000 > > --- a/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Flash device on Cortina Systems Gemini SoC > > - > > -This flash is regular CFI compatible (Intel or AMD extended) flash chi= ps with > > -some special bits that can be controlled by the machine's system contr= oller. > > - > > -Required properties: > > -- compatible : must be "cortina,gemini-flash", "cfi-flash"; > > -- reg : memory address for the flash chip > > -- syscon : must be a phandle to the system controller > > -- bank-width : width in bytes of flash interface, should be <2> > > - > > -For the rest of the properties, see mtd-physmap.yaml. > > - > > -The device tree may optionally contain sub-nodes describing partitions= of the > > -address space. See partition.txt for more detail. > > - > > -Example: > > - > > -flash@30000000 { > > - compatible =3D "cortina,gemini-flash", "cfi-flash"; > > - reg =3D <0x30000000 0x01000000>; > > - syscon =3D <&syscon>; > > - bank-width =3D <2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml b/D= ocumentation/devicetree/bindings/mtd/mtd-physmap.yaml > > index f827984936f6..82eb4e0f453b 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.yaml > > @@ -44,7 +44,9 @@ properties: > > - numonyx,js28f128 > > - sst,sst39vf320 > > - xlnx,xps-mch-emc-2.00.a > > - - const: cfi-flash > > + - enum: > > + - cfi-flash > > + - jedec-flash > = > Why is jedec-flash being added? The old doc made no mention of it. > = Because one board (gemini-dlink-dns-313.dts) use it. See commit a10d862e585e06aacc3a03e230fdf8faf6b1caf0 = """ The flash on the DNS-313 needs to be probed as JEDEC, it does not conform to the common CFI standard. """ I will add this (the addition of jedec-flash) in commmit log. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel