From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C48C433F5 for ; Fri, 11 Feb 2022 06:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231983AbiBKGx2 (ORCPT ); Fri, 11 Feb 2022 01:53:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbiBKGx1 (ORCPT ); Fri, 11 Feb 2022 01:53:27 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83A790 for ; Thu, 10 Feb 2022 22:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v7Rcpas2mjKtdBymBHzFJE+MqkNyqWK+H8/1t8QY0Q0=; b=FTO8kNEOLcBcWa9E9fwM/zZD30 MVHc3xezzeoV8uVEwkhoWo+lceVZm44vfp51zya8PKsHslNvhSSL2XfK1AEzZG/dWkyJEe3b85Ey9 cDGrjSamdTfj4V8FB4tEuhNnWtuAIxzGHA3AR0IGcev4SZhNsW+4vRhIEUxKFU70yaAXoIZnYcGYi 78OrRGX3XrAxH4PYf6LFgVeSq7vCPaMtG47xU/94vvYDjqPLZa6Um/0ui4z+RDzwSYAmVCq84nsvN UXZZgsw0rJv+xfvhci9yN1FWmAbgxMQ1WZX5U3tDd9LfhiGxNbo22nRqVMlRo2FnfJs55AjT4/yVT XYC526Bg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIPo5-0061TC-Ft; Fri, 11 Feb 2022 06:53:25 +0000 Date: Thu, 10 Feb 2022 22:53:25 -0800 From: Christoph Hellwig To: Mike Snitzer Cc: dm-devel@redhat.com, linux-block@vger.kernel.org Subject: Re: [PATCH 05/14] dm: remove impossible BUG_ON in __send_empty_flush Message-ID: References: <20220210223832.99412-1-snitzer@redhat.com> <20220210223832.99412-6-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210223832.99412-6-snitzer@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Feb 10, 2022 at 05:38:23PM -0500, Mike Snitzer wrote: > The flush_bio in question was just initialized to be empty, so there > is no way bio_has_data() will retrun true. So remove stale BUG_ON(). s/retrun/return/ Otherwise looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE3DBC433EF for ; Fri, 11 Feb 2022 06:59:19 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-194-sOievFOVNRic6vybsMsnPw-1; Fri, 11 Feb 2022 01:59:15 -0500 X-MC-Unique: sOievFOVNRic6vybsMsnPw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 411B01091DA4; Fri, 11 Feb 2022 06:59:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26C1E4EC66; Fri, 11 Feb 2022 06:59:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E57991809CBA; Fri, 11 Feb 2022 06:59:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21B6rVBp016126 for ; Fri, 11 Feb 2022 01:53:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 97BD4407E241; Fri, 11 Feb 2022 06:53:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93886407E240 for ; Fri, 11 Feb 2022 06:53:31 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7EF09811E76 for ; Fri, 11 Feb 2022 06:53:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-09zO5zPlPdCMnKRG109-2g-1; Fri, 11 Feb 2022 01:53:26 -0500 X-MC-Unique: 09zO5zPlPdCMnKRG109-2g-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIPo5-0061TC-Ft; Fri, 11 Feb 2022 06:53:25 +0000 Date: Thu, 10 Feb 2022 22:53:25 -0800 From: Christoph Hellwig To: Mike Snitzer Message-ID: References: <20220210223832.99412-1-snitzer@redhat.com> <20220210223832.99412-6-snitzer@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220210223832.99412-6-snitzer@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH 05/14] dm: remove impossible BUG_ON in __send_empty_flush X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Feb 10, 2022 at 05:38:23PM -0500, Mike Snitzer wrote: > The flush_bio in question was just initialized to be empty, so there > is no way bio_has_data() will retrun true. So remove stale BUG_ON(). s/retrun/return/ Otherwise looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel