From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C195C433EF for ; Fri, 11 Feb 2022 19:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352864AbiBKTX1 (ORCPT ); Fri, 11 Feb 2022 14:23:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352839AbiBKTXW (ORCPT ); Fri, 11 Feb 2022 14:23:22 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A8E38F for ; Fri, 11 Feb 2022 11:23:17 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 81A991EC03E3; Fri, 11 Feb 2022 20:23:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644607391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=oR/oiP2+65T59bcpRG/IiQefT+dXNy/7dsGfjaAi0GI=; b=GKGFboMf/wBRjfxFpYTqOyZBtfEICQqIy5As/LsZiwBlHRi5cAtkoMW5NKWyzYsWwRP1M1 ne0XxG0fO3brwcM7hTuIRJTbvxgt+IPPqu20qmTDSZvDtFt/GG0HZ+qBTBzjG7om+nlV4J W1qCH6lDn6Q/mPiOLq4Wl/1c/H4UgH0= Date: Fri, 11 Feb 2022 20:23:13 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset Message-ID: References: <20220127204115.384161-1-yazen.ghannam@amd.com> <20220127204115.384161-3-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220127204115.384161-3-yazen.ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 08:40:53PM +0000, Yazen Ghannam wrote: > @@ -1099,22 +1140,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr > ctx.nid = nid; > ctx.inst_id = umc; > > - /* Read D18F0x1B4 (DramOffset), check if base 1 is used. */ > - if (df_indirect_read_instance(nid, 0, 0x1B4, umc, &ctx.tmp)) > + if (remove_dram_offset(&ctx)) { > + pr_debug("Failed to remove DRAM offset"); You don't need that pr_debug - remove_dram_offset() already has one for the single error case. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette