From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B402C433F5 for ; Fri, 11 Feb 2022 16:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351563AbiBKQer (ORCPT ); Fri, 11 Feb 2022 11:34:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351554AbiBKQeq (ORCPT ); Fri, 11 Feb 2022 11:34:46 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D701D65 for ; Fri, 11 Feb 2022 08:34:45 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id v5-20020a17090a4ec500b001b8b702df57so12411621pjl.2 for ; Fri, 11 Feb 2022 08:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nnbh1kcsPFrkObOs46hEdsbrlaqoVOUtEvBqKgaq+f4=; b=d5ekGY39eMlMbpMvv/K+V1eUuxLZLh3unB3n7ncytffyG3c1xxOj/pnvUaDvLHp2tL qq4LwyufFmnekBFCTOqBEYSAxUA2btVoNm4NcMJWppvrT+2DLu8mFLyPAoz2Bku6lqeW yip7ROgpgf0Q+h3mdGz8mTAeHlts9S2wE7Ftp+NZsLeZzpognpiS1WYm5IEWnDYpVAJW p1XGTbhWJmW9nrKPuWbqdp6oNrd8Qm0OwrPogu8zogjsPH1SL3xuDopFI97uitonJz9e GKqRae9DJ/uf/ZbACdhh7jRxtuqm955H07JuDE/rqkcN+WqMZAVeRFL0Ey3MUYpNJAo/ Ecug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nnbh1kcsPFrkObOs46hEdsbrlaqoVOUtEvBqKgaq+f4=; b=r9BRB2M301ktTqgRni2xoJ6R+gJ38ytwQJfYeym/76pPW5WovsHxwdzl07ja/f3LPu /DEFKVTMV6PUQ8U0AtI6tldXDPj0s4vQ8r8Vxc3KTK2H3i03indXk1dkw8omrmAU1SrU f/vp9m+ND8EjjQ2iqUgi1UqkafsIUT+3bgX2AQyg31rwpRMiC+JdZM3ZB9/SNGZe4WW8 d6JhQUZtuM57D2cCOJxa6gpxzXQ0s+vkSe8ogjsr0OWc2T88N5Bu17v8gY9/i0YDfhES kG1hTkw5qGuP6O63Ir+1HjSEYhgL29eh3ZEvDv/wqqPD+2lyKrFh1DiuNufq6dS++ZgT 2Lbw== X-Gm-Message-State: AOAM531A7nINKXcCpH7agwyY35r+tt79+ocsFfb4DsFLTP2FnmzS0Jlk YlhsMrFNb7/+mP2lWm4HbhsT+Q== X-Google-Smtp-Source: ABdhPJx+osARJx/twyvZl7y4qsl5OM6D7RX8kmclkHHmc/IvYT0ruVeU/6sp/h17pjZsGWSbBXpqbg== X-Received: by 2002:a17:90a:ea85:: with SMTP id h5mr1201105pjz.13.1644597284563; Fri, 11 Feb 2022 08:34:44 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id md9sm5690196pjb.6.2022.02.11.08.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 08:34:43 -0800 (PST) Date: Fri, 11 Feb 2022 16:34:40 +0000 From: Sean Christopherson To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 07/49] KVM: x86: replace bitmap_weight with bitmap_empty where appropriate Message-ID: References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-8-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210224933.379149-8-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022, Yury Norov wrote: > In some places kvm/hyperv.c code calls bitmap_weight() to check if any bit > of a given bitmap is set. It's better to use bitmap_empty() in that case > because bitmap_empty() stops traversing the bitmap as soon as it finds > first set bit, while bitmap_weight() counts all bits unconditionally. > > Signed-off-by: Yury Norov > Reviewed-by: Vitaly Kuznetsov > --- Reviewed-by: Sean Christopherson