From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E178CC433FE for ; Fri, 11 Feb 2022 17:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352078AbiBKRY4 (ORCPT ); Fri, 11 Feb 2022 12:24:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245653AbiBKRYy (ORCPT ); Fri, 11 Feb 2022 12:24:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EF8ECDB; Fri, 11 Feb 2022 09:24:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16EC861BD2; Fri, 11 Feb 2022 17:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D803C340E9; Fri, 11 Feb 2022 17:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644600292; bh=sljsI0xTOIzuKtd7B7+GsEnYM7lL3thpAyNttIuX1OU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HNQu6IG5Zyb/cFoDLen30JIrZxQ6YiJb1GQkoZyEPkUqMoWooeP3cbt47vukAi1Yn BkcA5hhJqWVR5HdMUVc189EXvhOI5jEqXTYvf1EJ2EIiF+45tAjFUp5JqSA8CkSuei mzG7fwKXkQOXY5uwvHgEAxG6KP0rMRtC/8MO9aR3McOEnioqPqYKs+8RvvE0hgmb4k Kqv0IcnIK7/3zjoVfcollLmkCmQt+EEZWntEu4/vO8ndT4S4hF3IpJiWm+bRvMW7B/ 4pIunXdkiv2/GnwZzCcpTb8z1En1zHP4nWmS2LVXPPqSHd/Bx1Hk6yx/U2WtaTvgLc dFK4CIGAt7gjA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 9EC26400FE; Fri, 11 Feb 2022 14:24:50 -0300 (-03) Date: Fri, 11 Feb 2022 14:24:50 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , James Clark , John Garry , Riccardo Mancini , Yury Norov , Andy Shevchenko , Andrew Morton , Jin Yao , Adrian Hunter , Leo Yan , Andi Kleen , Thomas Richter , Kan Liang , Madhavan Srinivasan , Shunsuke Nakamura , Song Liu , Masami Hiramatsu , Steven Rostedt , Miaoqian Lin , Stephen Brennan , Kajol Jain , Alexey Bayduraev , German Gomez , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Dmitry Vyukov , Hao Luo , eranian@google.com Subject: Re: [PATCH v3 06/22] perf test: Use pointer for maps Message-ID: References: <20220211103415.2737789-1-irogers@google.com> <20220211103415.2737789-7-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211103415.2737789-7-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 11, 2022 at 02:33:59AM -0800, Ian Rogers escreveu: > struct maps is reference counted, using a pointer is more idiomatic. > > Signed-off-by: Ian Rogers > --- > tools/perf/tests/maps.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/tools/perf/tests/maps.c b/tools/perf/tests/maps.c > index e308a3296cef..6f53f17f788e 100644 > --- a/tools/perf/tests/maps.c > +++ b/tools/perf/tests/maps.c > @@ -35,7 +35,7 @@ static int check_maps(struct map_def *merged, unsigned int size, struct maps *ma > > static int test__maps__merge_in(struct test_suite *t __maybe_unused, int subtest __maybe_unused) > { > - struct maps maps; > + struct maps *maps; > unsigned int i; > struct map_def bpf_progs[] = { > { "bpf_prog_1", 200, 300 }, > @@ -64,7 +64,7 @@ static int test__maps__merge_in(struct test_suite *t __maybe_unused, int subtest > struct map *map_kcore1, *map_kcore2, *map_kcore3; > int ret; > > - maps__init(&maps, NULL); > + maps = maps__new(NULL); Any __news() method can fail, so we should check for that and bail out. > for (i = 0; i < ARRAY_SIZE(bpf_progs); i++) { > struct map *map; > @@ -74,7 +74,7 @@ static int test__maps__merge_in(struct test_suite *t __maybe_unused, int subtest > > map->start = bpf_progs[i].start; > map->end = bpf_progs[i].end; > - maps__insert(&maps, map); > + maps__insert(maps, map); > map__put(map); > } > > @@ -99,25 +99,25 @@ static int test__maps__merge_in(struct test_suite *t __maybe_unused, int subtest > map_kcore3->start = 880; > map_kcore3->end = 1100; > > - ret = maps__merge_in(&maps, map_kcore1); > + ret = maps__merge_in(maps, map_kcore1); > TEST_ASSERT_VAL("failed to merge map", !ret); > > - ret = check_maps(merged12, ARRAY_SIZE(merged12), &maps); > + ret = check_maps(merged12, ARRAY_SIZE(merged12), maps); > TEST_ASSERT_VAL("merge check failed", !ret); > > - ret = maps__merge_in(&maps, map_kcore2); > + ret = maps__merge_in(maps, map_kcore2); > TEST_ASSERT_VAL("failed to merge map", !ret); > > - ret = check_maps(merged12, ARRAY_SIZE(merged12), &maps); > + ret = check_maps(merged12, ARRAY_SIZE(merged12), maps); > TEST_ASSERT_VAL("merge check failed", !ret); > > - ret = maps__merge_in(&maps, map_kcore3); > + ret = maps__merge_in(maps, map_kcore3); > TEST_ASSERT_VAL("failed to merge map", !ret); > > - ret = check_maps(merged3, ARRAY_SIZE(merged3), &maps); > + ret = check_maps(merged3, ARRAY_SIZE(merged3), maps); > TEST_ASSERT_VAL("merge check failed", !ret); > > - maps__exit(&maps); > + maps__delete(maps); > return TEST_OK; > } > > -- > 2.35.1.265.g69c8d7142f-goog -- - Arnaldo