From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C508C433FE for ; Sat, 12 Feb 2022 11:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234020AbiBLLKN (ORCPT ); Sat, 12 Feb 2022 06:10:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiBLLKM (ORCPT ); Sat, 12 Feb 2022 06:10:12 -0500 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F222654C for ; Sat, 12 Feb 2022 03:10:08 -0800 (PST) Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.94.2) (envelope-from ) id 1nIqI0-000bvq-QS; Sat, 12 Feb 2022 12:10:04 +0100 Received: from laforge by localhost.localdomain with local (Exim 4.95) (envelope-from ) id 1nIqDi-005Btu-4b; Sat, 12 Feb 2022 12:05:38 +0100 Date: Sat, 12 Feb 2022 12:05:38 +0100 From: Harald Welte To: "Drewek, Wojciech" Cc: Marcin Szycik , "netdev@vger.kernel.org" , "michal.swiatkowski@linux.intel.com" , "davem@davemloft.net" , "kuba@kernel.org" , "pablo@netfilter.org" , "osmocom-net-gprs@lists.osmocom.org" Subject: Re: [RFC PATCH net-next v4 4/6] gtp: Implement GTP echo response Message-ID: References: <20220204164929.10356-1-marcin.szycik@linux.intel.com> <20220204165101.10673-1-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Wojciech, On Fri, Feb 11, 2022 at 12:48:35PM +0000, Drewek, Wojciech wrote: > I have one question. The new cmd should be allowed to send echo request > only to the peers stored in the kernel space (PDP contexts) or the userspace > daemon has its own list of peers and any request should be allowed to be send? I think we can expect userspace to know the peers (after all, it has created those sessions and knows about the peer IP addresses), so we don't have to verify in the kernel if it is a "valid" peer or not. So a pure "send GTP ECHO req to given IP" and a corresponding "received GTP ECHO resp from given IP" (with relevant parameters) without tracking any state in the kernel should be sufficient. -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)