From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EAD0C433FE for ; Mon, 14 Feb 2022 09:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242868AbiBNJYu (ORCPT ); Mon, 14 Feb 2022 04:24:50 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbiBNJYt (ORCPT ); Mon, 14 Feb 2022 04:24:49 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FFE60A87; Mon, 14 Feb 2022 01:24:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644830682; x=1676366682; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Ed8p7wZmfq9qaecYJ91WYD/Rtq61LoHJ4xgf1YjcwCc=; b=c3CoH1y1hvC3f7K38/iFAfUx3ifQbvWjuZYaLUxtA+GXdoAN590Gmx5+ RkblPnQcWYe8dnDgFRJf/KXq0IIVNZyq6cGlVg9OoeWIlXEyvAs1SjYjy iUVP/F8VFabTi5DpNYwcJ6kSEnA+Nil0diX7W+aej+hf6WpUY2Y4TQHp/ PRK9DI+lJoz57xNqNCeGsbohBYlRYVDy2UAwNmWRbLobVhF3eAGRmSdKy vya111AdTOc4ectwcqH1i75XyW0sCfmBxFu3Xg90emVW7e2H+Pz4p5MiF iTTuouFi3AcTFiRQZ0qckEfgYdk6J2wjoe4t9AtaNQKuecXR6kgXiZOgb g==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="250256698" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="250256698" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 01:24:41 -0800 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="635042341" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 01:24:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nJXaC-004OMi-AY; Mon, 14 Feb 2022 11:23:44 +0200 Date: Mon, 14 Feb 2022 11:23:44 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?iso-8859-1?Q?S=E1?= , Lars-Peter Clausen Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Message-ID: References: <20220210135522.26562-1-andriy.shevchenko@linux.intel.com> <20220213175559.46e8dee2@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220213175559.46e8dee2@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote: > On Thu, 10 Feb 2022 15:55:20 +0200 > Andy Shevchenko wrote: > > > In a couple of messages the constants, which have their definitions, > > are hard coded into the message text. Unhardcode them. > > > > While at it, add a trailing \n where it's currently missing. > > > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Nuno Sá > > Mostly so I can remember what is going on with this patch, > Nuno is OoO and planning to test this series when he returns. > > Given that I'll wait on Nuno's testing. Me too :-) -- With Best Regards, Andy Shevchenko