All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>, Pavel Machek <pavel@ucw.cz>,
	Rob Herring <robh+dt@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] regulator: dt-bindings: maxim,max77693: convert to dtschema
Date: Mon, 14 Feb 2022 17:07:50 +0000	[thread overview]
Message-ID: <YgqMZhNhMRgO0V8t@sirena.org.uk> (raw)
In-Reply-To: <b0aaf1e6-c626-e68c-a0d2-4a7ff372b395@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On Mon, Feb 14, 2022 at 06:01:17PM +0100, Krzysztof Kozlowski wrote:

> You mantioned new features - this approach does not change that. If you
> add new properties to common schema, you already alter bindings. Just
> because we use common part, it does not change the fact that it is a
> bindings change. Adding new features in common schema is the same
> binding change as adding new feature in the specific binding, except
> more work.

> I guess you though that work in scaling, so yes, this scales worse. The
> benefit is that this really restricts usage of regulator to what is
> supported, so allows to detect wrongly configured DTS.

We should have a way of specifying generic properties that doesn't
require us to go through every single user of a binding and updating
them all, then auditing by hand any new users to make sure they didn't
forget one of the generic properties.  This is just error prone and
miserable, especially when most of the checking is done by hand rather
than automated.

> Once coupling (or any other feature) is supported, each of such
> restricted regulator bindings should be independently revised, instead
> of adding this new feature to everything.

Coupling is already supported - it doesn't require anything on the part
of the driver, it's about defining the relationships between supplies
rather than anything the driver or device does.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-02-14 17:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 17:50 [PATCH v2 0/4] leds/power/regulator/mfd: dt-bindings: maxim,max77693: convert to dtschema Krzysztof Kozlowski
2022-01-11 17:50 ` [PATCH v2 1/4] dt-bindings: leds: " Krzysztof Kozlowski
2022-01-11 22:29   ` Rob Herring
2022-01-11 17:50 ` [PATCH v2 2/4] dt-bindings: power: supply: " Krzysztof Kozlowski
2022-01-12 11:31   ` Sebastian Reichel
2022-01-11 17:50 ` [PATCH v2 3/4] regulator: dt-bindings: " Krzysztof Kozlowski
2022-01-11 22:30   ` Rob Herring
2022-02-14 16:41   ` Mark Brown
2022-02-14 16:45     ` Krzysztof Kozlowski
2022-02-14 16:51       ` Mark Brown
2022-02-14 17:01         ` Krzysztof Kozlowski
2022-02-14 17:07           ` Mark Brown [this message]
2022-02-14 17:28             ` Krzysztof Kozlowski
2022-01-11 17:50 ` [PATCH v2 4/4] dt-bindings: mfd: " Krzysztof Kozlowski
2022-01-12  2:26   ` Rob Herring
2022-02-06 17:36 ` [PATCH v2 0/4] leds/power/regulator/mfd: dt-bindings: " Krzysztof Kozlowski
2022-02-07  9:35   ` Lee Jones
2022-02-14 14:14 ` [GIT PULL] Immutable branch between MFD, LED, Power and Regulator due for the v5.18 merge window Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgqMZhNhMRgO0V8t@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.