From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AF7C433FE for ; Tue, 15 Feb 2022 15:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239554AbiBOPHy (ORCPT ); Tue, 15 Feb 2022 10:07:54 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbiBOPHx (ORCPT ); Tue, 15 Feb 2022 10:07:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A27B3F7A; Tue, 15 Feb 2022 07:07:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 538DBB81ABE; Tue, 15 Feb 2022 15:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D57FFC340EB; Tue, 15 Feb 2022 15:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644937661; bh=C7xNWmNB8I2rrsRZNyUMx4Ydc0DZnMgDAkd7yvuIAVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=He9Y/OSYServspfit+tsUU2pbQkfJozuFAfVqhZUxqQqWj6HGkIMyy9krnyIz5884 rF+sIOsmlJVM1O8KtzCUFoT5RTG61sbcW3VB1u1jF7le6rdiqahb4cACeQpyKJ+r0l eU4xirlcN5m8EeTTEjNVMfVdagFpWtYxM4C0hge0aljWeeha6lNV27xgyLjKxOz+ZC sZDE1GR2FA2HHiPJrDGYfPFzBQM+s8kbylXv/jQD3S1syD9DgkzeUfyb6i7TVvbioe p66l00ZhRDXPLc/qf6K2/JUz1Zn+bsbC1pEk7+UaQNPPo84SLB2dGcdwnKbXwgrbSD Wxh+lZQXR5VNQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EB795400FE; Tue, 15 Feb 2022 12:07:38 -0300 (-03) Date: Tue, 15 Feb 2022 12:07:38 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , linux-perf-users@vger.kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf: cs-etm: No-op refactor of synth opt usage Message-ID: References: <20220210200620.1227232-1-james.clark@arm.com> <20220211152026.GC475776@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211152026.GC475776@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 11, 2022 at 11:20:26PM +0800, Leo Yan escreveu: > On Thu, Feb 10, 2022 at 08:06:19PM +0000, James Clark wrote: > > sample_branches and sample_instructions are already saved in the > > synth_opts struct. Other usages like synth_opts.last_branch don't save > > a value, so make this more consistent by always going through synth_opts > > and not saving duplicate values. > > > > Signed-off-by: James Clark > > The patch looks good to me: > > Reviewed-by: Leo Yan Thanks, applied. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEDB6C433EF for ; Tue, 15 Feb 2022 15:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KUY6OJeYa3+v3yL4yjMioIHz6MBqRB4w25//24O5afw=; b=iqiqcCnOrHVflK UH+YPEtAT0bOTase5EI66B1Iiygzhh+Fuofa/5YnM3H/3DecAnN+6+sNAGAIw836YCvLX8V3LlCYx BQw8SvhJ4sMYg3rILnANVs5kXwgyOzoz8n8zqXoPdjLzlucBfVlmvowxI+BtEFKO76f+udNfw6HxD /81TRc/Nzl9urxP11KharW/kLsJwcUzZVEz+VZHWBBH1OALLyPlzwnUnFDI92ehBhW0XIUMDwyQvu j4rhE+BsH4wt3dkJ4M/Lmm9PYhfRoZZd7hpT9hBkf/gmDU6d1/jhYnJmG3EDKoi515iKSsJwhXeow SpG4a/JvIeZe5htN35vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJzQi-003B3h-FM; Tue, 15 Feb 2022 15:07:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJzQd-003B34-Tc for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Feb 2022 15:07:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JTKEKQ9a3djkbFojqcmuOeicrDA6o1GlpYMiVKdAmqY=; b=WYatrBVHxer+8hzWAwKSSRrPXk 0MBvH+/l/urtVCFpyOYmxD6SMwcv1VVflRLXQadgX9pEZ9AbW/4sxfNrTVl5Mvh5ADrjHmadZu273 FTOIAmjrB0KOmQtVFLc7wSh+NdEYC1qrVGS+eFUHIfhFQFEpRRuJztHrZKpgkVAbvGpovJOOrK+ax qdP3hIZBH1kBG47hdOpjZ0xM8xYFB30WevWTaJNPw1QgcDWRUvbi/0S3/b1tILa7Ka51FejxmT524 XluQiByIZaYheZBXeTHMqZgqBSs1p6WEbwBMldyUrpAXP0KIa88HjT/Ft+T/WY4NDVgTwkd9ny+7A AxD+RCeA==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJzQc-00A8U7-2v for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 15:07:42 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EB795400FE; Tue, 15 Feb 2022 12:07:38 -0300 (-03) Date: Tue, 15 Feb 2022 12:07:38 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , linux-perf-users@vger.kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf: cs-etm: No-op refactor of synth opt usage Message-ID: References: <20220210200620.1227232-1-james.clark@arm.com> <20220211152026.GC475776@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220211152026.GC475776@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Fri, Feb 11, 2022 at 11:20:26PM +0800, Leo Yan escreveu: > On Thu, Feb 10, 2022 at 08:06:19PM +0000, James Clark wrote: > > sample_branches and sample_instructions are already saved in the > > synth_opts struct. Other usages like synth_opts.last_branch don't save > > a value, so make this more consistent by always going through synth_opts > > and not saving duplicate values. > > > > Signed-off-by: James Clark > > The patch looks good to me: > > Reviewed-by: Leo Yan Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel