From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B37DC433F5 for ; Wed, 2 Mar 2022 21:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245231AbiCBVXb (ORCPT ); Wed, 2 Mar 2022 16:23:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240838AbiCBVX0 (ORCPT ); Wed, 2 Mar 2022 16:23:26 -0500 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6626527CCE for ; Wed, 2 Mar 2022 13:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=MwoWmhJ+L5r33MNaUe69ZqsjwqZf jvz0RcaU0lS4/UA=; b=aTmph1cKarEUpB5nU+9CwBYH3V0/+/c1bcD3QyAFRjb7 FmUF2T21oAxOY4cazDQbqj0QkJR1coqGR6US1vB0zYx76BBa2Ybn08ePAP7ytHpj RNwlXrJHQROp6//RovsYW8P02Qh9YMtPFks37/8yCdDqt6qUHYYVn7G/fIQbfRA= Received: (qmail 259064 invoked from network); 2 Mar 2022 22:22:37 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 2 Mar 2022 22:22:37 +0100 X-UD-Smtp-Session: l3s3148p1@MRp74ULZAMQgAQnoAGk1AHiBA1wHs4oK Date: Wed, 2 Mar 2022 22:22:37 +0100 From: Wolfram Sang To: Peter Rosin , "linux-i2c@vger.kernel.org" , Christophe JAILLET , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that is not active Message-ID: Mail-Followup-To: Wolfram Sang , Peter Rosin , "linux-i2c@vger.kernel.org" , Christophe JAILLET , "linux-kernel@vger.kernel.org" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jepbhLwGEDWuNCcE" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jepbhLwGEDWuNCcE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 02, 2022 at 10:17:20PM +0100, Wolfram Sang wrote: >=20 > > Attempting to rollback the activation of the current master when > > the current master has not been activated is bad. priv->cur_chan >=20 > But the master is activated? >=20 > 259 /* switch to first parent as active master */ > 260 i2c_demux_activate_master(priv, 0); >=20 > Or am I missing something? :) But _this_ code is affected by the problem you describe, or? 237 if (!adap_np) { 238 dev_err(&pdev->dev, "can't get phandle for pare= nt %d\n", i); 239 err =3D -ENOENT; 240 goto err_rollback; 241 } --jepbhLwGEDWuNCcE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIf4B0ACgkQFA3kzBSg KbZK3g/5AeBNwiDpQudH0ZbIc5TMhKbBsoyIbxK1jJHIxDFPY03TN9vnLHzzKG0R POEMO5fIluTgrKSBuRg0n0osCGXCo6oznf7/Ni6xqZkUdIG9Q/TJNG4lZ3U7EvEB ftzMkHTngywmLqohz+u0nIg0EPXvXJca3ONQZyoSNjf6c8Km1+X+5dXvvwhpBRpS cp9mDdM7Mnb8DSCMcmKGFOpc14Lfq5Fna5jC29C9ajqWgrvgpTWiUMCarEuGpiug Y8Q6V7i1aHkFozZW4RZqjvj4UDXXkktmvhKkih12VYcGGJMLM9jiDvCT7bF4Sf/S QREGU3ce5HxB1LeIwLY+OM4jR5PSOQj1DljvmceI0jm3E0aK6oitXug59OzP07zs 05iAxLA95Q6VvwX05H5ecNlra1k8Q9VlzGnnu6lgUYd9t90DXCedeDSryjzLL4Tb tMKeip+XxNpaHo5So+RgwCE9+uynKB3VEzqtMCOFe6+XTuH9OV3K69m3wKbC1tzE js+9aWXuhohRVr0ccNceRoU9iFIOGqosrHGj7Pp/MCT50vtKQiPL50ZHP4G7fss+ Jzm8SUoaFJmonQJSgVglRECkvUs5fPgws8SScsD+dA3H/KkiM0YVTQf+/jHJvInf LqcHydfykflEfLAew50sZLnaBvMuL7NbUY0CiR793urZvDWlS4k= =cnxv -----END PGP SIGNATURE----- --jepbhLwGEDWuNCcE--