From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF3CC433EF for ; Wed, 2 Mar 2022 15:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240269AbiCBPrI (ORCPT ); Wed, 2 Mar 2022 10:47:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240275AbiCBPq4 (ORCPT ); Wed, 2 Mar 2022 10:46:56 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF816CB650; Wed, 2 Mar 2022 07:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646235972; x=1677771972; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uDEmAHta6/0fV9EWeWY03MnT0yAmLB5e+vpiDUmduww=; b=IfsD9ZSYC9ARSYlKrsSzT47UFFEcPu3/m73ZfFhI1jVc1pc+bea0NI9E DKcBs0D70UQvmXxAtgwO2mU+Ba0KMDyuE/SXBzbqOBtO3H//dvgFjCiPo 7BYEUFbvnhffvWM03Z/7j29Tw12RyW6SqDr6wWeXE8A3i4cxrX6kaUM6d FyBoAsd/BLc/rD6EW6jsJnwMZ/KMG/w65dO/NRxUD1jAq7b04VyrNYr9F zkMQF45kYZpsaozlpDhXs1JwwO4y5jKy4w3H5Z2xkZOOCFHBWFHk8RQij d82Sr+uL5HiJqsdbsTW49lK9SmuuOu4lD4mfWnYLlciRatGz8NBd+Z1CA Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="234047279" X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="234047279" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 07:46:12 -0800 X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="551299872" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 07:46:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPRAG-00AMkQ-Ql; Wed, 02 Mar 2022 17:45:20 +0200 Date: Wed, 2 Mar 2022 17:45:20 +0200 From: Andy Shevchenko To: Christian Borntraeger , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Janosch Frank , Claudio Imbrenda , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle Subject: Re: [PATCH v1 1/1] KVM: s390: Don't cast parameter in bit operations Message-ID: References: <20220223164420.45344-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223164420.45344-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 23, 2022 at 06:44:20PM +0200, Andy Shevchenko wrote: > While in this particular case it would not be a (critical) issue, > the pattern itself is bad and error prone in case somebody blindly > copies to their code. > > Don't cast parameter to unsigned long pointer in the bit operations. > Instead copy to a local variable on stack of a proper type and use. After looking into other similar cases I may conclude they - need to be fixed - out of scope of this change Hence, can this fix be applied? -- With Best Regards, Andy Shevchenko