All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Miguel Ojeda <ojeda@kernel.org>, Lars Poeschel <poeschel@lemonage.de>
Subject: Re: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature
Date: Wed, 2 Mar 2022 17:47:08 +0200	[thread overview]
Message-ID: <Yh+RfBIeC5huOvsA@smile.fi.intel.com> (raw)
In-Reply-To: <20220223154718.83500-1-andriy.shevchenko@linux.intel.com>

On Wed, Feb 23, 2022 at 05:47:16PM +0200, Andy Shevchenko wrote:
> It seems that the lcd2s_redefine_char() has never been properly
> tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
> by the character number (from 0 to 7), but immediately after that
> these bytes are got rewritten by the decoded hex stream.
> 
> Fix the index to fill the buffer after the command and number.

Any comments on this, please? There are fixes and seems auxdisplay subsystem
is a bit lagging... Should we worry about?

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2022-03-02 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 15:47 [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature Andy Shevchenko
2022-02-23 15:47 ` [PATCH v1 2/3] auxdisplay: lcd2s: Fix memory leak in ->remove() Andy Shevchenko
2022-03-03  1:19   ` Miguel Ojeda
2022-02-23 15:47 ` [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object Andy Shevchenko
2022-03-03  1:19   ` Miguel Ojeda
2022-03-02 15:47 ` Andy Shevchenko [this message]
2022-03-02 16:12 ` [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature Geert Uytterhoeven
2022-03-03  1:18 ` Miguel Ojeda
2022-03-03 10:46   ` Miguel Ojeda
2022-03-03 11:02     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yh+RfBIeC5huOvsA@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.