From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Yan Zhu <zhuyan34@huawei.com>,
andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org,
kpsingh@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, liucheng32@huawei.com,
netdev@vger.kernel.org, nixiaoming@huawei.com,
songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com,
yzaikin@google.com, zengweilin@huawei.com
Subject: Re: [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module
Date: Mon, 28 Feb 2022 15:41:40 -0800 [thread overview]
Message-ID: <Yh1dtBTeRtjD0eGp@bombadil.infradead.org> (raw)
In-Reply-To: <df1146a2-c718-fa6c-ec35-de75ff27484f@iogearbox.net>
On Mon, Feb 28, 2022 at 04:53:44PM +0100, Daniel Borkmann wrote:
> Hi Yan,
>
> On 2/23/22 11:28 AM, Yan Zhu wrote:
> > Aggregating the code of the feature in the code file of the feature
> > itself can improve readability and reduce merge conflicts. So move
> > the bpf syscall sysctl table to kernel/bpf/syscall.c
> >
> > Signed-off-by: Yan Zhu <zhuyan34@huawei.com>
> >
> > ---
> > v1->v2:
> > 1.Added patch branch identifier sysctl-next.
> > 2.Re-describe the reason for the patch submission.
>
> I'm not applying it given there is very little value in this change, see also what
> has been said earlier:
>
> https://lore.kernel.org/bpf/CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@mail.gmail.com/
Daniel,
sorry folk are seing you patches with crap commit logs. The
justification should be made clearer: we're moving sysctls out of
kernel/sysctl.c as its a mess. I already moved all filesystem sysctls
out. And with time the goal is to move all sysctls out to their own
susbsystem/actual user.
kernel/sysctl.c has grown to an insane mess and its easy to run
into conflicts with it. The effort to move them out is part of this.
The commit logs should not suck though...
Luis
next prev parent reply other threads:[~2022-02-28 23:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 1:35 [PATCH] bpf: move the bpf syscall sysctl table to its own module Yan Zhu
2022-02-23 1:42 ` Luis Chamberlain
2022-02-23 10:28 ` [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module Yan Zhu
2022-02-28 15:53 ` Daniel Borkmann
2022-02-28 23:41 ` Luis Chamberlain [this message]
2022-03-02 1:58 ` Yan Zhu
2022-03-02 2:04 ` [PATCH v3 sysctl-next] bpf: move bpf sysctls from kernel/sysctl.c " Yan Zhu
2022-03-02 20:39 ` Luis Chamberlain
2022-03-03 23:44 ` Daniel Borkmann
2022-03-04 0:23 ` Luis Chamberlain
2022-04-06 22:41 ` Luis Chamberlain
2022-04-07 7:07 ` [PATCH v4 " Yan Zhu
2022-04-13 14:45 ` Daniel Borkmann
2022-04-13 19:00 ` Luis Chamberlain
2022-04-13 19:40 ` Daniel Borkmann
2022-04-13 19:46 ` Luis Chamberlain
2022-04-13 19:50 ` Daniel Borkmann
2022-02-23 4:28 ` [PATCH] bpf: move the bpf syscall sysctl table to its own module Matthew Wilcox
2022-02-23 5:06 ` Alexei Starovoitov
2022-02-23 9:50 ` Yan Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh1dtBTeRtjD0eGp@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liucheng32@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=songliubraving@fb.com \
--cc=xiechengliang1@huawei.com \
--cc=yhs@fb.com \
--cc=yzaikin@google.com \
--cc=zengweilin@huawei.com \
--cc=zhuyan34@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.