From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4893EC433F5 for ; Tue, 1 Mar 2022 15:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235898AbiCAPsR (ORCPT ); Tue, 1 Mar 2022 10:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234217AbiCAPsP (ORCPT ); Tue, 1 Mar 2022 10:48:15 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E381B7E0 for ; Tue, 1 Mar 2022 07:47:33 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id u16so14564069pfg.12 for ; Tue, 01 Mar 2022 07:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U+GY94RaEa7x1vBqKGSJpgctg0TQe50+gLS4c7hl0cA=; b=LsZnpUaXMouxUUJ2zk0Uc1eAZOf9nYu0e8cSbcXTMwCeZauKHNDvhvz09P++SoSsYG iM3MPmjZOUe/I0RTdbQ5s+QjE06cR2ai0IPfi+4SWn5kA4DgJhiMrNUeqk95WUIKSc81 jMZlTwdc/59EtUtwPSQlCAtL9md96UnllkiW7vhT3oW9x5/7CEt63iTMPYDNaogpMaNB ODcyHgNXq8LrCOUysbDBVYp2CayAonpITwcayxgznyAl1OpVYKiy9ZjBDlcgubZEBWJF D1jIx0H6iQI9n39qkNg+GcRptWyyFCe75H14gwvAY8TQBf9u9qRClhpdMfNkndnQeloB gJrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U+GY94RaEa7x1vBqKGSJpgctg0TQe50+gLS4c7hl0cA=; b=3vZaKfieOerbzQNuMkeEbPzE0Jg33UviYsTIkncttOvRbqxuMHb+Jz9TKJmXmxoepa ryiVVrm6fhzWA/ulYGitZVrPSnaRwVQ8xkLLMAs1utTdu5HWVpUgcSqGGAi34+ZTfJXC pZuMKA83+I3KIhWSnbmJ+1A+2ypTZNihduxllnlXutlmZDupJz8/jm37F9vnMFE6TZU4 yJFbVwehTgZnUg+hOfMlTwmeR5dTVs1023LRiO4KaOBBV9hLHBH+ZbjwBXt6Uc9hwnqm TwdeJ3wEcQ1jc71sKY0iQdGT1eyKe3VsZMMDTP/cwHF9AF9EmliPod7/cBneqtHR/FPD YLEQ== X-Gm-Message-State: AOAM532fULoR7LcwDRveVrVA+5DW23fM66CGtQXDbOwSWe9QPIKXZ1jy bdl17Dmlsbtg5bC6JliE4tnhrg== X-Google-Smtp-Source: ABdhPJx0AiiTffgCoa2WwMXYrCLWzP0cf+USWQGZW5dGBTAIdCO5v8ba87fkK0P5dQUEQ/hEZEXU+g== X-Received: by 2002:a65:604b:0:b0:378:7add:ec47 with SMTP id a11-20020a65604b000000b003787addec47mr12456372pgp.555.1646149653133; Tue, 01 Mar 2022 07:47:33 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id n22-20020a056a0007d600b004f3ba7c23e2sm17581108pfu.37.2022.03.01.07.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 07:47:32 -0800 (PST) Date: Tue, 1 Mar 2022 15:47:28 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, Wanpeng Li , Jim Mattson , Vitaly Kuznetsov , Joerg Roedel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86/mmu: Passing up the error state of mmu_alloc_shadow_roots() Message-ID: References: <20220301124941.48412-1-likexu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301124941.48412-1-likexu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2022, Like Xu wrote: > From: Like Xu > > Just like on the optional mmu_alloc_direct_roots() path, once shadow > path reaches "r = -EIO" somewhere, the caller needs to know the actual > state in order to enter error handling and avoid something worse. Well that's emabarrassing. > Fixes: 4a38162ee9f1 ("KVM: MMU: load PDPTRs outside mmu_lock") Cc: stable@vger.kernel.org > Signed-off-by: Like Xu > --- Reviewed-by: Sean Christopherson