From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Luca Weiss <luca@z3ntu.xyz>,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v13 2/2] leds: Add driver for Qualcomm LPG
Date: Tue, 1 Mar 2022 15:24:54 -0800 [thread overview]
Message-ID: <Yh6rRuAcyiF6QnFi@ripper> (raw)
In-Reply-To: <20220224165939.4275x7mzp7qpl2kj@pengutronix.de>
On Thu 24 Feb 08:59 PST 2022, Uwe Kleine-K?nig wrote:
> On Fri, Feb 18, 2022 at 10:31:16AM -0800, Bjorn Andersson wrote:
[..]
> > diff --git a/Documentation/leds/leds-qcom-lpg.rst b/Documentation/leds/leds-qcom-lpg.rst
[..]
> > +Simple pattern::
> > +
> > + "255 500 0 500"
> > +
> > + ^
> > + |
> > + 255 +----+ +----+
> > + | | | | ...
> > + 0 | +----+ +----
> > + +---------------------->
> > + 0 5 10 15 time (100ms)
>
> you're mixing tabs and spaces here, I suggest to use spaces only. Not
> sure you want to respin for that.
>
> (I didn't look into the rest of the driver, but assume it's fine.)
>
Pavel, would yo like me to fix this up and send out v14 or would you be
okay replacing the tab with spaces while applying the patches?
Do you see any other blockers for merging this?
Thanks,
Bjorn
next prev parent reply other threads:[~2022-03-01 23:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 18:31 [PATCH v13 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson
2022-02-18 18:31 ` [PATCH v13 2/2] leds: Add driver for Qualcomm LPG Bjorn Andersson
2022-02-23 5:28 ` Satya Priya
2022-02-24 14:14 ` Thierry Reding
2022-02-24 16:59 ` Uwe Kleine-König
2022-03-01 23:24 ` Bjorn Andersson [this message]
2022-03-03 0:03 ` Doug Anderson
2022-03-03 16:41 ` Doug Anderson
2022-03-03 17:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh6rRuAcyiF6QnFi@ripper \
--to=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.