From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE9FC433FE for ; Wed, 2 Mar 2022 05:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239577AbiCBFjd (ORCPT ); Wed, 2 Mar 2022 00:39:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234343AbiCBFj3 (ORCPT ); Wed, 2 Mar 2022 00:39:29 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BC0EB16D3 for ; Tue, 1 Mar 2022 21:38:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 93DAACE20DA for ; Wed, 2 Mar 2022 05:38:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2671C004E1; Wed, 2 Mar 2022 05:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646199522; bh=mgPJcPrO1O3oxFgOuk+z0pMULpeF1bGzrwK/tGwgqxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oRSe+Qjla0W+lqON6TVItE7i3zM8FNYDgDUHjI+BlUEInKAA7kuz3VzVt12gRRV0J PCRg3sXVeGXmm0xQ4wTgA6wQGGr1LjmVqJHKIvZrHTfCDM9eAVa47QDfI+CRJsYvZA kpuf2QAbE8xhTRegAAPaOToKxBL8/Ph+kCjNqN29Ox6oPZeYZ9cJ13VfTw+CGMijMZ 3gnmiMfe1DO+LiYE/C4KwRICEvDnKZqrw2jUXLUVvfYcBcSqQYMz1qAzsxefAmPQaT oq4KEqaKaVXxQIDLCHsDpW195h+l4jxG7C/8n84CB+mRXfXBJ3TLLCYLorlH7m+zYU AKyUljagKNU6g== Date: Tue, 1 Mar 2022 21:38:41 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid sb_start_intwrite during eviction Message-ID: References: <20220215220039.1477906-1-jaegeuk@kernel.org> <09683b83-b6c0-fe05-0dae-b93cab2f4b63@kernel.org> <4b264607-4d60-7370-eca7-8816a3f8d29f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01, Jaegeuk Kim wrote: > On 03/02, Chao Yu wrote: > > On 2022/3/1 12:48, Jaegeuk Kim wrote: > > > 1. waiting for f2fs_evict_inode > > > [ 5560.043945] __wait_on_freeing_inode+0xac/0xf0 > > > [ 5560.045540] ? var_wake_function+0x30/0x30 > > > [ 5560.047036] find_inode_fast+0x6d/0xc0 > > > [ 5560.048473] iget_locked+0x79/0x230 > > > [ 5560.049933] f2fs_iget+0x27/0x1200 [f2fs] > > > [ 5560.051496] f2fs_lookup+0x18c/0x3e0 [f2fs] > > > [ 5560.053069] __lookup_slow+0x84/0x150 > > > [ 5560.054503] walk_component+0x141/0x1b0 > > > [ 5560.055938] link_path_walk.part.0+0x23b/0x360 > > > [ 5560.057541] ? end_bio_bh_io_sync+0x37/0x50 > > > [ 5560.059086] path_parentat+0x3c/0x90 > > > [ 5560.060492] filename_parentat+0xd7/0x1e0 > > > [ 5560.062002] ? blk_mq_free_request+0x127/0x150 > > > [ 5560.063576] do_renameat2+0xc1/0x5b0 > > > --> sb_start_write(m->mnt_sb); -> __sb_start_write(sb, SB_FREEZE_WRITE); > > > > > > [ 5560.064999] ? __check_object_size+0x13f/0x150 > > > [ 5560.066559] ? strncpy_from_user+0x44/0x150 > > > [ 5560.068038] ? getname_flags.part.0+0x4c/0x1b0 > > > [ 5560.069617] __x64_sys_renameat2+0x51/0x60 > > > > > > 2. waiting for sb_start_intwrite -> __sb_start_write(sb, SB_FREEZE_FS); > > > > It's still not clear that why __sb_start_write(sb, SB_FREEZE_FS) will be blocked, > > as SB_FREEZE_FS and SB_FREEZE_WRITE points to different locks. > > It seems I missed another call, thaw_super(), got SB_FREEZE_FS and then being > stuck to grab SB_FREEZE_WRITE. Ah, sorry. freeze_super(). > > > > > Thread A Thread B Thread C > > - rename > > - sb_start_write > > - __sb_start_write(SB_FREEZE_WRITE) > > ... > > - f2fs_lookup > > ... > > - __wait_on_freeing_inode > > - drop_slab > > - prune_icache_sb > > - inode_lru_isolate > > :inode->i_state |= I_FREEING > > - Is there any flow that it has already held > > SB_FREEZE_FS and try to lock SB_FREEZE_WRITE? > > - f2fs_evict_inode > > - __sb_start_write(SB_FREEZE_FS) > > > > Thanks, > > > > > > > > [ 5560.152447] percpu_rwsem_wait+0xaf/0x160 > > > [ 5560.154000] ? percpu_down_write+0xd0/0xd0 > > > [ 5560.155498] __percpu_down_read+0x4e/0x60 > > > [ 5560.157000] f2fs_evict_inode+0x5a3/0x610 [f2fs] > > > [ 5560.158648] ? var_wake_function+0x30/0x30 > > > [ 5560.160341] evict+0xd2/0x180 > > > [ 5560.161728] prune_icache_sb+0x81/0xb0 > > > --> inode_lru_isolate() -> inode->i_state |= I_FREEING; > > > > > > [ 5560.163179] super_cache_scan+0x169/0x1f0 > > > [ 5560.164675] do_shrink_slab+0x145/0x2b0 > > > [ 5560.166121] shrink_slab+0x186/0x2d0 > > > [ 5560.167481] drop_slab_node+0x4a/0x90 > > > [ 5560.168876] drop_slab+0x3e/0x80 > > > [ 5560.170178] drop_caches_sysctl_handler+0x75/0x90 > > > [ 5560.171761] proc_sys_call_handler+0x149/0x280 > > > [ 5560.173328] proc_sys_write+0x13/0x20 > > > [ 5560.174667] new_sync_write+0x117/0x1b0 > > > [ 5560.176120] vfs_write+0x1d5/0x270 > > > [ 5560.177409] ksys_write+0x67/0xe0 > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > Note, I found this call stack. > > > > > > fs/f2fs/inode.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > > index ab8e0c06c78c..882db4bd917b 100644 > > > --- a/fs/f2fs/inode.c > > > +++ b/fs/f2fs/inode.c > > > @@ -778,7 +778,6 @@ void f2fs_evict_inode(struct inode *inode) > > > f2fs_remove_ino_entry(sbi, inode->i_ino, UPDATE_INO); > > > f2fs_remove_ino_entry(sbi, inode->i_ino, FLUSH_INO); > > > - sb_start_intwrite(inode->i_sb); > > > set_inode_flag(inode, FI_NO_ALLOC); > > > i_size_write(inode, 0); > > > retry: > > > @@ -809,7 +808,6 @@ void f2fs_evict_inode(struct inode *inode) > > > if (dquot_initialize_needed(inode)) > > > set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR); > > > } > > > - sb_end_intwrite(inode->i_sb); > > > no_delete: > > > dquot_drop(inode); > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 478E1C433EF for ; Wed, 2 Mar 2022 05:38:57 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nPHhR-0004GL-T6; Wed, 02 Mar 2022 05:38:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nPHhP-0004GF-L1 for linux-f2fs-devel@lists.sourceforge.net; Wed, 02 Mar 2022 05:38:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kwrYpcIthmLxeYkCWRWslmIAmOSb8nkWbcSYnTRI9CA=; b=My14H0959UlwmB4h5WXFuw2Q/B LGC8X+CujOLg556p4flJi4YYR4KNirHQXNIZ5lDQ1QHVytQBgjbeHX3H+GLHfd98B6GqmeL5ftdIt XU1heI0O4HsMjzjKvjwLz+O+3g/x/bEFNDPupW7dplkTxlLMqyP9Y1keo/1pyBit3Ma0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kwrYpcIthmLxeYkCWRWslmIAmOSb8nkWbcSYnTRI9CA=; b=Kx1ITJunuUq5SRxT6gXTfB+ub9 gK7WeLaKgM3TEiMAoyTOB9BvX+K57NfJbPJgWc5h4AVUnL5ymIddm4+l+KSlpTFgJ+EjxPWMunfbn jrOCtYqpxmlI2EWWb1Dm8FNMJb/K3zwoefHXGxSB6h2ycq3VPmV7ufJW1zBToGg6F/EU=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nPHhI-00008P-T2 for linux-f2fs-devel@lists.sourceforge.net; Wed, 02 Mar 2022 05:38:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 79F5861846 for ; Wed, 2 Mar 2022 05:38:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2671C004E1; Wed, 2 Mar 2022 05:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646199522; bh=mgPJcPrO1O3oxFgOuk+z0pMULpeF1bGzrwK/tGwgqxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oRSe+Qjla0W+lqON6TVItE7i3zM8FNYDgDUHjI+BlUEInKAA7kuz3VzVt12gRRV0J PCRg3sXVeGXmm0xQ4wTgA6wQGGr1LjmVqJHKIvZrHTfCDM9eAVa47QDfI+CRJsYvZA kpuf2QAbE8xhTRegAAPaOToKxBL8/Ph+kCjNqN29Ox6oPZeYZ9cJ13VfTw+CGMijMZ 3gnmiMfe1DO+LiYE/C4KwRICEvDnKZqrw2jUXLUVvfYcBcSqQYMz1qAzsxefAmPQaT oq4KEqaKaVXxQIDLCHsDpW195h+l4jxG7C/8n84CB+mRXfXBJ3TLLCYLorlH7m+zYU AKyUljagKNU6g== Date: Tue, 1 Mar 2022 21:38:41 -0800 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220215220039.1477906-1-jaegeuk@kernel.org> <09683b83-b6c0-fe05-0dae-b93cab2f4b63@kernel.org> <4b264607-4d60-7370-eca7-8816a3f8d29f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1nPHhI-00008P-T2 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid sb_start_intwrite during eviction X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 03/01, Jaegeuk Kim wrote: > On 03/02, Chao Yu wrote: > > On 2022/3/1 12:48, Jaegeuk Kim wrote: > > > 1. waiting for f2fs_evict_inode > > > [ 5560.043945] __wait_on_freeing_inode+0xac/0xf0 > > > [ 5560.045540] ? var_wake_function+0x30/0x30 > > > [ 5560.047036] find_inode_fast+0x6d/0xc0 > > > [ 5560.048473] iget_locked+0x79/0x230 > > > [ 5560.049933] f2fs_iget+0x27/0x1200 [f2fs] > > > [ 5560.051496] f2fs_lookup+0x18c/0x3e0 [f2fs] > > > [ 5560.053069] __lookup_slow+0x84/0x150 > > > [ 5560.054503] walk_component+0x141/0x1b0 > > > [ 5560.055938] link_path_walk.part.0+0x23b/0x360 > > > [ 5560.057541] ? end_bio_bh_io_sync+0x37/0x50 > > > [ 5560.059086] path_parentat+0x3c/0x90 > > > [ 5560.060492] filename_parentat+0xd7/0x1e0 > > > [ 5560.062002] ? blk_mq_free_request+0x127/0x150 > > > [ 5560.063576] do_renameat2+0xc1/0x5b0 > > > --> sb_start_write(m->mnt_sb); -> __sb_start_write(sb, SB_FREEZE_WRITE); > > > > > > [ 5560.064999] ? __check_object_size+0x13f/0x150 > > > [ 5560.066559] ? strncpy_from_user+0x44/0x150 > > > [ 5560.068038] ? getname_flags.part.0+0x4c/0x1b0 > > > [ 5560.069617] __x64_sys_renameat2+0x51/0x60 > > > > > > 2. waiting for sb_start_intwrite -> __sb_start_write(sb, SB_FREEZE_FS); > > > > It's still not clear that why __sb_start_write(sb, SB_FREEZE_FS) will be blocked, > > as SB_FREEZE_FS and SB_FREEZE_WRITE points to different locks. > > It seems I missed another call, thaw_super(), got SB_FREEZE_FS and then being > stuck to grab SB_FREEZE_WRITE. Ah, sorry. freeze_super(). > > > > > Thread A Thread B Thread C > > - rename > > - sb_start_write > > - __sb_start_write(SB_FREEZE_WRITE) > > ... > > - f2fs_lookup > > ... > > - __wait_on_freeing_inode > > - drop_slab > > - prune_icache_sb > > - inode_lru_isolate > > :inode->i_state |= I_FREEING > > - Is there any flow that it has already held > > SB_FREEZE_FS and try to lock SB_FREEZE_WRITE? > > - f2fs_evict_inode > > - __sb_start_write(SB_FREEZE_FS) > > > > Thanks, > > > > > > > > [ 5560.152447] percpu_rwsem_wait+0xaf/0x160 > > > [ 5560.154000] ? percpu_down_write+0xd0/0xd0 > > > [ 5560.155498] __percpu_down_read+0x4e/0x60 > > > [ 5560.157000] f2fs_evict_inode+0x5a3/0x610 [f2fs] > > > [ 5560.158648] ? var_wake_function+0x30/0x30 > > > [ 5560.160341] evict+0xd2/0x180 > > > [ 5560.161728] prune_icache_sb+0x81/0xb0 > > > --> inode_lru_isolate() -> inode->i_state |= I_FREEING; > > > > > > [ 5560.163179] super_cache_scan+0x169/0x1f0 > > > [ 5560.164675] do_shrink_slab+0x145/0x2b0 > > > [ 5560.166121] shrink_slab+0x186/0x2d0 > > > [ 5560.167481] drop_slab_node+0x4a/0x90 > > > [ 5560.168876] drop_slab+0x3e/0x80 > > > [ 5560.170178] drop_caches_sysctl_handler+0x75/0x90 > > > [ 5560.171761] proc_sys_call_handler+0x149/0x280 > > > [ 5560.173328] proc_sys_write+0x13/0x20 > > > [ 5560.174667] new_sync_write+0x117/0x1b0 > > > [ 5560.176120] vfs_write+0x1d5/0x270 > > > [ 5560.177409] ksys_write+0x67/0xe0 > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > Note, I found this call stack. > > > > > > fs/f2fs/inode.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > > index ab8e0c06c78c..882db4bd917b 100644 > > > --- a/fs/f2fs/inode.c > > > +++ b/fs/f2fs/inode.c > > > @@ -778,7 +778,6 @@ void f2fs_evict_inode(struct inode *inode) > > > f2fs_remove_ino_entry(sbi, inode->i_ino, UPDATE_INO); > > > f2fs_remove_ino_entry(sbi, inode->i_ino, FLUSH_INO); > > > - sb_start_intwrite(inode->i_sb); > > > set_inode_flag(inode, FI_NO_ALLOC); > > > i_size_write(inode, 0); > > > retry: > > > @@ -809,7 +808,6 @@ void f2fs_evict_inode(struct inode *inode) > > > if (dquot_initialize_needed(inode)) > > > set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR); > > > } > > > - sb_end_intwrite(inode->i_sb); > > > no_delete: > > > dquot_drop(inode); > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel