From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56951C433FE for ; Wed, 2 Mar 2022 10:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235310AbiCBK3u (ORCPT ); Wed, 2 Mar 2022 05:29:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233902AbiCBK3t (ORCPT ); Wed, 2 Mar 2022 05:29:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C81E68F983; Wed, 2 Mar 2022 02:29:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 735E4B81F64; Wed, 2 Mar 2022 10:29:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA9CEC004E1; Wed, 2 Mar 2022 10:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646216944; bh=SxiAf4w0t5Z/laDZISR+TqH6C7L6uEHJCHh5rWwHoak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au0FuN8NZqg5fQ+d6O/N1dmXPu5GNfYEnDbEMSaNG1Y8T2Tj3ITcdCF+0wuIe+1Ah n/4TUvcQEpUqLJNbhS5GCJAMPbx5IaJfUSfUfh1M1K7pKH10FHyZMcLMjMGLhYYV5L IueFz4+O6nHwvx8amotFPOc55B48mTAqTV4VWUdU= Date: Wed, 2 Mar 2022 11:29:00 +0100 From: Greg KH To: Herbert Xu Cc: Linus Torvalds , Giovanni Cabiddu , Kyle Sanderson , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , Linux Crypto Mailing List , device-mapper development Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote: > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote: > > > > It sounds like it was incidental and almost accidental that it fixed > > that thing, and nobody realized it should perhaps be also moved to > > stable. > > Yes this was incidental. The patch in question fixes an issue in > OOM situations where drivers that must allocate memory on each > request may lead to dead-lock so it's not really targeted at qat. Ok, so what commits should I backport to kernels older than 5.10 to resolve this? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C6D2C433F5 for ; Wed, 2 Mar 2022 10:37:04 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-261-HtVe68V-M7O6TtBdt-g_jg-1; Wed, 02 Mar 2022 05:36:59 -0500 X-MC-Unique: HtVe68V-M7O6TtBdt-g_jg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE8491091DA0; Wed, 2 Mar 2022 10:36:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF0B17B6FF; Wed, 2 Mar 2022 10:36:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C9C7F1809C98; Wed, 2 Mar 2022 10:36:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 222Aajwm024975 for ; Wed, 2 Mar 2022 05:36:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id B38EF401E3C; Wed, 2 Mar 2022 10:36:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFFB4401DB0 for ; Wed, 2 Mar 2022 10:36:45 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 923A629AB3E1 for ; Wed, 2 Mar 2022 10:36:45 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-IZzGUDpFO0W7ebmte8x9JA-1; Wed, 02 Mar 2022 05:36:43 -0500 X-MC-Unique: IZzGUDpFO0W7ebmte8x9JA-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC7356168E; Wed, 2 Mar 2022 10:29:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA9CEC004E1; Wed, 2 Mar 2022 10:29:03 +0000 (UTC) Date: Wed, 2 Mar 2022 11:29:00 +0100 From: Greg KH To: Herbert Xu Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-loop: dm-devel@redhat.com Cc: Giovanni Cabiddu , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , device-mapper development , Kyle Sanderson , Linux Crypto Mailing List , Linus Torvalds Subject: Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote: > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote: > > > > It sounds like it was incidental and almost accidental that it fixed > > that thing, and nobody realized it should perhaps be also moved to > > stable. > > Yes this was incidental. The patch in question fixes an issue in > OOM situations where drivers that must allocate memory on each > request may lead to dead-lock so it's not really targeted at qat. Ok, so what commits should I backport to kernels older than 5.10 to resolve this? thanks, greg k-h -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel