From: Andrew Lunn <andrew@lunn.ch>
To: Heyi Guo <guoheyi@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Joel Stanley <joel@jms.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dylan Hung <dylan_hung@aspeedtech.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Issue report] drivers/ftgmac100: DHCP occasionally fails during boot up or link down/up
Date: Sat, 19 Feb 2022 19:28:18 +0100 [thread overview]
Message-ID: <YhE2wl7XcTUQvEd4@lunn.ch> (raw)
In-Reply-To: <4964f8c3-8349-4fad-e176-8c26840d1a08@linux.alibaba.com>
On Sat, Feb 19, 2022 at 06:08:35PM +0800, Heyi Guo wrote:
> Hi Andrew,
>
> The DHCP issue is gone after applying below patch. I put the lock statements
> outside of the pure reset function, for the phydev lock has been acquired
> before calling adjust_link. The lock order in ftgmac100_reset_task() was
> also changed, to make it the same as the lock procedure in adjust_link, in
> which the phydev is locked first and then rtnl_lock. I'm not quite sure
> whether it will bring in any potential dead lock. Any advice?
Did you run the code with CONFIG_PROVE_LOCKING enabled. That will help
detect possible deadlock situations.
Andrew
next prev parent reply other threads:[~2022-02-19 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 6:38 [Issue report] drivers/ftgmac100: DHCP occasionally fails during boot up or link down/up Heyi Guo
2022-02-15 20:50 ` Andrew Lunn
2022-02-17 1:38 ` Heyi Guo
2022-02-19 10:08 ` Heyi Guo
2022-02-19 18:28 ` Andrew Lunn [this message]
2022-02-20 12:26 ` Heyi Guo
2022-02-21 22:09 ` Andrew Lunn
2022-02-22 3:09 ` Heyi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhE2wl7XcTUQvEd4@lunn.ch \
--to=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dylan_hung@aspeedtech.com \
--cc=guoheyi@linux.alibaba.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.