From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE4DC433F5 for ; Sun, 20 Feb 2022 19:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241895AbiBTT05 (ORCPT ); Sun, 20 Feb 2022 14:26:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236189AbiBTT04 (ORCPT ); Sun, 20 Feb 2022 14:26:56 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A68F09; Sun, 20 Feb 2022 11:26:34 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id x5so18651010wrg.13; Sun, 20 Feb 2022 11:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LWm5zdqv8O8Xcr8Kowr4BNABtqELiYBN0AVoYt4UafA=; b=LlalxNhXyqFcmQ5R61au2Y4lhsstuBzakGzWUN17uOPYGVQ8/Mu8FKB+iDQ2uhG/Yv ycplkYECdRdI86zotWf/xRkoVyAjSO5G3uCFycbrJ+etX19xFOheKMRro/IncoAGxfFG uh/wdkP27uCwTfxX013GC1c4VsbFnM/FH/PmBy81WSvP/2tUuMJFiIR3571ABWGvdPcj ymveYjSLE6/KrQLt6KkpPPuWmnFYrxYppYjMVTCBJ9MVrrtmiFlcp4hXzK/UHLbgmpNi TB1kpr1u80j7+0l2LpNVw2LhdaM8azo9F5aeN7eInZam3FqHifgRVMJ8oP0+jSob1nUt dYjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LWm5zdqv8O8Xcr8Kowr4BNABtqELiYBN0AVoYt4UafA=; b=eI0K/rzfi1x2XMoWNfmKOs4SbqO1QMff1I2frCmBSerR3mzAcWWsnpQijHb0a3pU2c 5yOspHahRdyWzIF7U5R2MXdfeRDgdrY5Uyu3RaaysjY299cBbKI8Nh6P+/NH0/6rcO0p 2JtlQbFybj+PoRuQ6ZciBO9KimuNc+nh5sWpYN1V9M6poMR5Z0O67oFxAvaMcwpROIV8 /crXYooPSScfMzzOxJpVaEU2lrPp+zCfngnKD1VRy7W1+374awBaQRvYAporRQo4S+qn WNJDNUGRYbp+qR3eTWHnkwbiDfhqPevjXNbTbWqzB1SYc6HVyE4SNdHCRG62nYK6u091 /5ew== X-Gm-Message-State: AOAM532HsnRSyzjb1XygEUmaowkqJWXR0LuIk8M6EVF71B+6eegxQnm1 JFIU9eGWgQV5w1eHCOWSRDE= X-Google-Smtp-Source: ABdhPJwMOVuvQ8z/+4ZmEfqQy6za0nykUsMgsj4Sz2Tggw/rAZrFm/q2KL7k17rHt2+1FHGidReF0w== X-Received: by 2002:a5d:5045:0:b0:1e3:20ed:4386 with SMTP id h5-20020a5d5045000000b001e320ed4386mr13185334wrt.262.1645385193397; Sun, 20 Feb 2022 11:26:33 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id a17-20020a05600c069100b0037ddbe6da71sm5301378wmn.20.2022.02.20.11.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 11:26:33 -0800 (PST) Date: Sun, 20 Feb 2022 20:26:31 +0100 From: Corentin Labbe To: Gilad Ben-Yossef Cc: Herbert Xu , Linux Crypto Mailing List , Linux kernel mailing list Subject: Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le Thu, Feb 17, 2022 at 09:38:10PM +0200, Gilad Ben-Yossef a écrit : > So, I still do not have access to my Salvator-X board but I attempted > a fix nevertheless and it does not seem to trigger new failures on the > boards I do have so please give it a shot and let me know. > > And thanks again for taking the time to report this! > > Cheers, > Gilad Hello While testing your patch for this problem, I saw another warning (unrelated with your patch): [ 34.061953] ------------[ cut here ]------------ [ 34.066656] DMA-API: ccree e6601000.crypto: cacheline tracking EEXIST, overlapping mappings aren't supported [ 34.076555] WARNING: CPU: 3 PID: 475 at /home/clabbe/linux-next/kernel/dma/debug.c:571 add_dma_entry+0x1d0/0x288 [ 34.086748] Modules linked in: [ 34.089809] CPU: 3 PID: 475 Comm: cryptomgr_test Tainted: G W 5.17.0-rc3-next-20220210-00115-g1ca9f29d9780-dirty #25 [ 34.101635] Hardware name: Renesas Salvator-X board based on r8a77950 (DT) [ 34.108508] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 34.115471] pc : add_dma_entry+0x1d0/0x288 [ 34.119569] lr : add_dma_entry+0x1d0/0x288 [ 34.123664] sp : ffff80000e3236f0 [ 34.126976] x29: ffff80000e3236f0 x28: 0000000000000000 x27: 0000000000000000 [ 34.134122] x26: 0000000000000000 x25: ffff80000b3c76c0 x24: ffff80000b3c7000 [ 34.141267] x23: 0000000000000000 x22: 00000000ffffffef x21: ffff80000a8c1000 [ 34.148410] x20: ffff0004c0b93f80 x19: ffff80000b320000 x18: ffffffffffffffff [ 34.155554] x17: 6c7265766f202c54 x16: 534958454520676e x15: 00000000000001fa [ 34.162697] x14: ffff80000e3233f0 x13: 00000000ffffffea x12: ffff80000b3bdda0 [ 34.169840] x11: 0000000000000001 x10: 0000000000000001 x9 : ffff80000b3a5db8 [ 34.176984] x8 : c0000000ffffefff x7 : 0000000000017fe8 x6 : ffff80000b3a5d60 [ 34.184126] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 : 00000000ffffefff [ 34.191269] x2 : ffff80000b34db38 x1 : 371dfc0f85526100 x0 : 0000000000000000 [ 34.198411] Call trace: [ 34.200856] add_dma_entry+0x1d0/0x288 [ 34.204604] debug_dma_map_sg+0x150/0x398 [ 34.208615] __dma_map_sg_attrs+0x9c/0x108 [ 34.212717] dma_map_sg_attrs+0x10/0x28 [ 34.216554] cc_map_sg+0x80/0x100 [ 34.219875] cc_map_cipher_request+0x170/0x3c8 [ 34.224319] cc_cipher_process+0x210/0xb58 [ 34.228415] cc_cipher_encrypt+0x2c/0x38 [ 34.232338] crypto_skcipher_encrypt+0x44/0x78 [ 34.236786] drbg_kcapi_sym_ctr+0xdc/0x1f8 [ 34.240887] drbg_ctr_generate+0x5c/0x98 [ 34.244812] drbg_kcapi_random+0xb4/0x260 [ 34.248823] alg_test_stdrng+0xf8/0x2b0 [ 34.252661] alg_test.part.29+0xb4/0x398 [ 34.256583] alg_test+0x48/0x78 [ 34.259724] cryptomgr_test+0x48/0x50 [ 34.263386] kthread+0x11c/0x128 [ 34.266619] ret_from_fork+0x10/0x20 [ 34.270198] irq event stamp: 318 [ 34.273424] hardirqs last enabled at (317): [] __up_console_sem+0x60/0x98 [ 34.281869] hardirqs last disabled at (318): [] el1_dbg+0x28/0x90 [ 34.289531] softirqs last enabled at (314): [] __do_softirq+0x4a8/0x5ec [ 34.297796] softirqs last disabled at (305): [] irq_exit_rcu+0x18c/0x1b0 [ 34.306061] ---[ end trace 0000000000000000 ]--- Regards