From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AB3C433F5 for ; Sun, 20 Feb 2022 20:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244949AbiBTUlv (ORCPT ); Sun, 20 Feb 2022 15:41:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244092AbiBTUlt (ORCPT ); Sun, 20 Feb 2022 15:41:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B274504B; Sun, 20 Feb 2022 12:41:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0A0D60F17; Sun, 20 Feb 2022 20:41:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD4F5C340E8; Sun, 20 Feb 2022 20:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645389687; bh=NQ8nXe3tjE2N3Ndt228c9UJWNiE0K0BRbJeSV+4uTkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QE9mMiafVndvVXi/jeeu6XcJbcf+ek+fMuGx3gviIREdY7FSEGJ0WDaSTgckl56o2 pOo+0iPf4MiIjLLJDi2fEoZCqPkxhF+gG5majeoQZpjAmljc1XEFg0Llo80B8rUhG8 v9Zp+UaJWZW21I9a3jsRTyu/De5WaJmO3XTiCKfQdhA7E5aBoqeFDNShGXSNMa+Suy kZvM3m55JI4q8ZQ23eRAoDJw/zmPKA7cECMJqV7yBSBdabq8IMP7gZf6DCv3Qi7wU3 NDI0UiCkRUAUM56oEPj8oq4Wh2rj/Go3gCd0cqdIgYDde7NM073XKKH60kT7Qhzfwr 3pJQy3sU44vJg== Date: Sun, 20 Feb 2022 21:42:06 +0100 From: Jarkko Sakkinen To: Dave Hansen Cc: linux-sgx@vger.kernel.org, Dave Hansen , stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jethro Beekman , Sean Christopherson Subject: Re: [PATCH v3] x86/sgx: Free backing memory after faulting the enclave page Message-ID: References: <20220108140510.76583-1-jarkko@kernel.org> <8afec431-4dfc-d8df-152b-76cca0e17ccb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Sun, Feb 20, 2022 at 09:09:27PM +0100, Jarkko Sakkinen wrote: > On Sun, Feb 20, 2022 at 10:58:00AM -0800, Dave Hansen wrote: > > On 2/20/22 10:52, Jarkko Sakkinen wrote: > > >> Am I just all twisted around from looking at this code too much? Could > > >> you please take another look and send a new version of the patch? > > > Yeah, I will. It took me two weeks to make full remote attestation > > > implementation for SGX in Rust but at least I can confirm that all > > > the kernel bits work on that (and this will also help me to finish > > > the man page because it is pretty nasty to document it if you haven't > > > gone to the rabbit hole yourself). > > > > > > I'll prioritize now to get SGX2 patches tested with Enarx implementation > > > but this 2nd thing in my kernel queue. > > > > I really prioritize bug fixes over new features. New features can's > > really get merged until this gets fixed up. > > Fair enough. In this case I was not exactly sure whether it is categorized > as bug or enhancement. Should I also put a fixes tag to this to the > original reclaimer code (since it has been like this since the epoch)? I'll keep the fixes tag, and send a new version of the patch, as soon as I have tested it (working on it right now). BR, Jarkko