From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C43C433F5 for ; Mon, 21 Feb 2022 02:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236764AbiBUCij (ORCPT ); Sun, 20 Feb 2022 21:38:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235152AbiBUCii (ORCPT ); Sun, 20 Feb 2022 21:38:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A683E1EED3; Sun, 20 Feb 2022 18:38:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47B0461124; Mon, 21 Feb 2022 02:38:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8081BC340E8; Mon, 21 Feb 2022 02:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645411095; bh=dR9SzToMmoFqkyh1Vj1H8HzO4u+iPA3s8xWivFtFm3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJodiHhaUOQMMaZWp/ydZMJjun0OLrJEdbTYmfSW7Eso3aerQdP0x8gV5JgJfEXkb 5HdccqbBXa0zbVfshLUwE+oxauzEFLqPyi7LFld9rf3Mm43TtQlHGTXqsG3PJ35teT UEZq+9XC+2/2q2bjILMT9ftoNtXKpYffD+mUhXQxK6T++c22eMFbba27B55U5nNt79 uGxA5TiknqeHX7ar5/93cYJcXkW2fEs5soxKjT0//ydecr6uZFoAuzBsTdnp93JCN4 /8rkfJbyf9zNEdBxNTay06+kkCsb8vGzoITUXy4aNJ+HiRpR0SeMume5ZVwVmhPRrR 9rsm/L+ivbxYQ== Date: Sun, 20 Feb 2022 18:38:14 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, linux@dominikbrodowski.net Subject: Re: [PATCH v2 2/9] random: get rid of secondary crngs Message-ID: References: <20220209011919.493762-1-Jason@zx2c4.com> <20220209011919.493762-3-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209011919.493762-3-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Feb 09, 2022 at 02:19:12AM +0100, Jason A. Donenfeld wrote: > As the comment said, this is indeed a "hack". Since it was introduced, > it's been a constant state machine nightmare, with lots of subtle early > boot issues and a wildly complex set of machinery to keep everything in > sync. Rather than continuing to play whack-a-mole with this approach, > this commit simply removes it entirely. This commit is preparation for > "random: use simpler fast key erasure flow on per-cpu keys" in this > series, which introduces a simpler (and faster) mechanism to accomplish > the same thing. > > Cc: Theodore Ts'o > Cc: Dominik Brodowski > Signed-off-by: Jason A. Donenfeld > --- > drivers/char/random.c | 225 ++++++++++-------------------------------- > 1 file changed, 53 insertions(+), 172 deletions(-) Reviewed-by: Eric Biggers - Eric