From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DA8C433F5 for ; Tue, 22 Feb 2022 15:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbiBVPhn (ORCPT ); Tue, 22 Feb 2022 10:37:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233394AbiBVPhW (ORCPT ); Tue, 22 Feb 2022 10:37:22 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D90163D5A; Tue, 22 Feb 2022 07:36:23 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8A88A1EC0478; Tue, 22 Feb 2022 16:36:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1645544177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=aij7NjY9ZQjgmVDgEW1KRwEwnwbxjt+LJNVGVugfzBg=; b=mVLxeE0TUg9Jlj9JbMpInhMy0w0ftP1W3XN+a4MG+VO4BtBq0a5upSYITit3RuUFiEgFao 0uQAQckBp4+TLx2ACyGqLWfoZ9H4QPUkuLy5Gn15czprfb1SZOjWc0ipqFyFSDXfDtdtWG EQVeCJIu9PeLyP6E3uWJ/JB5ijiquxU= Date: Tue, 22 Feb 2022 16:36:25 +0100 From: Borislav Petkov To: Smita Koralahalli Cc: x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck , Dave Hansen , "H . Peter Anvin" , James Morse , Robert Richter , Yazen Ghannam Subject: Re: [PATCH v3 4/4] x86/mce: Avoid unnecessary padding in struct mce_bank Message-ID: References: <20220211223442.254489-1-Smita.KoralahalliChannabasappa@amd.com> <20220211223442.254489-5-Smita.KoralahalliChannabasappa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220211223442.254489-5-Smita.KoralahalliChannabasappa@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 11, 2022 at 04:34:42PM -0600, Smita Koralahalli wrote: > Include struct mce_bank member "init" in the bitfield by changing its type > from bool to get rid of unnecessary padding and to reduce the overall > struct size. > > Outputs collected before and after the change. > > $ pahole -C mce_bank arch/x86/kernel/cpu/mce/core.o > > before: > > /* size: 24, cachelines: 1, members: 5 */ > /* bit holes: 1, sum bit holes: 62 bits */ > /* bit_padding: 2 bits */ > /* last cacheline: 24 bytes */ > > after: > > /* size: 16, cachelines: 1, members: 5 */ > /* last cacheline: 16 bytes */ I don't mind cleanups like that but when you send them as part of a set adding new functionality, the usual rule is to put bug fixes, cleanups, improvements, etc to the existing code *first*, and then, ontop you add your new code. IOW, this patch should be first in your set. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette