From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAA6C433FE for ; Wed, 23 Feb 2022 10:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237804AbiBWKYi (ORCPT ); Wed, 23 Feb 2022 05:24:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbiBWKYi (ORCPT ); Wed, 23 Feb 2022 05:24:38 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C45AA8C7D8; Wed, 23 Feb 2022 02:24:08 -0800 (PST) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 9398E6434C; Wed, 23 Feb 2022 11:23:04 +0100 (CET) Date: Wed, 23 Feb 2022 11:24:04 +0100 From: Pablo Neira Ayuso To: Nicolas Dichtel Cc: Florian Westphal , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority Message-ID: References: <20220204102637.4272-1-nicolas.dichtel@6wind.com> <8c08a4e0-83a0-9fc1-798b-dbd6a53f7231@6wind.com> <20220204120126.GB15954@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 23, 2022 at 10:01:48AM +0100, Nicolas Dichtel wrote: > > Le 04/02/2022 à 15:20, Pablo Neira Ayuso a écrit : > > On Fri, Feb 04, 2022 at 01:01:26PM +0100, Florian Westphal wrote: > >> Nicolas Dichtel wrote: > >>> > >>> Le 04/02/2022 à 11:26, Nicolas Dichtel a écrit : > >>>> Available since linux v5.18. > >>>> > >>>> Link: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id= > >>>> Signed-off-by: Nicolas Dichtel > >>>> --- > >>> > >>> Should I send another patch for the 'set' part? > >>> In this case, a nfq_set_verdict3(). The name is a bit ugly ;-) > >>> Any suggestions? > >> > >> I think we should just let the old api die and tell users > >> to use the mnl interface, that allows to add the new attribute > >> as soon as its available. > > > > We have to provide a simple API based on mnl which ressembles the > > existing old API. > > > > Feedback in these years is that there are a users that do not need to > > know about netlink details / advanced handling. > > If I understand well, libnetfilter_queue is deprecated? This library is not deprecated. > If this is right, maybe it could be advertised on the project page: > https://netfilter.org/projects/libnetfilter_queue/index.html Documentation already mentions this: https://netfilter.org/projects/libnetfilter_queue/doxygen/html/