From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: kernel@openvz.org, ltp@lists.linux.it,
Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Subject: Re: [LTP] [PATCH] testcases/lib: introduce sysctl wrapper
Date: Wed, 23 Feb 2022 15:47:19 +0100 [thread overview]
Message-ID: <YhZI99JpVu0c1HGY@pevik> (raw)
In-Reply-To: <YhYsJqnjs1kIt13E@yuki>
> Hi!
> > > Ah, right. But I guess that adding a simple tool that would behave just
> > > as echo but the first parameter would be filename may be cleaner
> > > solution than wrapping around the sysctl command.
> > +1. If really requested please create C binary testcases/lib/tst_sysctl.c.
> > Code which use simple SAFE_FILE_PRINTF() as many C code does would be fairly
> > simple, more portable and probably faster than shell script. FYI we tend to
> > rewrite shell code into C.
> I would even call it tst_write since it's pretty generic tool that does
> write to a file.
+1, good point.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-02-23 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:55 [LTP] [PATCH] testcases/lib: introduce sysctl wrapper Nikita Yushchenko via ltp
2022-02-22 16:09 ` Cyril Hrubis
2022-02-22 16:09 ` Nikita Yushchenko via ltp
2022-02-22 17:35 ` Cyril Hrubis
2022-02-22 18:31 ` Petr Vorel
2022-02-23 12:44 ` Cyril Hrubis
2022-02-23 14:47 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhZI99JpVu0c1HGY@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=kernel@openvz.org \
--cc=ltp@lists.linux.it \
--cc=nikita.yushchenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.