From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1DEC433EF for ; Fri, 25 Feb 2022 06:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237940AbiBYGtr (ORCPT ); Fri, 25 Feb 2022 01:49:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbiBYGtp (ORCPT ); Fri, 25 Feb 2022 01:49:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A9661D63AC; Thu, 24 Feb 2022 22:49:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E3189B82A97; Fri, 25 Feb 2022 06:49:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B38ECC340E7; Fri, 25 Feb 2022 06:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645771751; bh=BjNnUDa6YlGgHdiU/3W/Okj0r21M2eZrvd1rB4FoNeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YO1rSojNZX7K70GU6AqJDWQ2IFRsUyUKjWVllXrmh2m8IMqneE8wc9qDilxDUucew lCPKNRD5HLLbhGHtqzHosuaC7lOzMtxf7dEPmzq1XpobO6WxyBdwmdpU9gA4fMhcDh exwRtBpoK9jcCXqkmel+58l9zq2P0a9hHzaAENlM= Date: Fri, 25 Feb 2022 07:49:06 +0100 From: Greg Kroah-Hartman To: Henry Lin Cc: "mathias.nyman@intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume Message-ID: References: <20220225055311.92447-1-henryl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Feb 25, 2022 at 06:40:53AM +0000, Henry Lin wrote: > It fixes side effect from below change. > > commit a231ec41e6f6433daf4c693f169f6c5cfda8cb9d > Author: Mathias Nyman > Date: Fri Dec 7 16:19:35 2018 +0200 > > xhci: refactor U0 link state handling in get_port_status > > Move U0 link state handing to USB3 and USB2 specific functions > > Note that > bus_state->resuming_ports: > bus_state->resume_done[]: > are only used for USB2, and don't need to cleared for USB3 ports > > No functional changes > > Signed-off-by: Mathias Nyman > Signed-off-by: Greg Kroah-Hartman Great, please add a "Fixes:" tag to the patch when resubmitting it. And the "no functional changes" seems not to have been true, right? Does this need to go into the stable kernels? thanks, greg k-h