All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: jolsa@redhat.com, andrii.nakryiko@gmail.com, andrii@kernel.org,
	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net,
	john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org,
	netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
Subject: Re: [RFC bpf-next 0/2] bpf: Fix BTF data for modules
Date: Fri, 25 Feb 2022 18:15:03 +0100	[thread overview]
Message-ID: <YhkOl42elY6RckDt@krava> (raw)
In-Reply-To: <878rtz84ol.fsf@oc8242746057.ibm.com>

On Fri, Feb 25, 2022 at 02:19:06PM +0100, Alexander Egorenkov wrote:
> 
> Hi Jiri and Andrii,
> 
> we also have discovered this problem recently on Fedora 35 and linux-next.
> Is there any status update here ?

Andrii made the fix:
  https://lore.kernel.org/bpf/20211117194114.347675-1-andrii@kernel.org/

IIRC there's still some issues, but they dont have too big
impact on the size, it's discussed in that link

> 
> @Jiri
> Is the increase of total kernel modules size by 20MB really a big deal
> on s390x ? We would like to have it enabled on our architecture
> again ;-) And 20MB seems okay or am i missing something maybe ?

20M is not that much, the problem was that it's double the size
of all the modules and it was problem on rhel, where the impact
was much bigger for some reason

the fix seems to be already in fedora kernel so we could enable
BTF for s390x, I'll check on that

> 
> Another question i have wrt to BTF is why is it necessary to have e.g.
> _struct module_ be present within kernel module BTF if it is already
> present within vmlinux's one ? Can't the one from vmlinux be reused for
> kernel modules as well, they should be identical, right ?

that's basically the issue.. the dedup algo did not cover all the
cases so BTF kept both module structs because they were 'different'

jirka

> 
> Thanks
> Regards
> Alex

  reply	other threads:[~2022-02-25 17:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 12:04 [RFC bpf-next 0/2] bpf: Fix BTF data for modules Jiri Olsa
2021-10-23 12:04 ` [PATCH bpf-next 1/2] kbuild: Unify options for BTF generation for vmlinux and modules Jiri Olsa
2021-10-26  4:56   ` Andrii Nakryiko
2021-10-26 12:03     ` Jiri Olsa
2021-10-23 12:04 ` [PATCH bpf-next 2/2] bpf: Add support to detect and dedup instances of same structs Jiri Olsa
2021-10-26  4:59   ` Andrii Nakryiko
2021-10-26  4:54 ` [RFC bpf-next 0/2] bpf: Fix BTF data for modules Andrii Nakryiko
2021-10-26 12:03   ` Jiri Olsa
2021-10-27  4:12     ` Andrii Nakryiko
2021-10-27  8:53       ` Jiri Olsa
2021-10-27 17:53         ` Andrii Nakryiko
2021-10-27 18:18           ` Jiri Olsa
2021-10-28 19:12             ` Jiri Olsa
2021-11-01 23:14               ` Andrii Nakryiko
2021-11-02 14:14                 ` Jiri Olsa
2021-11-07 14:57                   ` Jiri Olsa
2021-11-09 23:23                     ` Andrii Nakryiko
2021-11-12  7:23                       ` Jiri Olsa
2022-02-25 13:19                         ` Alexander Egorenkov
2022-02-25 17:15                           ` Jiri Olsa [this message]
2021-10-28  1:44           ` Kumar Kartikeya Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhkOl42elY6RckDt@krava \
    --to=olsajiri@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=egorenar@linux.ibm.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.