From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9BFC433FE for ; Mon, 28 Feb 2022 06:41:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbiB1Glq (ORCPT ); Mon, 28 Feb 2022 01:41:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbiB1Glp (ORCPT ); Mon, 28 Feb 2022 01:41:45 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E499B673C4 for ; Sun, 27 Feb 2022 22:41:06 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7CFB486; Mon, 28 Feb 2022 07:41:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646030463; bh=edO0zZGShhP8jnTdxIT2KdVMZRlFPKdVXexWbZmjH8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W80sQ5a/F+lzv3KFXp90NwYyXGegLiPguwkx3prMpNyQc6lLvngx05dvE/2wpcZPo QYsndbZcSeQ8LEtSd7Gma/FaBhV5JrF6l0+dN213jhtcTkB7PpC+8Px3WM3Ui7y8aP f932ODXnIeYbbLWCAwBLRoPbudsXA87mlNA8svVg= Date: Mon, 28 Feb 2022 08:40:52 +0200 From: Laurent Pinchart To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Alexander Stein , Lucas Stach , Peng Fan , Rob Herring , Robby Cai , Sam Ravnborg , Stefan Agner , devicetree@vger.kernel.org Subject: Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP Message-ID: References: <20220228004605.367040-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220228004605.367040-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, Thank you for the patch. On Mon, Feb 28, 2022 at 01:45:57AM +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it > has a completely scrambled register layout compared to all previous LCDIF > variants. The new LCDIFv3 also supports 36bit address space. However, > except for the complete bit reshuffling, this is still LCDIF and it still > works like one. > > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Peng Fan > Cc: Rob Herring > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 900a56cae80e6..9831ab53a053d 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -28,6 +28,7 @@ properties: > - fsl,imx7d-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif As the hardware isn't backward-compatible with any other version, I think the new compatible string should go in the previous enum block, not in this one. We don't want the imx6sx fallback. > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51767C4332F for ; Mon, 28 Feb 2022 06:41:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7944E10E1E2; Mon, 28 Feb 2022 06:41:10 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8095610E1E2 for ; Mon, 28 Feb 2022 06:41:09 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7CFB486; Mon, 28 Feb 2022 07:41:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646030463; bh=edO0zZGShhP8jnTdxIT2KdVMZRlFPKdVXexWbZmjH8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W80sQ5a/F+lzv3KFXp90NwYyXGegLiPguwkx3prMpNyQc6lLvngx05dvE/2wpcZPo QYsndbZcSeQ8LEtSd7Gma/FaBhV5JrF6l0+dN213jhtcTkB7PpC+8Px3WM3Ui7y8aP f932ODXnIeYbbLWCAwBLRoPbudsXA87mlNA8svVg= Date: Mon, 28 Feb 2022 08:40:52 +0200 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP Message-ID: References: <20220228004605.367040-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220228004605.367040-1-marex@denx.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Peng Fan , Alexander Stein , dri-devel@lists.freedesktop.org, Rob Herring , Sam Ravnborg , Robby Cai Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, Thank you for the patch. On Mon, Feb 28, 2022 at 01:45:57AM +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it > has a completely scrambled register layout compared to all previous LCDIF > variants. The new LCDIFv3 also supports 36bit address space. However, > except for the complete bit reshuffling, this is still LCDIF and it still > works like one. > > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Peng Fan > Cc: Rob Herring > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 900a56cae80e6..9831ab53a053d 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -28,6 +28,7 @@ properties: > - fsl,imx7d-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif As the hardware isn't backward-compatible with any other version, I think the new compatible string should go in the previous enum block, not in this one. We don't want the imx6sx fallback. > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif > -- Regards, Laurent Pinchart