From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A94C433EF for ; Mon, 28 Feb 2022 13:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234081AbiB1NVw (ORCPT ); Mon, 28 Feb 2022 08:21:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231971AbiB1NVo (ORCPT ); Mon, 28 Feb 2022 08:21:44 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9CB879C45 for ; Mon, 28 Feb 2022 05:21:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5FDEAB80E46 for ; Mon, 28 Feb 2022 13:21:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2B67C340F0; Mon, 28 Feb 2022 13:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646054463; bh=KeGJTMJNqRcQCKpg0+iOp8H0LglmDHJQZv2HgM+qwwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxviUN5EHwgMhvzV7tqR1qtOBnNk5vrbm84rTER0CIWF1VmIkto59cVi/BgGA1szW AgnSWUzyQO4gTTcFzLESGOzNOKpXGmBbeg2te2S/6bGyFj094q6zIROHH6zq+DPg3S gQCqRsw3SraX7+pDmpXJqQJQvyS6a+f8AZoJ9yMYDbCDvhQ0AgNbFWx9HXk+AkjZf6 22TULpk5fGuxAGQpIc07ZDeuPwa5+Pj9XnM756eR7Qy6JAddPS2GtPjvRCn0AABmIZ nYzoBT/c3q7u6P2g8KlevkM9In47QCUHelWqjxcDQubWKgBavwtrPZIFasIhMW6BsJ 1VXqFN3ozDjnw== Date: Mon, 28 Feb 2022 13:20:57 +0000 From: Mark Brown To: David Engraf Cc: suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, elver@google.com, ebiederm@xmission.com, seanjc@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: signal: nofpsimd: Do not allocate fp/simd context when not available Message-ID: References: <20220225104008.820289-1-david.engraf@sysgo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aWi5TuiGes20Vavu" Content-Disposition: inline In-Reply-To: <20220225104008.820289-1-david.engraf@sysgo.com> X-Cookie: Killing turkeys causes winter. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --aWi5TuiGes20Vavu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 25, 2022 at 11:40:08AM +0100, David Engraf wrote: > Commit 6d502b6ba1b2 ("arm64: signal: nofpsimd: Handle fp/simd context for > signal frames") introduced saving the fp/simd context for signal handling > only when support is available. But setup_sigframe_layout() always > reserves memory for fp/simd context. The additional memory is not touched > because preserve_fpsimd_context() is not called and thus the magic is > invalid. Reviwed-by: Mark Brown --aWi5TuiGes20Vavu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIczDkACgkQJNaLcl1U h9B8wgf4nCn5QRzwuOVFmXGSoeGx2MbGTxp0GO4WZbq2rD4NSZksLKOjakcgAah1 TFeRu26s9ZDgKVIJvz9bipIRB7UVjV5q+uxnAu/qgpxrd+EM4esh38p2qmjjxp27 IBQBqUts+t9Zu+/pOVgsNsmR2RhDt8C81CwL0sg/r8UP/bfro8/UY5TBH56kNSmO GuLOjXhiFk4xu9qzqFRXurL/SO6Dra8anF8nN4O5+3xuitbIaWM9sUghxwZNcHdA 4Xvehg69DDPWX3+eo+otzzMTcSVJ/eeSPCgBrsrXloisSZqbCxWNhzPpsNKgcGAz UOrnkt39iK9zDsTZ3HvxUDYpbI+b =bNmK -----END PGP SIGNATURE----- --aWi5TuiGes20Vavu-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E267FC433EF for ; Mon, 28 Feb 2022 13:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p23YU4s6lSqtutPgkUh8nNybrBkBQvM/AmkC8E0aDiY=; b=0WK0dKyUEAcVTsrfRFEOfhqMF2 /LKWXFBzTqunP75Ya1WNlO6uD57HMaZQvcc9s1xIOtNr2Ow/I2cYdYNNDJ3XVy5ZlD6bVFqzVHCNd x7vHtdGzy4XJv9I6wkHVAbtcYm7TLNsS2qdpJntmrDyBPiXRZxETe1g3JNlMn+AFqAReWGKEl2SGr YMy2odiejRlqrNA+gUhZ44W+0zQ5gKVumDa1wyspVNsi3Vd0dyqzCFZ9PcDAP5N+0t+cKqgUaGYHN OPDlbD+mb8yeTa++uKGdJor1IkysyfWpGVeQMYeRP0jQb8blHbgUdcCQDnS/ZkmrU+6euszDmHIGY dTib0BzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOg4s-00CZdV-K4; Mon, 28 Feb 2022 13:28:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOfxY-00CWOi-40 for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 13:21:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1B8C6130E; Mon, 28 Feb 2022 13:21:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2B67C340F0; Mon, 28 Feb 2022 13:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646054463; bh=KeGJTMJNqRcQCKpg0+iOp8H0LglmDHJQZv2HgM+qwwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxviUN5EHwgMhvzV7tqR1qtOBnNk5vrbm84rTER0CIWF1VmIkto59cVi/BgGA1szW AgnSWUzyQO4gTTcFzLESGOzNOKpXGmBbeg2te2S/6bGyFj094q6zIROHH6zq+DPg3S gQCqRsw3SraX7+pDmpXJqQJQvyS6a+f8AZoJ9yMYDbCDvhQ0AgNbFWx9HXk+AkjZf6 22TULpk5fGuxAGQpIc07ZDeuPwa5+Pj9XnM756eR7Qy6JAddPS2GtPjvRCn0AABmIZ nYzoBT/c3q7u6P2g8KlevkM9In47QCUHelWqjxcDQubWKgBavwtrPZIFasIhMW6BsJ 1VXqFN3ozDjnw== Date: Mon, 28 Feb 2022 13:20:57 +0000 From: Mark Brown To: David Engraf Cc: suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, elver@google.com, ebiederm@xmission.com, seanjc@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: signal: nofpsimd: Do not allocate fp/simd context when not available Message-ID: References: <20220225104008.820289-1-david.engraf@sysgo.com> MIME-Version: 1.0 In-Reply-To: <20220225104008.820289-1-david.engraf@sysgo.com> X-Cookie: Killing turkeys causes winter. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_052104_236884_E928ABF8 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7653152503606214917==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7653152503606214917== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aWi5TuiGes20Vavu" Content-Disposition: inline --aWi5TuiGes20Vavu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 25, 2022 at 11:40:08AM +0100, David Engraf wrote: > Commit 6d502b6ba1b2 ("arm64: signal: nofpsimd: Handle fp/simd context for > signal frames") introduced saving the fp/simd context for signal handling > only when support is available. But setup_sigframe_layout() always > reserves memory for fp/simd context. The additional memory is not touched > because preserve_fpsimd_context() is not called and thus the magic is > invalid. Reviwed-by: Mark Brown --aWi5TuiGes20Vavu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIczDkACgkQJNaLcl1U h9B8wgf4nCn5QRzwuOVFmXGSoeGx2MbGTxp0GO4WZbq2rD4NSZksLKOjakcgAah1 TFeRu26s9ZDgKVIJvz9bipIRB7UVjV5q+uxnAu/qgpxrd+EM4esh38p2qmjjxp27 IBQBqUts+t9Zu+/pOVgsNsmR2RhDt8C81CwL0sg/r8UP/bfro8/UY5TBH56kNSmO GuLOjXhiFk4xu9qzqFRXurL/SO6Dra8anF8nN4O5+3xuitbIaWM9sUghxwZNcHdA 4Xvehg69DDPWX3+eo+otzzMTcSVJ/eeSPCgBrsrXloisSZqbCxWNhzPpsNKgcGAz UOrnkt39iK9zDsTZ3HvxUDYpbI+b =bNmK -----END PGP SIGNATURE----- --aWi5TuiGes20Vavu-- --===============7653152503606214917== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7653152503606214917==--