From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA690C433F5 for ; Thu, 3 Mar 2022 19:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234680AbiCCTBj (ORCPT ); Thu, 3 Mar 2022 14:01:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbiCCTBi (ORCPT ); Thu, 3 Mar 2022 14:01:38 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0142719F452; Thu, 3 Mar 2022 11:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mYrrOG/s2mjfio75s3dq/dKVQ4hb6AKuIgv4XF18k5o=; b=puVBQooXBZePIB2vmMTSbXd57s p17MgatBJCjBKtRJ+UT1TBodIBURDW/LOhzMJ50muFzytAz8XxJ/BrFPLQ4prU8hIxdCLVJ2wCJH9 TZlwm3rAbg9eJGfQi+uBcbCqS9bstks2nG8cEyx5xEVVy9hZXbSACSKhfmtrS1JMAIGb2Nm7ujVm7 fEAr2epRFpKIzcV4yR7wr7k0C5+ORqH73Md/qogC3eWDJmwJbhh+WbqhyOkk/cvqdd1G8emGY0Wq+ IUDmTg9cCbO+gDzXRygN3zXeeV05WeYo1IodMQrwzObhU5ZJHPFZoUt5BlHoU/WrJzCmPcW0I4q74 EvEhJhzw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPqgl-007WTc-Tq; Thu, 03 Mar 2022 19:00:35 +0000 Date: Thu, 3 Mar 2022 11:00:35 -0800 From: Christoph Hellwig To: Christophe Leroy Cc: Christoph Hellwig , Daniel Thompson , Aaron Tomlin , "mcgrof@kernel.org" , "pmladek@suse.com" , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <20220228234322.2073104-14-atomlin@redhat.com> <20220302161917.gx5icfszakoye4uh@maple.lan> <20220302203153.3kcmwu662szf3drt@ava.usersys.com> <20220303145949.inaz2tecmfuek2hf@maple.lan> <5b582422-ef36-009e-7cb7-b85b5022c9aa@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b582422-ef36-009e-7cb7-b85b5022c9aa@csgroup.eu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: On Thu, Mar 03, 2022 at 06:16:58PM +0000, Christophe Leroy wrote: > Well .... The idea at the first place was to get rid of the #ifdef > CONFIG_KGDB_KDB in modules. > > Here you propose it the other way round. Why not, in that case that > would mean a dedicated file in kernel/module/ as part of the series > https://patchwork.kernel.org/project/linux-modules/list/?series=618917&state=* With the series you can of course move it to a new kernel/module/kdb.c. But I don't have a tree with the series applied at hand and just want to show how kdb_lsmod can live outside of kernel/debug easily.