From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BACC433EF for ; Sun, 6 Mar 2022 22:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234394AbiCFWo5 (ORCPT ); Sun, 6 Mar 2022 17:44:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbiCFWo5 (ORCPT ); Sun, 6 Mar 2022 17:44:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B868A4A3DE; Sun, 6 Mar 2022 14:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+i9vRmNI7+eHzPPl/RuOFsNSwoWFlLZKj3k3cgvkPwE=; b=C7wEujQbkNSEL8UesYZpUV1Owu 5y5vzvRLA9jhhEy3AtVVgWpwbbHaPsCo5A/wYRNy+lJDxAg7gPm6kHeHB+b/2X7tVihHQ1+Wh72Tn RvWNFEYZgum5b1z+ZKpf0mF4Ge8XXlI5X+rbSBmslYhDGMc0PNpXt+zDNP/3EVJ9hDcAybpYQ5Zyb j5j7LEGQZHGR1bi8fvYz+db4QRDs6k/aVLppY9CfeBfPvoevFmwRReAxGu2Vd0KABcvks6N6sdx1d XfJe7O5Zo0QKkhB+1K1wyL3WV9NaZ5ZaZp8DQ7CGhzYQ8Dh7QzNM2aGJ5dYTiP9YgNsYWT9a8BGUI LjpaIgfQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQzb9-00EfoG-RJ; Sun, 06 Mar 2022 22:43:32 +0000 Date: Sun, 6 Mar 2022 22:43:31 +0000 From: Matthew Wilcox To: Jarkko Sakkinen Cc: Greg Kroah-Hartman , linux-mm@kvack.org, Dave Hansen , Nathaniel McCallum , Reinette Chatre , Andrew Morton , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Thomas Bogendoerfer , Matthew Auld , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Daniel Vetter , Jason Ekstrand , Chris Wilson , Maarten Lankhorst , Tvrtko Ursulin , Shakeel Butt , Vasily Averin , zhangyiru , Alexander Mikhalitsyn , Alexey Gladkov , linux-mips@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, codalist@coda.cs.cmu.edu, linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC 1/3] mm: Add f_ops->populate() Message-ID: References: <20220306053211.135762-1-jarkko@kernel.org> <20220306053211.135762-2-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > So can I conclude from this that in general having populate available for > device memory is something horrid, or just the implementation path? You haven't even attempted to explain what the problem is you're trying to solve. You've shown up with some terrible code and said "Hey, is this a good idea". No, no, it's not. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 944FCC433F5 for ; Sun, 6 Mar 2022 22:44:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87A5610E066; Sun, 6 Mar 2022 22:44:15 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4882710E039; Sun, 6 Mar 2022 22:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+i9vRmNI7+eHzPPl/RuOFsNSwoWFlLZKj3k3cgvkPwE=; b=C7wEujQbkNSEL8UesYZpUV1Owu 5y5vzvRLA9jhhEy3AtVVgWpwbbHaPsCo5A/wYRNy+lJDxAg7gPm6kHeHB+b/2X7tVihHQ1+Wh72Tn RvWNFEYZgum5b1z+ZKpf0mF4Ge8XXlI5X+rbSBmslYhDGMc0PNpXt+zDNP/3EVJ9hDcAybpYQ5Zyb j5j7LEGQZHGR1bi8fvYz+db4QRDs6k/aVLppY9CfeBfPvoevFmwRReAxGu2Vd0KABcvks6N6sdx1d XfJe7O5Zo0QKkhB+1K1wyL3WV9NaZ5ZaZp8DQ7CGhzYQ8Dh7QzNM2aGJ5dYTiP9YgNsYWT9a8BGUI LjpaIgfQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQzb9-00EfoG-RJ; Sun, 06 Mar 2022 22:43:32 +0000 Date: Sun, 6 Mar 2022 22:43:31 +0000 From: Matthew Wilcox To: Jarkko Sakkinen Subject: Re: [PATCH RFC 1/3] mm: Add f_ops->populate() Message-ID: References: <20220306053211.135762-1-jarkko@kernel.org> <20220306053211.135762-2-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangyiru , Daniel Vetter , Dave Hansen , dri-devel@lists.freedesktop.org, Chris Wilson , linux-mm@kvack.org, Jason Ekstrand , Alexander Mikhalitsyn , Florian Fainelli , linux-unionfs@vger.kernel.org, codalist@coda.cs.cmu.edu, Matthew Auld , Vasily Averin , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, Shakeel Butt , Reinette Chatre , linux-sgx@vger.kernel.org, Thomas Bogendoerfer , Nathaniel McCallum , Greg Kroah-Hartman , Tvrtko Ursulin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Alexey Gladkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > So can I conclude from this that in general having populate available for > device memory is something horrid, or just the implementation path? You haven't even attempted to explain what the problem is you're trying to solve. You've shown up with some terrible code and said "Hey, is this a good idea". No, no, it's not. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C171AC433EF for ; Sun, 6 Mar 2022 22:44:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF7E110E039; Sun, 6 Mar 2022 22:44:14 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4882710E039; Sun, 6 Mar 2022 22:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+i9vRmNI7+eHzPPl/RuOFsNSwoWFlLZKj3k3cgvkPwE=; b=C7wEujQbkNSEL8UesYZpUV1Owu 5y5vzvRLA9jhhEy3AtVVgWpwbbHaPsCo5A/wYRNy+lJDxAg7gPm6kHeHB+b/2X7tVihHQ1+Wh72Tn RvWNFEYZgum5b1z+ZKpf0mF4Ge8XXlI5X+rbSBmslYhDGMc0PNpXt+zDNP/3EVJ9hDcAybpYQ5Zyb j5j7LEGQZHGR1bi8fvYz+db4QRDs6k/aVLppY9CfeBfPvoevFmwRReAxGu2Vd0KABcvks6N6sdx1d XfJe7O5Zo0QKkhB+1K1wyL3WV9NaZ5ZaZp8DQ7CGhzYQ8Dh7QzNM2aGJ5dYTiP9YgNsYWT9a8BGUI LjpaIgfQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQzb9-00EfoG-RJ; Sun, 06 Mar 2022 22:43:32 +0000 Date: Sun, 6 Mar 2022 22:43:31 +0000 From: Matthew Wilcox To: Jarkko Sakkinen Message-ID: References: <20220306053211.135762-1-jarkko@kernel.org> <20220306053211.135762-2-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH RFC 1/3] mm: Add f_ops->populate() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangyiru , Daniel Vetter , Dave Hansen , dri-devel@lists.freedesktop.org, Chris Wilson , linux-mm@kvack.org, Alexander Mikhalitsyn , Florian Fainelli , linux-unionfs@vger.kernel.org, codalist@coda.cs.cmu.edu, Matthew Auld , Vasily Averin , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, Shakeel Butt , Reinette Chatre , linux-sgx@vger.kernel.org, Thomas Bogendoerfer , Nathaniel McCallum , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Alexey Gladkov Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > So can I conclude from this that in general having populate available for > device memory is something horrid, or just the implementation path? You haven't even attempted to explain what the problem is you're trying to solve. You've shown up with some terrible code and said "Hey, is this a good idea". No, no, it's not.