From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2268C433EF for ; Tue, 8 Mar 2022 18:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348453AbiCHS47 (ORCPT ); Tue, 8 Mar 2022 13:56:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236164AbiCHS45 (ORCPT ); Tue, 8 Mar 2022 13:56:57 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21AE54186 for ; Tue, 8 Mar 2022 10:55:58 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id e15so138819pfv.11 for ; Tue, 08 Mar 2022 10:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y40f+LRCmG2arycVRHxOvpE+w/RZPs9orfaERHReGAg=; b=bcCUYI+9/valn64igaiGGIKkFleK2VVOpLQ/Ce62yPauw4vMRigqISiCiyTYqxAkHQ +oVGv80ZKvRJwlXg2Qb/+JDkRbq42rqCVi/G5e1TshasTHSKtI8YtwMb1fdI0A7tnzEV Lx/0sfSqS/3w3TPB9LX2h7rO3qGKXHQJcXR3QbLzlxKusX0A4VXIU3UMeIBvIEXVatRh gg3zEnioIFLtuYv3zudFcUO9XIX1q4qjWEuG2hKNcqxEVEbEO5hS3e9KgITt/QCE5l5l hqb5XNkxo6PmRpDSkYz0S8aJMm91uZo/+Ctxa1sVlBOy/w8/4Ja8C7xbWXGwhtctt50d n39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y40f+LRCmG2arycVRHxOvpE+w/RZPs9orfaERHReGAg=; b=Vp4p5zdTJQ3Otk991nklQ36E+8AENqsD4D2EFIDQm425qwK0dUxR0mDi7ZpGt6FSGu K3k6nzO2vcz/QGJg4FEpAI6Wwvfpa5n2GaevfbK1ZjeKyM2ZnuGMRMQx8jPUG3F5SbPl 5D/TOIH/BTgZeBhShqn/xLNfEiq3gciIvnCFu6Oo/S9zw6nKzuti7w/e0s3lrsaMPx+3 stHRoxLXoYuogZZtM2FbimtshyzrufkSye3CIpmK4VmRN7o8DHEhEYODOFBBejEo4JY6 XCM9f8rhkPA3E22cebADh4DAyd1Es+3G0B9fqasf6rmTl4xJdWQdfu1+zQ9k5IvmtyQr MwzQ== X-Gm-Message-State: AOAM53352+WRKl2RNhYFakh5c4Hg+ZnkuXAzkg4/Q58/exOsu88UtHnB wkDSSyS9EK/adjxdPI28jFhXdg== X-Google-Smtp-Source: ABdhPJwcEDBu6JX4mIGKlcpXlcrkdx2/792obZa79cvfvYy/QfjS4SaXi48cxFejeJgdTIyDxVMRiQ== X-Received: by 2002:a63:698a:0:b0:36c:1d0a:2808 with SMTP id e132-20020a63698a000000b0036c1d0a2808mr15284498pgc.567.1646765757848; Tue, 08 Mar 2022 10:55:57 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q20-20020a056a00151400b004f3cd061d33sm21169799pfu.204.2022.03.08.10.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 10:55:57 -0800 (PST) Date: Tue, 8 Mar 2022 18:55:53 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dmatlack@google.com Subject: Re: [PATCH v2 08/25] KVM: x86/mmu: split cpu_mode from mmu_role Message-ID: References: <20220221162243.683208-1-pbonzini@redhat.com> <20220221162243.683208-9-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221162243.683208-9-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022, Paolo Bonzini wrote: > @@ -4800,13 +4836,15 @@ kvm_calc_shadow_mmu_root_page_role(struct kvm_vcpu *vcpu, > } > > static void shadow_mmu_init_context(struct kvm_vcpu *vcpu, struct kvm_mmu *context, > - const struct kvm_mmu_role_regs *regs, > - union kvm_mmu_role new_role) > + union kvm_mmu_role cpu_mode, Can you give all helpers this treatment (rename "role" => "cpu_mode")? I got tripped up a few times reading patches because the ones where it wasn't necessary, i.e. where there's only a single kvm_mmu_role paramenter, were left as-is. I think kvm_calc_shadow_npt_root_page_role() and kvm_calc_shadow_mmu_root_page_role() are the only offenders. > + union kvm_mmu_role mmu_role) > { > - if (new_role.as_u64 == context->mmu_role.as_u64) > + if (cpu_mode.as_u64 == context->cpu_mode.as_u64 && > + mmu_role.as_u64 == context->mmu_role.as_u64) > return; > > - context->mmu_role.as_u64 = new_role.as_u64; > + context->cpu_mode.as_u64 = cpu_mode.as_u64; > + context->mmu_role.as_u64 = mmu_role.as_u64; > > if (!is_cr0_pg(context)) > nonpaging_init_context(context);