All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	stable@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>
Subject: Re: [PATCH] arm64: Do not include __READ_ONCE() block in assembly files
Date: Wed, 9 Mar 2022 22:31:59 +0000	[thread overview]
Message-ID: <Yikq33Q9Cfhbce6F@arm.com> (raw)
In-Reply-To: <CAKwvOdkrgtyE3rU8Xa2B8QQJ1ZErSTB9PDuikPF6=4D4Q80XVQ@mail.gmail.com>

On Wed, Mar 09, 2022 at 01:53:50PM -0800, Nick Desaulniers wrote:
> On Wed, Mar 9, 2022 at 11:19 AM Nathan Chancellor <nathan@kernel.org> wrote:
> > Avoid this problem by just avoiding the CONFIG_LTO=y __READ_ONCE() block
> > in asm/rwonce.h with assembly files, as nothing in that block is useful
> > to assembly files, which allows ARM_SMCCC_ARCH_WORKAROUND_3 to be
> > properly expanded with CONFIG_LTO=y builds.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: e35123d83ee3 ("arm64: lto: Strengthen READ_ONCE() to acquire when CONFIG_LTO=y")
> > Link: https://lore.kernel.org/r/20220309155716.3988480-1-maz@kernel.org/
> > Reported-by: Marc Zyngier <maz@kernel.org>
> > Acked-by: James Morse <james.morse@arm.com>
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Thanks for taking point on all of the BHB fallout.
> 
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for the review and testing. Unfortunately I've just sent the pull
request to Linus, so didn't include your tags.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	stable@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>
Subject: Re: [PATCH] arm64: Do not include __READ_ONCE() block in assembly files
Date: Wed, 9 Mar 2022 22:31:59 +0000	[thread overview]
Message-ID: <Yikq33Q9Cfhbce6F@arm.com> (raw)
In-Reply-To: <CAKwvOdkrgtyE3rU8Xa2B8QQJ1ZErSTB9PDuikPF6=4D4Q80XVQ@mail.gmail.com>

On Wed, Mar 09, 2022 at 01:53:50PM -0800, Nick Desaulniers wrote:
> On Wed, Mar 9, 2022 at 11:19 AM Nathan Chancellor <nathan@kernel.org> wrote:
> > Avoid this problem by just avoiding the CONFIG_LTO=y __READ_ONCE() block
> > in asm/rwonce.h with assembly files, as nothing in that block is useful
> > to assembly files, which allows ARM_SMCCC_ARCH_WORKAROUND_3 to be
> > properly expanded with CONFIG_LTO=y builds.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: e35123d83ee3 ("arm64: lto: Strengthen READ_ONCE() to acquire when CONFIG_LTO=y")
> > Link: https://lore.kernel.org/r/20220309155716.3988480-1-maz@kernel.org/
> > Reported-by: Marc Zyngier <maz@kernel.org>
> > Acked-by: James Morse <james.morse@arm.com>
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Thanks for taking point on all of the BHB fallout.
> 
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for the review and testing. Unfortunately I've just sent the pull
request to Linus, so didn't include your tags.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-09 22:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 19:16 [PATCH] arm64: Do not include __READ_ONCE() block in assembly files Nathan Chancellor
2022-03-09 19:16 ` Nathan Chancellor
2022-03-09 21:53 ` Nick Desaulniers
2022-03-09 21:53   ` Nick Desaulniers
2022-03-09 22:31   ` Catalin Marinas [this message]
2022-03-09 22:31     ` Catalin Marinas
2022-03-09 22:35 ` Catalin Marinas
2022-03-09 22:35   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yikq33Q9Cfhbce6F@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.