From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36938C35273 for ; Thu, 10 Mar 2022 16:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242153AbiCJQSl (ORCPT ); Thu, 10 Mar 2022 11:18:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242204AbiCJQSG (ORCPT ); Thu, 10 Mar 2022 11:18:06 -0500 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CC8190B7A for ; Thu, 10 Mar 2022 08:17:01 -0800 (PST) Received: by mail-qt1-x831.google.com with SMTP id a1so4972569qta.13 for ; Thu, 10 Mar 2022 08:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o3XiKem00gLr34GESQrNS9nG0HHXcvKwNDWv//lSnUM=; b=1fMvNcrI8SVPpYX5QeQXT/4iXJRVTUzJeQd1sa60b2pCKrmUm9NbtttV/Kyt8R5muB bwwpBmP5tj0wbJabkvNrWbTYUMXQ1ir91xgoRqdvbXkVfhQPTYQ2Y58FwiFCM26tzVbr rroGMlE+9VDqfWr13l06K8AMZkyhLkkDKU694V6IZoQSJyDXELYvYuJ4s+lSC5LUu0g/ 0arzgD1FEFOxFyaqL4DMiESYWo/unfntY4t++86tkpIS0ezudYQGGho2nAf+HLE9zipp kEEr1OwgMF4GSXwLeMJUoCjOrHkm8LUYuUshvd6q/YZLWgS2P5DB8KKNgkzJ9IqxuIbK atyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o3XiKem00gLr34GESQrNS9nG0HHXcvKwNDWv//lSnUM=; b=Ts4+CrpccEsxn0Ct1W2PjKhDj2YY3dNrLL1QDQs2mCsiO/qf1keWrLgtIvMShgmd+A 5PHmho+K5eFvnER01asq+KB2Z/64VxT03G5ZqA0J8SPDRAZDfXXViQ71XtWQHDLlebet pNEKnbPcKeV54putMTOWtHM0y1xDbfHfpPMKbFJQdve6EFkUvRu/BGIZK20ZZfEu3Qyr 5ScIkPTPvbeICThENj5oyz1sBtzEB7Lte95fUhYOEsE7PgtQssjSyfPCNVN42uR5K0lt 9WBJP9VTSsd80IxQ0tdlqPAwwgD1HAJ0QKq1I7xitHz28+RMVR6e/K1sw85G/Ang8Alh 03vQ== X-Gm-Message-State: AOAM532YdQNDB/ugGdOO8Jf68nWZmM4IQVUhzrtwtLF0/D3+IeDs2Fga HiFDfj6tSkDXnK4wwS18IQxw0g== X-Google-Smtp-Source: ABdhPJxHk9T5sCR1iHYOfvBRYoGqWAwMh2DfAxFoPQdXl/cWJ0bsam+OAT9uib4F75e/XrCLQt9oiw== X-Received: by 2002:ac8:5fd1:0:b0:2d9:4547:9ddb with SMTP id k17-20020ac85fd1000000b002d945479ddbmr4468324qta.149.1646929020380; Thu, 10 Mar 2022 08:17:00 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:5de6]) by smtp.gmail.com with ESMTPSA id f14-20020ac8068e000000b002dd1bc00eadsm3187735qth.93.2022.03.10.08.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 08:17:00 -0800 (PST) Date: Thu, 10 Mar 2022 11:16:41 -0500 From: Johannes Weiner To: Christoph Hellwig Cc: cgel.zte@gmail.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Yang Yang , Ran Xiaokai Subject: Re: [PATCH] block/psi: remove PSI annotations from submit_bio Message-ID: References: <20220309094323.2082884-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 09, 2022 at 10:46:52PM -0800, Christoph Hellwig wrote: > On Wed, Mar 09, 2022 at 02:18:19PM -0500, Johannes Weiner wrote: > > On Wed, Mar 09, 2022 at 09:43:24AM +0000, cgel.zte@gmail.com wrote: > > > From: Yang Yang > > > > > > psi tracks the time spent submitting the IO of refaulting pages[1]. > > > But after we tracks refault stalls from swap_readpage[2][3], there > > > is no need to do so anymore. Since swap_readpage already includes > > > IO submitting time. > > > > > > [1] commit b8e24a9300b0 ("block: annotate refault stalls from IO submission") > > > [2] commit 937790699be9 ("mm/page_io.c: annotate refault stalls from swap_readpage") > > > [3] commit 2b413a1a728f ("mm: page_io: fix psi memory pressure error on cold swapins") > > > > > > Signed-off-by: Yang Yang > > > Reviewed-by: Ran Xiaokai > > > > It's still needed by file cache refaults! > > Can we get proper annotations for those please? These bio-level hooks are > horrible and a maintainance nightmware. The first version did that, but it was sprawling and not well-received: https://lkml.org/lkml/2019/7/22/1261