From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 355FFC433F5 for ; Fri, 25 Mar 2022 13:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359245AbiCYNI1 (ORCPT ); Fri, 25 Mar 2022 09:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345586AbiCYNIZ (ORCPT ); Fri, 25 Mar 2022 09:08:25 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF41C627B for ; Fri, 25 Mar 2022 06:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648213612; x=1679749612; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=L8We6eVZdTbGQo8vbwQx+Aqb89EgG0yv9xaBvTQeVeg=; b=d88QWL4LDooOsEcA2ypZcbfucxLoMbedLfsEnjE4ugml9m7GHx5SExd/ 6We7+86tW0db9T9X+aUaT+oiYGYquMnqqq+9Mec6onOvIOmiy7LW0FvHK WN6sAAv0rbDG3hpdwosB+5Nb+YRviRgfz5ql5USF1gst/iPWv/4yYpuNF IuJqoxc/kcb2SVQfhIrqWDcyw5k/RVtdgY9fcKr0TG3g5dEzjkMacpBGJ GVmNaZrR0ZivSkdtEXBVfQRkZYDlLytfchVRcNyh1/98qGKJpDKemFY8L xCEVEAsIDnWVODIAESOg7owgU8pKSIMDfvZLkp2cowtxo7CFbWcbVFUUl w==; X-IronPort-AV: E=McAfee;i="6200,9189,10296"; a="321823006" X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="321823006" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 06:06:51 -0700 X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="516539487" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 06:06:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nXjds-006PMQ-K0; Fri, 25 Mar 2022 15:06:12 +0200 Date: Fri, 25 Mar 2022 15:06:12 +0200 From: Andy Shevchenko To: Peter Zijlstra Cc: Linus Torvalds , Borislav Petkov , Ingo Molnar , Linux Kernel Mailing List , Will Deacon , Waiman Long , Boqun Feng , Thomas Gleixner , Andrew Morton , Sebastian Andrzej Siewior Subject: Re: [GIT PULL] locking changes for v5.18 Message-ID: References: <20220325122336.GQ8939@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325122336.GQ8939@worktop.programming.kicks-ass.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 01:23:36PM +0100, Peter Zijlstra wrote: > On Fri, Mar 25, 2022 at 01:41:25PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 22, 2022 at 03:58:47PM -0700, Linus Torvalds wrote: > > > On Tue, Mar 22, 2022 at 3:20 PM Borislav Petkov wrote: > > > > > > > > Ah, you say build error because you have CONFIG_WERROR=y. > > > > > > EVERYBODY should have CONFIG_WERROR=y on at least x86-64 and other > > > serious architectures, unless you have some completely random > > > experimental (and broken) compiler. > > > > > > New compiler warnings are not acceptable. > > > > What about old one? I have already complained in the early discussion that > > `make W=1 ...` is broken by this change. Enabling it without fixing > > _existing_ warnings on W=1 is not suitable for somebody. Now, I have to > > modify my configs to disable WERROR because of inability to built at all. > > > > (Yes, I understand that I may drop W=1, but that's not the point. since I > > want to have clean builds of a new code on level 1 of warnings) > > It would be fairly easy to make scripts/Makefile.extrawarn strip out > -Werror when W= is used. Hmm... I can't achieve this, because it complains about recursive variable. What helped me is to supply in such case -Wno-error which seems overrode the previous setting. I'll send a patch to discuss further if needed. -- With Best Regards, Andy Shevchenko