From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307A2C433F5 for ; Wed, 16 Mar 2022 08:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352402AbiCPIVE (ORCPT ); Wed, 16 Mar 2022 04:21:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245148AbiCPIVD (ORCPT ); Wed, 16 Mar 2022 04:21:03 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FAE63527 for ; Wed, 16 Mar 2022 01:19:49 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id t11so1802741wrm.5 for ; Wed, 16 Mar 2022 01:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eB3Qa08xe5yQrsvIPU/lEi8D81kJpMa1SMOqC0T8EyI=; b=KMgh5POQkPgJPtD8jFWJk5a5SH1QA1cwyg8ql04PZnvTkkU9yfAkqlCYaHSd54Y2XE rti8sLyNq1VbL0MuuSYl/vkm89LJ5DtvjC+kxhbnWEXPXcD7g4JH6Bmic2LL5B7Y7agt 6RCrLY2AdJj8OYIKfqFw2Up9M4j/SsahasYIdoouI8wONF5uoB9W/uWNpqRLiLz17BnX eo01QqcerJRs8lY2vWi2LlQ1h8aSDbXiiYvr1CMNRG4ruasA5hnjar+cU4qOc7n/4Rqe KQ+ArjwSBaAkZsZmWgmngAg6TfN7KamEue76wnY4vzfUXnX0QdZ5eK0B2cpcGlLSQixQ qoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eB3Qa08xe5yQrsvIPU/lEi8D81kJpMa1SMOqC0T8EyI=; b=CeJxKBpzwM8KC0O/4553N7fpNK+FdZyJ1CW+/0WqsuCncMJiqCOmUPRmavxQ52ZX16 6+2If87OBC4q1cbFGSbRul31pdeqFSeFHwsXqAXtZlVrsnh+MfEIxJUTunYhRaHC7p8h w/YfBVR67Pe3xEiE6s677Y0UrlcBMnGS95BcCjHNpMS0H12DBgdDZGN7ugqKMXQ6u3hR L8IAKca/W+vDnZgz7iWknUhns8F6QKrVVD7KfCMMneB0HhuLJFLty5Tsxaw4xG1YRKNh qRkzF6If3lsofncyLSIjhNyv2R/OnKfwJ6+rK00qDCz5sSUyF62+w9sGrQxqZdzkYaJy Ax9g== X-Gm-Message-State: AOAM530lBb0sRYxkgZcaf5R9SLEYcnMYXFm+viyFi7mqdXZI7Q7aeaCM x0Texwffk5qyk+pbH00Uxd6jhcko4u1Lvw== X-Google-Smtp-Source: ABdhPJwrWBZdB7018LH8H2J5v0WSvKptIeZpUnF7AAPZMrxFp93OwZ6yln++zheKXJ8gFgNLU75vKw== X-Received: by 2002:a05:6000:1868:b0:203:732e:6a96 with SMTP id d8-20020a056000186800b00203732e6a96mr23454156wri.39.1647418788344; Wed, 16 Mar 2022 01:19:48 -0700 (PDT) Received: from google.com (110.121.148.146.bc.googleusercontent.com. [146.148.121.110]) by smtp.gmail.com with ESMTPSA id i74-20020adf90d0000000b0020373ba7beesm1616426wri.0.2022.03.16.01.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 01:19:47 -0700 (PDT) Date: Wed, 16 Mar 2022 09:19:44 +0100 From: "Steinar H. Gunderson" To: Adrian Hunter Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf intel-pt: Synthesize cycle events Message-ID: References: <20220310093844.982656-1-sesse@google.com> <586de5fc-858b-2693-1986-5c77e8c0e3d0@intel.com> <52903e58-e74c-5ea0-36b4-277ea3610af4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52903e58-e74c-5ea0-36b4-277ea3610af4@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Tue, Mar 15, 2022 at 10:11:54PM +0200, Adrian Hunter wrote: > Sorry, my first suggestion has issues, but the second is better. I tried your second one, but can't see much difference. The original and your patched version still differ by a lot, and I still see various non-branch instructions getting very tiny fractions. (PSB packets _might_ be it, as there are ~1000 of them in the 165M-cycle trace.) I guess the good news is that the perf report coming out of your version looks more likely to me; I have some functions that are around 1% that shouldn't intuitively be that much (and, if I write some Perl to sum up the cycles from the IPC lines in perf script, are more around 0.1%). So perhaps we should stop chasing the difference? I don't know. /* Steinar */