All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Boris Burkov <boris@bur.io>
Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v7 5/5] generic: test fs-verity EFBIG scenarios
Date: Wed, 16 Mar 2022 17:30:57 +0000	[thread overview]
Message-ID: <YjIe0aPWeS/yonjM@gmail.com> (raw)
In-Reply-To: <b07e3b6cc2d44310a0d46f68d2031ef60f3af4cc.1647382272.git.boris@bur.io>

On Tue, Mar 15, 2022 at 03:16:01PM -0700, Boris Burkov wrote:
> btrfs, ext4, and f2fs cache the Merkle tree past EOF, which restricts
> the maximum file size beneath the normal maximum. Test the logic in
> those filesystems against files with sizes near the maximum.
> 
> To work properly, this does require some understanding of the practical
> but not standardized layout of the Merkle tree. This is a bit unpleasant
> and could make the test incorrect in the future, if the implementation
> changes. On the other hand, it feels quite useful to test this tricky
> edge case. It could perhaps be made more generic by adding some ioctls
> to let the file system communicate the maximum file size for a verity
> file or some information about the storage of the Merkle tree.
> 
> Signed-off-by: Boris Burkov <boris@bur.io>
> ---
>  common/verity         | 11 ++++++++
>  tests/generic/690     | 64 +++++++++++++++++++++++++++++++++++++++++++
>  tests/generic/690.out |  7 +++++
>  3 files changed, 82 insertions(+)
>  create mode 100755 tests/generic/690
>  create mode 100644 tests/generic/690.out

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric

      reply	other threads:[~2022-03-16 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 22:15 [PATCH v7 0/5] tests for btrfs fsverity Boris Burkov
2022-03-15 22:15 ` [PATCH v7 1/5] verity: require corruption functionality Boris Burkov
2022-03-16 17:21   ` Eric Biggers
2022-03-15 22:15 ` [PATCH v7 2/5] btrfs: test btrfs specific fsverity corruption Boris Burkov
2022-03-16 17:26   ` Eric Biggers
2022-03-16 17:36     ` Boris Burkov
2022-03-15 22:15 ` [PATCH v7 3/5] generic/574: corrupt btrfs merkle tree data Boris Burkov
2022-03-16 17:29   ` Eric Biggers
2022-03-15 22:16 ` [PATCH v7 4/5] btrfs: test verity orphans with dmlogwrites Boris Burkov
2022-03-15 22:16 ` [PATCH v7 5/5] generic: test fs-verity EFBIG scenarios Boris Burkov
2022-03-16 17:30   ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjIe0aPWeS/yonjM@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=boris@bur.io \
    --cc=fstests@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.