From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDF99C433EF for ; Thu, 17 Mar 2022 03:33:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 78692400F3; Thu, 17 Mar 2022 03:33:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdbIkUxxBgzL; Thu, 17 Mar 2022 03:33:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id E11CA400A3; Thu, 17 Mar 2022 03:32:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1546C0012; Thu, 17 Mar 2022 03:32:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7932FC000B for ; Thu, 17 Mar 2022 03:32:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6647D61277 for ; Thu, 17 Mar 2022 03:32:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U6JsSGU_gtgh for ; Thu, 17 Mar 2022 03:32:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by smtp3.osuosl.org (Postfix) with ESMTPS id 537AA60AAF for ; Thu, 17 Mar 2022 03:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647487976; x=1679023976; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=fvSysYrUKMfGk8/VVxHhcMOBMFAuiZiHLOX32nrDtbU=; b=JDONbQfAX6xowgnChvJTvhCtjP/9NGRvCi4ar4WWanlM82Q72ND/xc+j KM5ZWbdkHtfU/ZMx2ZKvYqxOUCGDs4IjnJtNL42BqJ0r9JHpa37pH5aSt SZ98/IrZbnz3PyN79LBCd6BIMllwk+9SVKu3a7G/0ijSmURBMpSciykp3 oojW5mwaFef76c1gVXbG8sIFUIuGOW9Q4gGWO2wv+8slarIb6lfZvY+vF g3vRftOAJDCQpoMcybtWHoZWVIJtX2KnwD869VOoXeb8VceaZalWGwonI DsROyj3/pwycHiZaavSjuJd5h0yZ4LVifcFb1d05CdAuK8t728vbuvidH A==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="319984318" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="319984318" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:55 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="613867506" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:54 -0700 Date: Wed, 16 Mar 2022 20:32:54 -0700 From: Ira Weiny To: Randy Dunlap Subject: Re: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220316192010.19001-1-rdunlap@infradead.org> Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Dave Hansen , Valentina Manea , Karol Herbst , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBNYXIgMTYsIDIwMjIgYXQgMTI6MjA6MDFQTSAtMDcwMCwgUmFuZHkgRHVubGFwIHdy b3RlOgo+IFRoZXJlIGFyZSBhIG51bWJlciBvZiBkcml2ZXJzIHRoYXQgdXNlICJtb2R1bGVfaW5p dChpbml0KSIgYW5kCj4gIm1vZHVsZV9leGl0KGV4aXQpIiwgd2hpY2ggYXJlIGFub255bW91cyBu YW1lcyBhbmQgY2FuIGxlYWQgdG8KPiBjb25mdXNpb24gb3IgYW1iaWd1aXR5IHdoZW4gcmVhZGlu ZyBTeXN0ZW0ubWFwLCBjcmFzaGVzL29vcHMvYnVncywKPiBvciBhbiBpbml0Y2FsbF9kZWJ1ZyBs b2cuCj4gCj4gR2l2ZSBlYWNoIG9mIHRoZXNlIGluaXQgYW5kIGV4aXQgZnVuY3Rpb25zIHVuaXF1 ZSBkcml2ZXItc3BlY2lmaWMKPiBuYW1lcyB0byBlbGltaW5hdGUgdGhlIGFub255bW91cyBuYW1l cy4KCkknbSBub3QgZnVsbHkgc3VyZSBhYm91dCB0aGUgRml4ZXMgdGFncyBidXQgSSBkb24ndCBz ZWUgdGhhdCBpdCBodXJ0cyBhbnl0aGluZy4KCkZvciB0aGUgc2VyaWVzOgoKUmV2aWV3ZWQtYnk6 IElyYSBXZWlueSA8aXJhLndlaW55QGludGVsLmNvbT4KCj4gCj4gRXhhbXBsZSAxOiAoU3lzdGVt Lm1hcCkKPiAgZmZmZmZmZmY4MzJmYzc4YyB0IGluaXQKPiAgZmZmZmZmZmY4MzJmYzc5ZSB0IGlu aXQKPiAgZmZmZmZmZmY4MzJmYzhmOCB0IGluaXQKPiAgZmZmZmZmZmY4MzJmY2EwNSB0IGluaXQK PiAgZmZmZmZmZmY4MzJmY2JkMiB0IGluaXQKPiAgZmZmZmZmZmY4MzMyOGYwZSB0IGluaXQKPiAg ZmZmZmZmZmY4MzMyYzViMSB0IGluaXQKPiAgZmZmZmZmZmY4MzMyZDllYiB0IGluaXQKPiAgZmZm ZmZmZmY4MzMyZjBhYSB0IGluaXQKPiAgZmZmZmZmZmY4MzMzMGUyNSB0IGluaXQKPiAgZmZmZmZm ZmY4MzMzMTdhNSB0IGluaXQKPiAgZmZmZmZmZmY4MzMzZGQ2YiB0IGluaXQKPiAKPiBFeGFtcGxl IDI6IChpbml0Y2FsbF9kZWJ1ZyBsb2cpCj4gIGNhbGxpbmcgIGluaXQrMHgwLzB4MTIgQCAxCj4g IGluaXRjYWxsIGluaXQrMHgwLzB4MTIgcmV0dXJuZWQgMCBhZnRlciAxNSB1c2Vjcwo+ICBjYWxs aW5nICBpbml0KzB4MC8weDYwIEAgMQo+ICBpbml0Y2FsbCBpbml0KzB4MC8weDYwIHJldHVybmVk IDAgYWZ0ZXIgMiB1c2Vjcwo+ICBjYWxsaW5nICBpbml0KzB4MC8weDlhIEAgMQo+ICBpbml0Y2Fs bCBpbml0KzB4MC8weDlhIHJldHVybmVkIDAgYWZ0ZXIgNzQgdXNlY3MKPiAgY2FsbGluZyAgaW5p dCsweDAvMHg3MyBAIDEKPiAgaW5pdGNhbGwgaW5pdCsweDAvMHg3MyByZXR1cm5lZCAwIGFmdGVy IDYgdXNlY3MKPiAgY2FsbGluZyAgaW5pdCsweDAvMHg3MyBAIDEKPiAgaW5pdGNhbGwgaW5pdCsw eDAvMHg3MyByZXR1cm5lZCAwIGFmdGVyIDQgdXNlY3MKPiAgY2FsbGluZyAgaW5pdCsweDAvMHhm NSBAIDEKPiAgaW5pdGNhbGwgaW5pdCsweDAvMHhmNSByZXR1cm5lZCAwIGFmdGVyIDI3IHVzZWNz Cj4gIGNhbGxpbmcgIGluaXQrMHgwLzB4N2QgQCAxCj4gIGluaXRjYWxsIGluaXQrMHgwLzB4N2Qg cmV0dXJuZWQgMCBhZnRlciAxMSB1c2Vjcwo+ICBjYWxsaW5nICBpbml0KzB4MC8weGM5IEAgMQo+ ICBpbml0Y2FsbCBpbml0KzB4MC8weGM5IHJldHVybmVkIDAgYWZ0ZXIgMTkgdXNlY3MKPiAgY2Fs bGluZyAgaW5pdCsweDAvMHg5ZCBAIDEKPiAgaW5pdGNhbGwgaW5pdCsweDAvMHg5ZCByZXR1cm5l ZCAwIGFmdGVyIDM3IHVzZWNzCj4gIGNhbGxpbmcgIGluaXQrMHgwLzB4NjNmIEAgMQo+ICBpbml0 Y2FsbCBpbml0KzB4MC8weDYzZiByZXR1cm5lZCAwIGFmdGVyIDQxMSB1c2Vjcwo+ICBjYWxsaW5n ICBpbml0KzB4MC8weDE3MSBAIDEKPiAgaW5pdGNhbGwgaW5pdCsweDAvMHgxNzEgcmV0dXJuZWQg MCBhZnRlciA2MSB1c2Vjcwo+ICBjYWxsaW5nICBpbml0KzB4MC8weGVmIEAgMQo+ICBpbml0Y2Fs bCBpbml0KzB4MC8weGVmIHJldHVybmVkIDAgYWZ0ZXIgMyB1c2Vjcwo+IAo+IENjOiAiTWljaGFl bCBTLiBUc2lya2luIiA8bXN0QHJlZGhhdC5jb20+Cj4gQ2M6IEphc29uIFdhbmcgPGphc293YW5n QHJlZGhhdC5jb20+Cj4gQ2M6IFBhb2xvIEJvbnppbmkgPHBib256aW5pQHJlZGhhdC5jb20+Cj4g Q2M6IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVkaGF0LmNvbT4KPiBDYzogSmVucyBBeGJv ZSA8YXhib2VAa2VybmVsLmRrPgo+IENjOiBBbWl0IFNoYWggPGFtaXRAa2VybmVsLm9yZz4KPiBD YzogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiBDYzogR3JlZyBLcm9haC1IYXJ0bWFu IDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiBDYzogRWxpIENvaGVuIDxlbGlAbWVsbGFu b3guY29tPgo+IENjOiBTYWVlZCBNYWhhbWVlZCA8c2FlZWRtQG52aWRpYS5jb20+Cj4gQ2M6IExl b24gUm9tYW5vdnNreSA8bGVvbkBrZXJuZWwub3JnPgo+IENjOiBQYWJsbyBOZWlyYSBBeXVzbyA8 cGFibG9AbmV0ZmlsdGVyLm9yZz4KPiBDYzogSm96c2VmIEthZGxlY3NpayA8a2FkbGVjQG5ldGZp bHRlci5vcmc+Cj4gQ2M6IEZsb3JpYW4gV2VzdHBoYWwgPGZ3QHN0cmxlbi5kZT4KPiBDYzogIkRh dmlkIFMuIE1pbGxlciIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cj4gQ2M6IEpha3ViIEtpY2luc2tp IDxrdWJhQGtlcm5lbC5vcmc+Cj4gQ2M6ICJKYW1lcyBFLkouIEJvdHRvbWxleSIgPGplamJAbGlu dXguaWJtLmNvbT4KPiBDYzogIk1hcnRpbiBLLiBQZXRlcnNlbiIgPG1hcnRpbi5wZXRlcnNlbkBv cmFjbGUuY29tPgo+IENjOiBGZWxpcGUgQmFsYmkgPGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5j b20+Cj4gQ2M6IE1pY2hhxYIgTWlyb3PFgmF3IDxtaXJxLWxpbnV4QHJlcmUucW1xbS5wbD4KPiBD YzogU2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4LmRlPgo+IENj OiBLcnp5c3p0b2YgT3Bhc2lhayA8ay5vcGFzaWFrQHNhbXN1bmcuY29tPgo+IENjOiBJZ29yIEtv dHJhc2luc2tpIDxpLmtvdHJhc2luc2tAc2Ftc3VuZy5jb20+Cj4gQ2M6IFZhbGVudGluYSBNYW5l YSA8dmFsZW50aW5hLm1hbmVhLm1AZ21haWwuY29tPgo+IENjOiBTaHVhaCBLaGFuIDxzaHVhaEBr ZXJuZWwub3JnPgo+IENjOiBTaHVhaCBLaGFuIDxza2hhbkBsaW51eGZvdW5kYXRpb24ub3JnPgo+ IENjOiBKdXNzaSBLaXZpbGlubmEgPGp1c3NpLmtpdmlsaW5uYUBtYm5ldC5maT4KPiBDYzogSm9h Y2hpbSBGcml0c2NoaSA8amZyaXRzY2hpQGZyZWVuZXQuZGU+Cj4gQ2M6IEhlcmJlcnQgWHUgPGhl cmJlcnRAZ29uZG9yLmFwYW5hLm9yZy5hdT4KPiBDYzogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxp bnV0cm9uaXguZGU+Cj4gQ2M6IFN0ZXZlbiBSb3N0ZWR0IDxyb3N0ZWR0QGdvb2RtaXMub3JnPgo+ IENjOiBJbmdvIE1vbG5hciA8bWluZ29Aa2VybmVsLm9yZz4KPiBDYzogS2Fyb2wgSGVyYnN0IDxr YXJvbGhlcmJzdEBnbWFpbC5jb20+Cj4gQ2M6IFBla2thIFBhYWxhbmVuIDxwcGFhbGFuZW5AZ21h aWwuY29tPgo+IENjOiBEYXZlIEhhbnNlbiA8ZGF2ZS5oYW5zZW5AbGludXguaW50ZWwuY29tPgo+ IENjOiBBbmR5IEx1dG9taXJza2kgPGx1dG9Aa2VybmVsLm9yZz4KPiBDYzogUGV0ZXIgWmlqbHN0 cmEgPHBldGVyekBpbmZyYWRlYWQub3JnPgo+IENjOiBCb3Jpc2xhdiBQZXRrb3YgPGJwQGFsaWVu OC5kZT4KPiBDYzogIkguIFBldGVyIEFudmluIiA8aHBhQHp5dG9yLmNvbT4KPiBDYzogbmV0Zmls dGVyLWRldmVsQHZnZXIua2VybmVsLm9yZwo+IENjOiBjb3JldGVhbUBuZXRmaWx0ZXIub3JnCj4g Q2M6IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtYmxvY2tAdmdlci5rZXJuZWwu b3JnCj4gQ2M6IGxpbnV4LWNyeXB0b0B2Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtcmRtYUB2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtc2NzaUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGlu dXgtdXNiQHZnZXIua2VybmVsLm9yZwo+IENjOiBub3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IENjOiB2aXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwo+IENjOiB4 ODZAa2VybmVsLm9yZwo+IAo+IHBhdGNoZXM6Cj4gIFtQQVRDSCAxLzldIHZpcnRpb19ibGs6IGVs aW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxlX2luaXQgJiBtb2R1bGVfZXhpdAo+ICBbUEFUQ0ggMi85 XSB2aXJ0aW9fY29uc29sZTogZWxpbWluYXRlIGFub255bW91cyBtb2R1bGVfaW5pdCAmIG1vZHVs ZV9leGl0Cj4gIFtQQVRDSCAzLzldIG5ldDogbWx4NTogZWxpbWluYXRlIGFub255bW91cyBtb2R1 bGVfaW5pdCAmIG1vZHVsZV9leGl0Cj4gIFtQQVRDSCA0LzldIG5ldGZpbHRlcjogaDMyMzogZWxp bWluYXRlIGFub255bW91cyBtb2R1bGVfaW5pdCAmIG1vZHVsZV9leGl0Cj4gIFtQQVRDSCA1Lzld IHZpcnRpby1zY3NpOiBlbGltaW5hdGUgYW5vbnltb3VzIG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4 aXQKPiAgW1BBVENIIDYvOV0gdXNiOiBnYWRnZXQ6IGVsaW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxl X2luaXQgJiBtb2R1bGVfZXhpdAo+ICBbUEFUQ0ggNy85XSB1c2I6IHVzYmlwOiBlbGltaW5hdGUg YW5vbnltb3VzIG1vZHVsZV9pbml0ICYgbW9kdWxlX2V4aXQKPiAgW1BBVENIIDgvOV0geDg2L2Ny eXB0bzogZWxpbWluYXRlIGFub255bW91cyBtb2R1bGVfaW5pdCAmIG1vZHVsZV9leGl0Cj4gIFtQ QVRDSCA5LzldIHRlc3RtbWlvdHJhY2U6IGVsaW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxlX2luaXQg JiBtb2R1bGVfZXhpdAo+IAo+IGRpZmZzdGF0Ogo+ICBhcmNoL3g4Ni9jcnlwdG8vYmxvd2Zpc2hf Z2x1ZS5jICAgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ICBhcmNoL3g4Ni9jcnlwdG8v Y2FtZWxsaWFfZ2x1ZS5jICAgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ICBhcmNoL3g4 Ni9jcnlwdG8vc2VycGVudF9hdngyX2dsdWUuYyAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ ICBhcmNoL3g4Ni9jcnlwdG8vdHdvZmlzaF9nbHVlLmMgICAgICAgICAgICAgICAgIHwgICAgOCAr KysrLS0tLQo+ICBhcmNoL3g4Ni9jcnlwdG8vdHdvZmlzaF9nbHVlXzN3YXkuYyAgICAgICAgICAg IHwgICAgOCArKysrLS0tLQo+ICBhcmNoL3g4Ni9tbS90ZXN0bW1pb3RyYWNlLmMgICAgICAgICAg ICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ICBkcml2ZXJzL2Jsb2NrL3ZpcnRpb19ibGsuYyAg ICAgICAgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ICBkcml2ZXJzL2NoYXIvdmlydGlv X2NvbnNvbGUuYyAgICAgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQo+ICBkcml2ZXJzL25l dC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvbWFpbi5jIHwgICAgOCArKysrLS0tLQo+ICBk cml2ZXJzL3Njc2kvdmlydGlvX3Njc2kuYyAgICAgICAgICAgICAgICAgICAgIHwgICAgOCArKysr LS0tLQo+ICBkcml2ZXJzL3VzYi9nYWRnZXQvbGVnYWN5L2lub2RlLmMgICAgICAgICAgICAgIHwg ICAgOCArKysrLS0tLQo+ICBkcml2ZXJzL3VzYi9nYWRnZXQvbGVnYWN5L3NlcmlhbC5jICAgICAg ICAgICAgIHwgICAxMCArKysrKy0tLS0tCj4gIGRyaXZlcnMvdXNiL2dhZGdldC91ZGMvZHVtbXlf aGNkLmMgICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCj4gIGRyaXZlcnMvdXNiL3VzYmlwL3Z1 ZGNfbWFpbi5jICAgICAgICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCj4gIG5ldC9pcHY0L25l dGZpbHRlci9uZl9uYXRfaDMyMy5jICAgICAgICAgICAgICAgfCAgICA4ICsrKystLS0tCj4gIDE1 IGZpbGVzIGNoYW5nZWQsIDYxIGluc2VydGlvbnMoKyksIDYxIGRlbGV0aW9ucygtKQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6 YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9EAC433EF for ; Thu, 17 Mar 2022 03:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiCQDf3 (ORCPT ); Wed, 16 Mar 2022 23:35:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiCQDf0 (ORCPT ); Wed, 16 Mar 2022 23:35:26 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3D815EBCF; Wed, 16 Mar 2022 20:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647488041; x=1679024041; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=fvSysYrUKMfGk8/VVxHhcMOBMFAuiZiHLOX32nrDtbU=; b=ijtUhERXG3Cy/OyvJ+RNLnnZ5+yQSuWExjPEYB6Uya4KUqOLlGBlfy4n VokXRrEApHQCN8C9fgZVoqSGqMVIDMlzdK1vJpDj4d60B5c8GD7YINXuQ /ap/w+IUoRT0L8EUC2eRakgNkOtMwpgefpIGaHH8IzbYT5p1++4a1q/+q uMZbG7GFB7Jh7y7Mgds5Cjj6g2JZ0DqL7RdfVsVhPCTfHWM8FAXdXtjZ9 qk+aw/9gi3GGCXlsWJeSu8EcHsvVsDLnbEeVqJj8gPQ8i+iVOdgT26ZUE wOmnRv5brtQ/iJ88qhIomSeXO8CfnfHLexCjAAOWxuHyBuTlS3KopbNyx w==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="238935622" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="238935622" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:55 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="613867506" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:54 -0700 Date: Wed, 16 Mar 2022 20:32:54 -0700 From: Ira Weiny To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220316192010.19001-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Mar 16, 2022 at 12:20:01PM -0700, Randy Dunlap wrote: > There are a number of drivers that use "module_init(init)" and > "module_exit(exit)", which are anonymous names and can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. I'm not fully sure about the Fixes tags but I don't see that it hurts anything. For the series: Reviewed-by: Ira Weiny > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > ffffffff832fca05 t init > ffffffff832fcbd2 t init > ffffffff83328f0e t init > ffffffff8332c5b1 t init > ffffffff8332d9eb t init > ffffffff8332f0aa t init > ffffffff83330e25 t init > ffffffff833317a5 t init > ffffffff8333dd6b t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > calling init+0x0/0x73 @ 1 > initcall init+0x0/0x73 returned 0 after 6 usecs > calling init+0x0/0x73 @ 1 > initcall init+0x0/0x73 returned 0 after 4 usecs > calling init+0x0/0xf5 @ 1 > initcall init+0x0/0xf5 returned 0 after 27 usecs > calling init+0x0/0x7d @ 1 > initcall init+0x0/0x7d returned 0 after 11 usecs > calling init+0x0/0xc9 @ 1 > initcall init+0x0/0xc9 returned 0 after 19 usecs > calling init+0x0/0x9d @ 1 > initcall init+0x0/0x9d returned 0 after 37 usecs > calling init+0x0/0x63f @ 1 > initcall init+0x0/0x63f returned 0 after 411 usecs > calling init+0x0/0x171 @ 1 > initcall init+0x0/0x171 returned 0 after 61 usecs > calling init+0x0/0xef @ 1 > initcall init+0x0/0xef returned 0 after 3 usecs > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Paolo Bonzini > Cc: Stefan Hajnoczi > Cc: Jens Axboe > Cc: Amit Shah > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Eli Cohen > Cc: Saeed Mahameed > Cc: Leon Romanovsky > Cc: Pablo Neira Ayuso > Cc: Jozsef Kadlecsik > Cc: Florian Westphal > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Felipe Balbi > Cc: Michał Mirosław > Cc: Sebastian Andrzej Siewior > Cc: Krzysztof Opasiak > Cc: Igor Kotrasinski > Cc: Valentina Manea > Cc: Shuah Khan > Cc: Shuah Khan > Cc: Jussi Kivilinna > Cc: Joachim Fritschi > Cc: Herbert Xu > Cc: Thomas Gleixner > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: netfilter-devel@vger.kernel.org > Cc: coreteam@netfilter.org > Cc: netdev@vger.kernel.org > Cc: linux-block@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: linux-scsi@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: nouveau@lists.freedesktop.org > Cc: virtualization@lists.linux-foundation.org > Cc: x86@kernel.org > > patches: > [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit > [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit > [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit > [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit > [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit > [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit > [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit > [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit > [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit > > diffstat: > arch/x86/crypto/blowfish_glue.c | 8 ++++---- > arch/x86/crypto/camellia_glue.c | 8 ++++---- > arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- > arch/x86/mm/testmmiotrace.c | 8 ++++---- > drivers/block/virtio_blk.c | 8 ++++---- > drivers/char/virtio_console.c | 8 ++++---- > drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- > drivers/scsi/virtio_scsi.c | 8 ++++---- > drivers/usb/gadget/legacy/inode.c | 8 ++++---- > drivers/usb/gadget/legacy/serial.c | 10 +++++----- > drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- > drivers/usb/usbip/vudc_main.c | 8 ++++---- > net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- > 15 files changed, 61 insertions(+), 61 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8213EC433F5 for ; Sun, 27 Mar 2022 07:44:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4250910E1F3; Sun, 27 Mar 2022 07:44:06 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id E9E7810EAE2 for ; Thu, 17 Mar 2022 03:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647487975; x=1679023975; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=fvSysYrUKMfGk8/VVxHhcMOBMFAuiZiHLOX32nrDtbU=; b=nRitGryC1s9Sl0gfi5NXBqXxuUaPQn9isOC7VKAMDOFgX0VGTMpOYZKu F7Og9/dd6CMvViuux3a8/nc+jkIfQAloLg34bMxatPon4bEpQEaBsYf9t Bh7VpWDNehttmHXJm+HWLDWig+xOxBLIshxAozzFqQ1yx4lcWXECTNt2F ElSlJkpsqYS9XRnxL4CB4Ju0kUyL6gEfoNE/BrQwZYF/Nurdjz6TnjiuA OHVjvI0JkUi9ipCLOlw9ufGTVfZib9FLkiYixR8U/eAuRxgNdjF8jt0YH 1zJ+/0HEqDZrKfeyN9SokgSeOeaT4jlJn3xDVYR1N/U8NAp1V4HYzcEQw Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="254329697" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="254329697" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:55 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="613867506" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:32:54 -0700 Date: Wed, 16 Mar 2022 20:32:54 -0700 From: Ira Weiny To: Randy Dunlap Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220316192010.19001-1-rdunlap@infradead.org> X-Mailman-Approved-At: Sun, 27 Mar 2022 07:44:03 +0000 Subject: Re: [Nouveau] [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Jason Wang , Dave Hansen , Valentina Manea , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Mar 16, 2022 at 12:20:01PM -0700, Randy Dunlap wrote: > There are a number of drivers that use "module_init(init)" and > "module_exit(exit)", which are anonymous names and can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. I'm not fully sure about the Fixes tags but I don't see that it hurts anything. For the series: Reviewed-by: Ira Weiny > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > ffffffff832fca05 t init > ffffffff832fcbd2 t init > ffffffff83328f0e t init > ffffffff8332c5b1 t init > ffffffff8332d9eb t init > ffffffff8332f0aa t init > ffffffff83330e25 t init > ffffffff833317a5 t init > ffffffff8333dd6b t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > calling init+0x0/0x73 @ 1 > initcall init+0x0/0x73 returned 0 after 6 usecs > calling init+0x0/0x73 @ 1 > initcall init+0x0/0x73 returned 0 after 4 usecs > calling init+0x0/0xf5 @ 1 > initcall init+0x0/0xf5 returned 0 after 27 usecs > calling init+0x0/0x7d @ 1 > initcall init+0x0/0x7d returned 0 after 11 usecs > calling init+0x0/0xc9 @ 1 > initcall init+0x0/0xc9 returned 0 after 19 usecs > calling init+0x0/0x9d @ 1 > initcall init+0x0/0x9d returned 0 after 37 usecs > calling init+0x0/0x63f @ 1 > initcall init+0x0/0x63f returned 0 after 411 usecs > calling init+0x0/0x171 @ 1 > initcall init+0x0/0x171 returned 0 after 61 usecs > calling init+0x0/0xef @ 1 > initcall init+0x0/0xef returned 0 after 3 usecs > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Paolo Bonzini > Cc: Stefan Hajnoczi > Cc: Jens Axboe > Cc: Amit Shah > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Eli Cohen > Cc: Saeed Mahameed > Cc: Leon Romanovsky > Cc: Pablo Neira Ayuso > Cc: Jozsef Kadlecsik > Cc: Florian Westphal > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: Felipe Balbi > Cc: Michał Mirosław > Cc: Sebastian Andrzej Siewior > Cc: Krzysztof Opasiak > Cc: Igor Kotrasinski > Cc: Valentina Manea > Cc: Shuah Khan > Cc: Shuah Khan > Cc: Jussi Kivilinna > Cc: Joachim Fritschi > Cc: Herbert Xu > Cc: Thomas Gleixner > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: netfilter-devel@vger.kernel.org > Cc: coreteam@netfilter.org > Cc: netdev@vger.kernel.org > Cc: linux-block@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: linux-scsi@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: nouveau@lists.freedesktop.org > Cc: virtualization@lists.linux-foundation.org > Cc: x86@kernel.org > > patches: > [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit > [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit > [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit > [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit > [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit > [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit > [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit > [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit > [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit > > diffstat: > arch/x86/crypto/blowfish_glue.c | 8 ++++---- > arch/x86/crypto/camellia_glue.c | 8 ++++---- > arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- > arch/x86/mm/testmmiotrace.c | 8 ++++---- > drivers/block/virtio_blk.c | 8 ++++---- > drivers/char/virtio_console.c | 8 ++++---- > drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++---- > drivers/scsi/virtio_scsi.c | 8 ++++---- > drivers/usb/gadget/legacy/inode.c | 8 ++++---- > drivers/usb/gadget/legacy/serial.c | 10 +++++----- > drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- > drivers/usb/usbip/vudc_main.c | 8 ++++---- > net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- > 15 files changed, 61 insertions(+), 61 deletions(-)