From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54BCAC433F5 for ; Thu, 17 Mar 2022 03:30:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E180E84131; Thu, 17 Mar 2022 03:30:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vq1EBkwE_izN; Thu, 17 Mar 2022 03:30:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 429D38411D; Thu, 17 Mar 2022 03:30:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 17029C0012; Thu, 17 Mar 2022 03:30:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id A76DEC000B for ; Thu, 17 Mar 2022 03:30:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8506040AF9 for ; Thu, 17 Mar 2022 03:30:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SJQuTttszX6b for ; Thu, 17 Mar 2022 03:29:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp2.osuosl.org (Postfix) with ESMTPS id 645B040AEE for ; Thu, 17 Mar 2022 03:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647487798; x=1679023798; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=AzMb0/YG2S8LI24My11FysIdAjjvdmOrV481bVhZgTI=; b=CkMGkFC0ykulvijb1PNe36arxa06H5nrM19HGU3vCFw6XWczWus9rvjH t8gfFajYUua194pG2i3T/GyMZjtRHZohJegOjAO9OQmJTeow8o7IOgzXj kcOB6FmcgNWKWidZeNQAR/qcjFynQCM1lWTposfsVZaMVKzJwhzOIrtIX 5af3kZuwI9Hle5GhuKM9PYTMrBaoCYbL9xE67BRU51LwGTKgLF+fk43py Q2at8z4UKu4A6gTp+xf1IBkhRXiAxypw3e9TrptMl5WyrvP+nGQKZn9xN ggN+xv2UufIygm8FDStFzLA7PvoBpY0PclGp6hCDnf/j0KQM96unBTzHP g==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="256499745" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="256499745" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:57 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="635225301" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:56 -0700 Date: Wed, 16 Mar 2022 20:29:55 -0700 From: Ira Weiny To: Randy Dunlap Subject: Re: [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-7-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220316192010.19001-7-rdunlap@infradead.org> Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Dave Hansen , Valentina Manea , Karol Herbst , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBNYXIgMTYsIDIwMjIgYXQgMTI6MjA6MDdQTSAtMDcwMCwgUmFuZHkgRHVubGFwIHdy b3RlOgo+IEVsaW1pbmF0ZSBhbm9ueW1vdXMgbW9kdWxlX2luaXQoKSBhbmQgbW9kdWxlX2V4aXQo KSwgd2hpY2ggY2FuIGxlYWQgdG8KPiBjb25mdXNpb24gb3IgYW1iaWd1aXR5IHdoZW4gcmVhZGlu ZyBTeXN0ZW0ubWFwLCBjcmFzaGVzL29vcHMvYnVncywKPiBvciBhbiBpbml0Y2FsbF9kZWJ1ZyBs b2cuCj4gCj4gR2l2ZSBlYWNoIG9mIHRoZXNlIGluaXQgYW5kIGV4aXQgZnVuY3Rpb25zIHVuaXF1 ZSBkcml2ZXItc3BlY2lmaWMKPiBuYW1lcyB0byBlbGltaW5hdGUgdGhlIGFub255bW91cyBuYW1l cy4KPiAKPiBFeGFtcGxlIDE6IChTeXN0ZW0ubWFwKQo+ICBmZmZmZmZmZjgzMmZjNzhjIHQgaW5p dAo+ICBmZmZmZmZmZjgzMmZjNzllIHQgaW5pdAo+ICBmZmZmZmZmZjgzMmZjOGY4IHQgaW5pdAo+ IAo+IEV4YW1wbGUgMjogKGluaXRjYWxsX2RlYnVnIGxvZykKPiAgY2FsbGluZyAgaW5pdCsweDAv MHgxMiBAIDEKPiAgaW5pdGNhbGwgaW5pdCsweDAvMHgxMiByZXR1cm5lZCAwIGFmdGVyIDE1IHVz ZWNzCj4gIGNhbGxpbmcgIGluaXQrMHgwLzB4NjAgQCAxCj4gIGluaXRjYWxsIGluaXQrMHgwLzB4 NjAgcmV0dXJuZWQgMCBhZnRlciAyIHVzZWNzCj4gIGNhbGxpbmcgIGluaXQrMHgwLzB4OWEgQCAx Cj4gIGluaXRjYWxsIGluaXQrMHgwLzB4OWEgcmV0dXJuZWQgMCBhZnRlciA3NCB1c2Vjcwo+IAo+ IEZpeGVzOiBiZDI1YTE0ZWRiNzUgKCJ1c2I6IGdhZGdldDogbGVnYWN5L3NlcmlhbDogYWxsb3cg ZHluYW1pYyByZW1vdmFsIikKPiBGaXhlczogN2JiNWVhNTRiZTQ3ICgidXNiIGdhZGdldCBzZXJp YWw6IHVzZSBjb21wb3NpdGUgZ2FkZ2V0IGZyYW1ld29yayIpCj4gRml4ZXM6IDFkYTE3N2U0YzNm NCAoIkxpbnV4LTIuNi4xMi1yYzIiKQoKSSBjb250aW51ZSB0byBiZSBjb25mdXNlZCBhYm91dCB0 aGUgbGF0ZXN0IHJ1bGVzIGZvciB0aGUgRml4ZXMgdGFnIGJ1dCB0aGlzIG9uZQppbiBwYXJ0aWN1 bGFyIHNlZW1zIGNvbXBsZXRlbHkgdXNlbGVzcy4gIFRoaXMgaXMgdGhlICdiZWdpbm5pbmcgb2Yg dGltZScgY29tbWl0CmJ5IExpbnVzIEFGQUlDVC4gIFNvIGRvIGFueSBvZiB0aGVzZSBGaXhlcyB0 YWdzIG5lZWQgdG8gYmUgaW4gdGhpcyBzZXJpZXM/CgpSZWdhcmRsZXNzOgoKUmV2aWV3ZWQtYnk6 IElyYSBXZWlueSA8aXJhLndlaW55QGludGVsLmNvbT4KCj4gU2lnbmVkLW9mZi1ieTogUmFuZHkg RHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+Cj4gQ2M6IEZlbGlwZSBCYWxiaSA8ZmVsaXBl LmJhbGJpQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWljaGHFgiBNaXJvc8WCYXcgPG1pcnEtbGlu dXhAcmVyZS5xbXFtLnBsPgo+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZv dW5kYXRpb24ub3JnPgo+IENjOiBTZWJhc3RpYW4gQW5kcnplaiBTaWV3aW9yIDxiaWdlYXN5QGxp bnV0cm9uaXguZGU+Cj4gQ2M6IGxpbnV4LXVzYkB2Z2VyLmtlcm5lbC5vcmcKPiAtLS0KPiAgZHJp dmVycy91c2IvZ2FkZ2V0L2xlZ2FjeS9pbm9kZS5jICB8ICAgIDggKysrKy0tLS0KPiAgZHJpdmVy cy91c2IvZ2FkZ2V0L2xlZ2FjeS9zZXJpYWwuYyB8ICAgMTAgKysrKystLS0tLQo+ICBkcml2ZXJz L3VzYi9nYWRnZXQvdWRjL2R1bW15X2hjZC5jIHwgICAgOCArKysrLS0tLQo+ICAzIGZpbGVzIGNo YW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IC0tLSBsbngtNTE3 LXJjOC5vcmlnL2RyaXZlcnMvdXNiL2dhZGdldC9sZWdhY3kvc2VyaWFsLmMKPiArKysgbG54LTUx Ny1yYzgvZHJpdmVycy91c2IvZ2FkZ2V0L2xlZ2FjeS9zZXJpYWwuYwo+IEBAIC0yNzMsNyArMjcz LDcgQEAgc3RhdGljIHN0cnVjdCB1c2JfY29tcG9zaXRlX2RyaXZlciBnc2VyaQo+ICBzdGF0aWMg aW50IHN3aXRjaF9nc2VyaWFsX2VuYWJsZShib29sIGRvX2VuYWJsZSkKPiAgewo+ICAJaWYgKCFz ZXJpYWxfY29uZmlnX2RyaXZlci5sYWJlbCkKPiAtCQkvKiBpbml0KCkgd2FzIG5vdCBjYWxsZWQs IHlldCAqLwo+ICsJCS8qIGdzZXJpYWxfaW5pdCgpIHdhcyBub3QgY2FsbGVkLCB5ZXQgKi8KPiAg CQlyZXR1cm4gMDsKPiAgCj4gIAlpZiAoZG9fZW5hYmxlKQo+IEBAIC0yODMsNyArMjgzLDcgQEAg c3RhdGljIGludCBzd2l0Y2hfZ3NlcmlhbF9lbmFibGUoYm9vbCBkbwo+ICAJcmV0dXJuIDA7Cj4g IH0KPiAgCj4gLXN0YXRpYyBpbnQgX19pbml0IGluaXQodm9pZCkKPiArc3RhdGljIGludCBfX2lu aXQgZ3NlcmlhbF9pbml0KHZvaWQpCj4gIHsKPiAgCS8qIFdlICpjb3VsZCogZXhwb3J0IHR3byBj b25maWdzOyB0aGF0J2QgYmUgbXVjaCBjbGVhbmVyLi4uCj4gIAkgKiBidXQgbmVpdGhlciBvZiB0 aGVzZSBwcm9kdWN0IElEcyB3YXMgZGVmaW5lZCB0aGF0IHdheS4KPiBAQCAtMzE0LDExICszMTQs MTEgQEAgc3RhdGljIGludCBfX2luaXQgaW5pdCh2b2lkKQo+ICAKPiAgCXJldHVybiB1c2JfY29t cG9zaXRlX3Byb2JlKCZnc2VyaWFsX2RyaXZlcik7Cj4gIH0KPiAtbW9kdWxlX2luaXQoaW5pdCk7 Cj4gK21vZHVsZV9pbml0KGdzZXJpYWxfaW5pdCk7Cj4gIAo+IC1zdGF0aWMgdm9pZCBfX2V4aXQg Y2xlYW51cCh2b2lkKQo+ICtzdGF0aWMgdm9pZCBfX2V4aXQgZ3NlcmlhbF9jbGVhbnVwKHZvaWQp Cj4gIHsKPiAgCWlmIChlbmFibGUpCj4gIAkJdXNiX2NvbXBvc2l0ZV91bnJlZ2lzdGVyKCZnc2Vy aWFsX2RyaXZlcik7Cj4gIH0KPiAtbW9kdWxlX2V4aXQoY2xlYW51cCk7Cj4gK21vZHVsZV9leGl0 KGdzZXJpYWxfY2xlYW51cCk7Cj4gLS0tIGxueC01MTctcmM4Lm9yaWcvZHJpdmVycy91c2IvZ2Fk Z2V0L3VkYy9kdW1teV9oY2QuYwo+ICsrKyBsbngtNTE3LXJjOC9kcml2ZXJzL3VzYi9nYWRnZXQv dWRjL2R1bW15X2hjZC5jCj4gQEAgLTI3NjUsNyArMjc2NSw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGxh dGZvcm1fZHJpdmVyIGR1bW15X2hjZF8KPiAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2Ug KnRoZV91ZGNfcGRldltNQVhfTlVNX1VEQ107Cj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICp0aGVfaGNkX3BkZXZbTUFYX05VTV9VRENdOwo+ICAKPiAtc3RhdGljIGludCBfX2luaXQg aW5pdCh2b2lkKQo+ICtzdGF0aWMgaW50IF9faW5pdCBkdW1teV9oY2RfaW5pdCh2b2lkKQo+ICB7 Cj4gIAlpbnQJcmV0dmFsID0gLUVOT01FTTsKPiAgCWludAlpOwo+IEBAIC0yODg3LDkgKzI4ODcs OSBAQCBlcnJfYWxsb2NfdWRjOgo+ICAJCXBsYXRmb3JtX2RldmljZV9wdXQodGhlX2hjZF9wZGV2 W2ldKTsKPiAgCXJldHVybiByZXR2YWw7Cj4gIH0KPiAtbW9kdWxlX2luaXQoaW5pdCk7Cj4gK21v ZHVsZV9pbml0KGR1bW15X2hjZF9pbml0KTsKPiAgCj4gLXN0YXRpYyB2b2lkIF9fZXhpdCBjbGVh bnVwKHZvaWQpCj4gK3N0YXRpYyB2b2lkIF9fZXhpdCBkdW1teV9oY2RfY2xlYW51cCh2b2lkKQo+ ICB7Cj4gIAlpbnQgaTsKPiAgCj4gQEAgLTI5MDUsNCArMjkwNSw0IEBAIHN0YXRpYyB2b2lkIF9f ZXhpdCBjbGVhbnVwKHZvaWQpCj4gIAlwbGF0Zm9ybV9kcml2ZXJfdW5yZWdpc3RlcigmZHVtbXlf dWRjX2RyaXZlcik7Cj4gIAlwbGF0Zm9ybV9kcml2ZXJfdW5yZWdpc3RlcigmZHVtbXlfaGNkX2Ry aXZlcik7Cj4gIH0KPiAtbW9kdWxlX2V4aXQoY2xlYW51cCk7Cj4gK21vZHVsZV9leGl0KGR1bW15 X2hjZF9jbGVhbnVwKTsKPiAtLS0gbG54LTUxNy1yYzgub3JpZy9kcml2ZXJzL3VzYi9nYWRnZXQv bGVnYWN5L2lub2RlLmMKPiArKysgbG54LTUxNy1yYzgvZHJpdmVycy91c2IvZ2FkZ2V0L2xlZ2Fj eS9pbm9kZS5jCj4gQEAgLTIxMDEsNyArMjEwMSw3IEBAIE1PRFVMRV9BTElBU19GUygiZ2FkZ2V0 ZnMiKTsKPiAgCj4gIC8qLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSovCj4gIAo+IC1zdGF0aWMgaW50IF9faW5pdCBp bml0ICh2b2lkKQo+ICtzdGF0aWMgaW50IF9faW5pdCBnYWRnZXRmc19pbml0ICh2b2lkKQo+ICB7 Cj4gIAlpbnQgc3RhdHVzOwo+ICAKPiBAQCAtMjExMSwxMiArMjExMSwxMiBAQCBzdGF0aWMgaW50 IF9faW5pdCBpbml0ICh2b2lkKQo+ICAJCQlzaG9ydG5hbWUsIGRyaXZlcl9kZXNjKTsKPiAgCXJl dHVybiBzdGF0dXM7Cj4gIH0KPiAtbW9kdWxlX2luaXQgKGluaXQpOwo+ICttb2R1bGVfaW5pdCAo Z2FkZ2V0ZnNfaW5pdCk7Cj4gIAo+IC1zdGF0aWMgdm9pZCBfX2V4aXQgY2xlYW51cCAodm9pZCkK PiArc3RhdGljIHZvaWQgX19leGl0IGdhZGdldGZzX2NsZWFudXAgKHZvaWQpCj4gIHsKPiAgCXBy X2RlYnVnICgidW5yZWdpc3RlciAlc1xuIiwgc2hvcnRuYW1lKTsKPiAgCXVucmVnaXN0ZXJfZmls ZXN5c3RlbSAoJmdhZGdldGZzX3R5cGUpOwo+ICB9Cj4gLW1vZHVsZV9leGl0IChjbGVhbnVwKTsK PiArbW9kdWxlX2V4aXQgKGdhZGdldGZzX2NsZWFudXApOwo+ICAKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0 ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMu bGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11865C433FE for ; Thu, 17 Mar 2022 03:31:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbiCQDc2 (ORCPT ); Wed, 16 Mar 2022 23:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiCQDc1 (ORCPT ); Wed, 16 Mar 2022 23:32:27 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C54B4FC4F; Wed, 16 Mar 2022 20:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647487864; x=1679023864; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=AzMb0/YG2S8LI24My11FysIdAjjvdmOrV481bVhZgTI=; b=fKOSUyUxaAQ5m4sTuHh8d9CbOREpJQiW6/ndFr7b3gfkQt+ZzBhe7Ok5 Zn0ThQp9eVaUv0yCqGwhwdJKQh6T0JfRSdh39i77qVFq+Yj3Id1GiQ11v tiJu6gybiJA2bEE33NZX6svE7RjUL4/NIrtAv/lKOXB0ofx3b6wJra1GQ IP4ZGZS9nYtNhy5AUO26fF4D24hkSqrsj1ymNq4iPqJMmjDz1J94gVEPb UUpQ4V/TEJJCHWethQ9Lws6lELBKrWWJi9LhXWYYhp7WNHERg8+a0GrEn YNJrYDY2kAEDIwm9ZORqX9zkZpSjymReyjT0l3ZJH57t6ORPX/b5ZVDWT Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="256961295" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="256961295" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:57 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="635225301" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:56 -0700 Date: Wed, 16 Mar 2022 20:29:55 -0700 From: Ira Weiny To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Eli Cohen , Saeed Mahameed , Leon Romanovsky , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Sebastian Andrzej Siewior , Krzysztof Opasiak , Igor Kotrasinski , Valentina Manea , Shuah Khan , Shuah Khan , Jussi Kivilinna , Joachim Fritschi , Herbert Xu , Thomas Gleixner , Steven Rostedt , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-7-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220316192010.19001-7-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Mar 16, 2022 at 12:20:07PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: bd25a14edb75 ("usb: gadget: legacy/serial: allow dynamic removal") > Fixes: 7bb5ea54be47 ("usb gadget serial: use composite gadget framework") > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") I continue to be confused about the latest rules for the Fixes tag but this one in particular seems completely useless. This is the 'beginning of time' commit by Linus AFAICT. So do any of these Fixes tags need to be in this series? Regardless: Reviewed-by: Ira Weiny > Signed-off-by: Randy Dunlap > Cc: Felipe Balbi > Cc: Michał Mirosław > Cc: Greg Kroah-Hartman > Cc: Sebastian Andrzej Siewior > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/gadget/legacy/inode.c | 8 ++++---- > drivers/usb/gadget/legacy/serial.c | 10 +++++----- > drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- > 3 files changed, 13 insertions(+), 13 deletions(-) > > --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/serial.c > +++ lnx-517-rc8/drivers/usb/gadget/legacy/serial.c > @@ -273,7 +273,7 @@ static struct usb_composite_driver gseri > static int switch_gserial_enable(bool do_enable) > { > if (!serial_config_driver.label) > - /* init() was not called, yet */ > + /* gserial_init() was not called, yet */ > return 0; > > if (do_enable) > @@ -283,7 +283,7 @@ static int switch_gserial_enable(bool do > return 0; > } > > -static int __init init(void) > +static int __init gserial_init(void) > { > /* We *could* export two configs; that'd be much cleaner... > * but neither of these product IDs was defined that way. > @@ -314,11 +314,11 @@ static int __init init(void) > > return usb_composite_probe(&gserial_driver); > } > -module_init(init); > +module_init(gserial_init); > > -static void __exit cleanup(void) > +static void __exit gserial_cleanup(void) > { > if (enable) > usb_composite_unregister(&gserial_driver); > } > -module_exit(cleanup); > +module_exit(gserial_cleanup); > --- lnx-517-rc8.orig/drivers/usb/gadget/udc/dummy_hcd.c > +++ lnx-517-rc8/drivers/usb/gadget/udc/dummy_hcd.c > @@ -2765,7 +2765,7 @@ static struct platform_driver dummy_hcd_ > static struct platform_device *the_udc_pdev[MAX_NUM_UDC]; > static struct platform_device *the_hcd_pdev[MAX_NUM_UDC]; > > -static int __init init(void) > +static int __init dummy_hcd_init(void) > { > int retval = -ENOMEM; > int i; > @@ -2887,9 +2887,9 @@ err_alloc_udc: > platform_device_put(the_hcd_pdev[i]); > return retval; > } > -module_init(init); > +module_init(dummy_hcd_init); > > -static void __exit cleanup(void) > +static void __exit dummy_hcd_cleanup(void) > { > int i; > > @@ -2905,4 +2905,4 @@ static void __exit cleanup(void) > platform_driver_unregister(&dummy_udc_driver); > platform_driver_unregister(&dummy_hcd_driver); > } > -module_exit(cleanup); > +module_exit(dummy_hcd_cleanup); > --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/inode.c > +++ lnx-517-rc8/drivers/usb/gadget/legacy/inode.c > @@ -2101,7 +2101,7 @@ MODULE_ALIAS_FS("gadgetfs"); > > /*----------------------------------------------------------------------*/ > > -static int __init init (void) > +static int __init gadgetfs_init (void) > { > int status; > > @@ -2111,12 +2111,12 @@ static int __init init (void) > shortname, driver_desc); > return status; > } > -module_init (init); > +module_init (gadgetfs_init); > > -static void __exit cleanup (void) > +static void __exit gadgetfs_cleanup (void) > { > pr_debug ("unregister %s\n", shortname); > unregister_filesystem (&gadgetfs_type); > } > -module_exit (cleanup); > +module_exit (gadgetfs_cleanup); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB14FC433FE for ; Sun, 27 Mar 2022 07:44:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5112B892D8; Sun, 27 Mar 2022 07:44:22 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id F16B610EAE0 for ; Thu, 17 Mar 2022 03:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647487798; x=1679023798; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=AzMb0/YG2S8LI24My11FysIdAjjvdmOrV481bVhZgTI=; b=CkMGkFC0ykulvijb1PNe36arxa06H5nrM19HGU3vCFw6XWczWus9rvjH t8gfFajYUua194pG2i3T/GyMZjtRHZohJegOjAO9OQmJTeow8o7IOgzXj kcOB6FmcgNWKWidZeNQAR/qcjFynQCM1lWTposfsVZaMVKzJwhzOIrtIX 5af3kZuwI9Hle5GhuKM9PYTMrBaoCYbL9xE67BRU51LwGTKgLF+fk43py Q2at8z4UKu4A6gTp+xf1IBkhRXiAxypw3e9TrptMl5WyrvP+nGQKZn9xN ggN+xv2UufIygm8FDStFzLA7PvoBpY0PclGp6hCDnf/j0KQM96unBTzHP g==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="317491517" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="317491517" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:57 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="635225301" Received: from mbhanuva-mobl.amr.corp.intel.com (HELO localhost) ([10.212.30.158]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 20:29:56 -0700 Date: Wed, 16 Mar 2022 20:29:55 -0700 From: Ira Weiny To: Randy Dunlap Message-ID: References: <20220316192010.19001-1-rdunlap@infradead.org> <20220316192010.19001-7-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220316192010.19001-7-rdunlap@infradead.org> X-Mailman-Approved-At: Sun, 27 Mar 2022 07:44:03 +0000 Subject: Re: [Nouveau] [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Andy Lutomirski , "Michael S. Tsirkin" , Peter Zijlstra , nouveau@lists.freedesktop.org, Jason Wang , Dave Hansen , Valentina Manea , Krzysztof Opasiak , Eli Cohen , netdev@vger.kernel.org, Shuah Khan , Thomas Gleixner , "H. Peter Anvin" , Arnd Bergmann , Leon Romanovsky , linux-rdma@vger.kernel.org, Ingo Molnar , Jozsef Kadlecsik , coreteam@netfilter.org, Jakub Kicinski , Sebastian Andrzej Siewior , Pablo Neira Ayuso , Joachim Fritschi , Felipe Balbi , Amit Shah , "James E.J. Bottomley" , Steven Rostedt , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , linux-block@vger.kernel.org, Pekka Paalanen , Borislav Petkov , Stefan Hajnoczi , Shuah Khan , Jussi Kivilinna , virtualization@lists.linux-foundation.org, Herbert Xu , Jens Axboe , linux-scsi@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, Igor Kotrasinski , Paolo Bonzini , Saeed Mahameed , "David S. Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Mar 16, 2022 at 12:20:07PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: bd25a14edb75 ("usb: gadget: legacy/serial: allow dynamic removal") > Fixes: 7bb5ea54be47 ("usb gadget serial: use composite gadget framework") > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") I continue to be confused about the latest rules for the Fixes tag but this one in particular seems completely useless. This is the 'beginning of time' commit by Linus AFAICT. So do any of these Fixes tags need to be in this series? Regardless: Reviewed-by: Ira Weiny > Signed-off-by: Randy Dunlap > Cc: Felipe Balbi > Cc: Michał Mirosław > Cc: Greg Kroah-Hartman > Cc: Sebastian Andrzej Siewior > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/gadget/legacy/inode.c | 8 ++++---- > drivers/usb/gadget/legacy/serial.c | 10 +++++----- > drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++---- > 3 files changed, 13 insertions(+), 13 deletions(-) > > --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/serial.c > +++ lnx-517-rc8/drivers/usb/gadget/legacy/serial.c > @@ -273,7 +273,7 @@ static struct usb_composite_driver gseri > static int switch_gserial_enable(bool do_enable) > { > if (!serial_config_driver.label) > - /* init() was not called, yet */ > + /* gserial_init() was not called, yet */ > return 0; > > if (do_enable) > @@ -283,7 +283,7 @@ static int switch_gserial_enable(bool do > return 0; > } > > -static int __init init(void) > +static int __init gserial_init(void) > { > /* We *could* export two configs; that'd be much cleaner... > * but neither of these product IDs was defined that way. > @@ -314,11 +314,11 @@ static int __init init(void) > > return usb_composite_probe(&gserial_driver); > } > -module_init(init); > +module_init(gserial_init); > > -static void __exit cleanup(void) > +static void __exit gserial_cleanup(void) > { > if (enable) > usb_composite_unregister(&gserial_driver); > } > -module_exit(cleanup); > +module_exit(gserial_cleanup); > --- lnx-517-rc8.orig/drivers/usb/gadget/udc/dummy_hcd.c > +++ lnx-517-rc8/drivers/usb/gadget/udc/dummy_hcd.c > @@ -2765,7 +2765,7 @@ static struct platform_driver dummy_hcd_ > static struct platform_device *the_udc_pdev[MAX_NUM_UDC]; > static struct platform_device *the_hcd_pdev[MAX_NUM_UDC]; > > -static int __init init(void) > +static int __init dummy_hcd_init(void) > { > int retval = -ENOMEM; > int i; > @@ -2887,9 +2887,9 @@ err_alloc_udc: > platform_device_put(the_hcd_pdev[i]); > return retval; > } > -module_init(init); > +module_init(dummy_hcd_init); > > -static void __exit cleanup(void) > +static void __exit dummy_hcd_cleanup(void) > { > int i; > > @@ -2905,4 +2905,4 @@ static void __exit cleanup(void) > platform_driver_unregister(&dummy_udc_driver); > platform_driver_unregister(&dummy_hcd_driver); > } > -module_exit(cleanup); > +module_exit(dummy_hcd_cleanup); > --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/inode.c > +++ lnx-517-rc8/drivers/usb/gadget/legacy/inode.c > @@ -2101,7 +2101,7 @@ MODULE_ALIAS_FS("gadgetfs"); > > /*----------------------------------------------------------------------*/ > > -static int __init init (void) > +static int __init gadgetfs_init (void) > { > int status; > > @@ -2111,12 +2111,12 @@ static int __init init (void) > shortname, driver_desc); > return status; > } > -module_init (init); > +module_init (gadgetfs_init); > > -static void __exit cleanup (void) > +static void __exit gadgetfs_cleanup (void) > { > pr_debug ("unregister %s\n", shortname); > unregister_filesystem (&gadgetfs_type); > } > -module_exit (cleanup); > +module_exit (gadgetfs_cleanup); >