From: Mark Brown <broonie@kernel.org>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Ashish Singhal <ashishsingha@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] spi: tegra210-quad: Add wait polling support
Date: Thu, 17 Mar 2022 18:09:33 +0000 [thread overview]
Message-ID: <YjN5XRuHU1ReFGOW@sirena.org.uk> (raw)
In-Reply-To: <DM4PR12MB57695F4DF462E705EC58D826C3129@DM4PR12MB5769.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Thu, Mar 17, 2022 at 06:00:25PM +0000, Krishna Yarlagadda wrote:
> > >> Wait polling still has to be selected on slave devices that can
> > >> support it.
> > >> I will add one line description for the properties in next version.
> > > I can't say I am familiar with this, but it seems that the ideal
> > > solution would be able to detect if this needs to be enabled depending
> > > on the device connected. Is that not possible?
> We cannot detect at runtime which slave supports wait polling.
How would the client device have any knowledge of how the controller
internal implementation works? What even is a "wait state inserted by
TPM device"? If this is something the client device is doing then it
should be something that is expressed through the generic SPI API by the
client device, if some controllers have some way of optimising this then
we can add support for that but presumably it's just something that's
generically supported by that device so we shouldn't need a DT property
for it on the device side either.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-17 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 1:20 [PATCH 0/3] spi: tegra quad: Add Tegra Grace features Krishna Yarlagadda
2022-03-17 1:20 ` [PATCH 1/3] spi: tegra210-quad: Multi-cs support Krishna Yarlagadda
2022-03-17 15:00 ` kernel test robot
2022-03-17 1:20 ` [PATCH 2/3] spi: tegra210-quad: Add wait polling support Krishna Yarlagadda
2022-03-17 8:54 ` Jon Hunter
2022-03-17 9:02 ` Krishna Yarlagadda
2022-03-17 9:44 ` Jon Hunter
2022-03-17 15:26 ` Jon Hunter
2022-03-17 18:00 ` Krishna Yarlagadda
2022-03-17 18:09 ` Mark Brown [this message]
2022-03-17 9:31 ` Jon Hunter
2022-03-17 1:20 ` [PATCH 3/3] spi: dt-bindings: Add wait state polling flag Krishna Yarlagadda
2022-03-17 8:42 ` Mikko Perttunen
2022-03-17 9:03 ` Krishna Yarlagadda
2022-03-23 20:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjN5XRuHU1ReFGOW@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ashishsingha@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.