From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E09FC43217 for ; Sat, 19 Mar 2022 22:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244307AbiCSWug (ORCPT ); Sat, 19 Mar 2022 18:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244305AbiCSWuf (ORCPT ); Sat, 19 Mar 2022 18:50:35 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5BAB49912; Sat, 19 Mar 2022 15:49:11 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 22JMn9qk026585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Mar 2022 18:49:10 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6AFEB15C0038; Sat, 19 Mar 2022 18:49:09 -0400 (EDT) Date: Sat, 19 Mar 2022 18:49:09 -0400 From: "Theodore Ts'o" To: Byungchul Park Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, bfields@fieldses.org, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jack@suse.com, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com Subject: Re: [PATCH RFC v5 00/21] DEPT(Dependency Tracker) Message-ID: References: <1647397593-16747-1-git-send-email-byungchul.park@lge.com> <20220318074945.GA17484@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318074945.GA17484@X58A-UD3R> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Mar 18, 2022 at 04:49:45PM +0900, Byungchul Park wrote: > > I guess it was becasue of the commit b1fca27d384e8("kernel debug: > support resetting WARN*_ONCE"). Your script seems to reset WARN*_ONCE > repeatedly. I wasn't aware this was being done, but your guess was correct. The WARN_ONCE state is getting cleared between each test in xfstests, with the rationale (which IMO is quite reasonable) why this done in the xfstests commit descrition: commit c67ea2347454aebbe8eb6e825e9314d099b683da Author: Lukas Czerner Date: Wed Jul 15 13:42:19 2020 +0200 check: clear WARN_ONCE state before each test clear WARN_ONCE state before each test to allow a potential problem to be reported for each test [Eryu: replace "/sys/kernel/debug" with $DEBUGFS_MNT ] Signed-off-by: Lukas Czerner Reviewed-by: Zorro Lang Signed-off-by: Eryu Guan Cheers, - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79610C433F5 for ; Sat, 19 Mar 2022 22:50:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A1FD10E1B6; Sat, 19 Mar 2022 22:50:30 +0000 (UTC) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0008C10E1B6 for ; Sat, 19 Mar 2022 22:50:28 +0000 (UTC) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 22JMn9Ad026583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Mar 2022 18:49:10 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6AFEB15C0038; Sat, 19 Mar 2022 18:49:09 -0400 (EDT) Date: Sat, 19 Mar 2022 18:49:09 -0400 From: "Theodore Ts'o" To: Byungchul Park Subject: Re: [PATCH RFC v5 00/21] DEPT(Dependency Tracker) Message-ID: References: <1647397593-16747-1-git-send-email-byungchul.park@lge.com> <20220318074945.GA17484@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318074945.GA17484@X58A-UD3R> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hamohammed.sa@gmail.com, jack@suse.cz, peterz@infradead.org, daniel.vetter@ffwll.ch, amir73il@gmail.com, david@fromorbit.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, bfields@fieldses.org, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, joel@joelfernandes.org, cl@linux.com, will@kernel.org, duyuyang@gmail.com, sashal@kernel.org, paolo.valente@linaro.org, damien.lemoal@opensource.wdc.com, willy@infradead.org, hch@infradead.org, airlied@linux.ie, mingo@redhat.com, djwong@kernel.org, vdavydov.dev@gmail.com, rientjes@google.com, dennis@kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, ngupta@vflare.org, johannes.berg@intel.com, jack@suse.com, dan.j.williams@intel.com, josef@toxicpanda.com, rostedt@goodmis.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, jglisse@redhat.com, viro@zeniv.linux.org.uk, tglx@linutronix.de, mhocko@kernel.org, vbabka@suse.cz, melissa.srw@gmail.com, sj@kernel.org, rodrigosiqueiramelo@gmail.com, kernel-team@lge.com, gregkh@linuxfoundation.org, jlayton@kernel.org, linux-kernel@vger.kernel.org, penberg@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, tj@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 18, 2022 at 04:49:45PM +0900, Byungchul Park wrote: > > I guess it was becasue of the commit b1fca27d384e8("kernel debug: > support resetting WARN*_ONCE"). Your script seems to reset WARN*_ONCE > repeatedly. I wasn't aware this was being done, but your guess was correct. The WARN_ONCE state is getting cleared between each test in xfstests, with the rationale (which IMO is quite reasonable) why this done in the xfstests commit descrition: commit c67ea2347454aebbe8eb6e825e9314d099b683da Author: Lukas Czerner Date: Wed Jul 15 13:42:19 2020 +0200 check: clear WARN_ONCE state before each test clear WARN_ONCE state before each test to allow a potential problem to be reported for each test [Eryu: replace "/sys/kernel/debug" with $DEBUGFS_MNT ] Signed-off-by: Lukas Czerner Reviewed-by: Zorro Lang Signed-off-by: Eryu Guan Cheers, - Ted