From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F22C433F5 for ; Mon, 21 Mar 2022 09:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243061AbiCUJfo (ORCPT ); Mon, 21 Mar 2022 05:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239083AbiCUJfo (ORCPT ); Mon, 21 Mar 2022 05:35:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A17EC5D1A3; Mon, 21 Mar 2022 02:34:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4480B61257; Mon, 21 Mar 2022 09:34:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BD68C340E8; Mon, 21 Mar 2022 09:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647855258; bh=KAy+HX7RT4vropER51g7vnunFx9E0IYtS6S7s/kOnVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=az+y/cewf7KdP2kFF8wkWZlGQo6+2T0eMChPcWVGvVoP+lO8Yj59G2Yd/icvGqv39 aF55PvwTgY4UbH4mLJ/RQZwnFdT1tjW5COWkzOn+M6kOmTwVGZVRMToe5McDTInUCb tVUEmR4Tt5g3BnBbyT1VpGTdCW1U4bLfuETqjQSI= Date: Mon, 21 Mar 2022 10:34:16 +0100 From: Greg Kroah-Hartman To: "Sandeep Maheswaram (Temp)" Cc: Felipe Balbi , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Mathias Nyman , Pawel Laszczak , Peter Chen , Roger Quadros , Aswath Govindraju , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com Subject: Re: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion Message-ID: References: <1646130507-26796-1-git-send-email-quic_c_sanm@quicinc.com> <1646130507-26796-3-git-send-email-quic_c_sanm@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Mar 21, 2022 at 02:47:08PM +0530, Sandeep Maheswaram (Temp) wrote: > Hi Greg, > > On 3/18/2022 5:31 PM, Greg Kroah-Hartman wrote: > > On Tue, Mar 01, 2022 at 03:58:26PM +0530, Sandeep Maheswaram wrote: > > > Remove the header file and forward declare struct usb_hcd. > > Why? > > This was done to address below comment in previous version > > https://patchwork.kernel.org/project/linux-arm-msm/patch/1644949454-814-2-git-send-email-quic_c_sanm@quicinc.com/#24739885 Then EXPLAIN THAT in the changelog text. Don't make us guess. Please read the kernel documentation for how to write a good changelog text. This single sentance does not follow the guidelines at all. > > > > > > > Signed-off-by: Sandeep Maheswaram > > > --- > > > include/linux/usb/xhci-plat.h | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h > > > index 906e907..576e400 100644 > > > --- a/include/linux/usb/xhci-plat.h > > > +++ b/include/linux/usb/xhci-plat.h > > > @@ -9,7 +9,8 @@ > > > #define _XHCI_PLAT_H > > > #include > > > -#include > > > + > > > +struct usb_hcd; > > > struct xhci_plat_priv { > > > const char *firmware_name; > > > -- > > > 2.7.4 > > > > > Where did this come from? Is this fixing a build breakage from a > > previous patch? If not, why is this needed? > > > > confused, > > > > greg k-h > > There wasn't any build breakage. > > This was done to address below comment in previous version > > https://patchwork.kernel.org/project/linux-arm-msm/patch/1644949454-814-2-git-send-email-quic_c_sanm@quicinc.com/#24739885 Again, how were we supposed to know any of this? Please read the documentation again for how to do this properly. thanks, greg k-h