From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Christian Lamparter <chunkeey@gmail.com>,
linux-ide@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2 2/2] ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs
Date: Mon, 21 Mar 2022 12:43:02 +0200 [thread overview]
Message-ID: <YjhWtp+AdcN1ot9t@smile.fi.intel.com> (raw)
In-Reply-To: <468f57ae-47e8-7032-b391-7ddfd6853dbb@omp.ru>
On Mon, Mar 21, 2022 at 11:00:51AM +0300, Sergey Shtylyov wrote:
> On 3/19/22 11:11 PM, Christian Lamparter wrote:
...
> > + { "Samsung SSD 840 EVO*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> > + ATA_HORKAGE_NO_DMA_LOG |
> > + ATA_HORKAGE_ZERO_AFTER_TRIM, },
> > { "Samsung SSD 840*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> > ATA_HORKAGE_ZERO_AFTER_TRIM, },
>
> Shouldn't this entry be modified instead?
Wouldn't it modify much more devices with unknown outcome?
I would be on the safer side as done by this patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-21 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 20:11 [PATCH v2 1/2] ata: sata_dwc_460ex: Fix crash due to OOB write Christian Lamparter
2022-03-19 20:11 ` [PATCH v2 2/2] ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs Christian Lamparter
2022-03-19 20:31 ` Reimar Döffinger
2022-03-19 20:42 ` Reimar Döffinger
2022-03-21 12:48 ` Damien Le Moal
2022-03-21 8:00 ` Sergey Shtylyov
2022-03-21 10:43 ` Andy Shevchenko [this message]
2022-03-21 12:38 ` Damien Le Moal
2022-04-04 1:00 ` Damien Le Moal
2022-04-04 1:00 ` [PATCH v2 1/2] ata: sata_dwc_460ex: Fix crash due to OOB write Damien Le Moal
[not found] <3D5F418D-D612-49A9-80DF-E61313FE006B () gmx ! de>
2022-03-19 21:38 ` [PATCH v2 2/2] ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjhWtp+AdcN1ot9t@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=chunkeey@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.