From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6225C433EF for ; Wed, 23 Mar 2022 12:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242752AbiCWMj2 (ORCPT ); Wed, 23 Mar 2022 08:39:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235941AbiCWMj0 (ORCPT ); Wed, 23 Mar 2022 08:39:26 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 053C17B54D for ; Wed, 23 Mar 2022 05:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=0tIk9V8VD5AtRCLLGr16uC8J1QyfJRaMrHIoDCtvAUw=; b=JxM+pbxpDceF19qUldOyoUWeHw TaMtGKOhzOL44VRCWkFKHRC6Xehodn1mGuNkRrfLBxi0rUESofO540+bJOJvnaErIgvwQLad1QHFY 4YpZUOenCF3xgdzkAa44Nswj++HFg72J1WmbwcTtrPxiSlS3Pv1s30Ix1/Sa/eweyunY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nX0F2-00CHHR-PF; Wed, 23 Mar 2022 13:37:32 +0100 Date: Wed, 23 Mar 2022 13:37:32 +0100 From: Andrew Lunn To: ryan_chen Cc: BMC-SW@aspeedtech.com, Rob Herring , Joel Stanley , Andrew Jeffery , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver Message-ID: References: <20220323004009.943298-1-ryan_chen@aspeedtech.com> <20220323004009.943298-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323004009.943298-3-ryan_chen@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 08:40:09AM +0800, ryan_chen wrote: > Add i2c new register mode driver to support AST2600 i2c > new register set. AST2600 i2c controller have legacy and > new register mode. The new register mode have global register > support 4 base clock for scl clock selection, and new clock > divider mode. And i2c new register mode have separate register > set to control i2c master and slave. > > Signed-off-by: Ryan Chen > --- > drivers/i2c/busses/Kconfig | 11 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/aspeed-i2c-new-global.c | 91 ++ > drivers/i2c/busses/aspeed-i2c-new-global.h | 19 + > drivers/i2c/busses/i2c-new-aspeed.c | 1698 ++++++++++++++++++++ I always find it funny when somebody uses 'new'. What is the next version going to be called? 'even-newer', and the version after that 'really-really-new'? > +static const struct of_device_id aspeed_new_i2c_bus_of_table[] = { > + { > + .compatible = "aspeed,ast2600-i2c-bus", > + }, Given this compatible string, why not call it i2c-aspeed-2600.c, and remove 'new' everywhere. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B21B9C433F5 for ; Wed, 23 Mar 2022 12:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U90Eu6xNddvU2DqOchLPRe6cdFvNtEr+hHsLzGXQscU=; b=zxcAz/Pvs1qT1y nbwrPWZ5CtxWNvSguYDplUi+4ZYthKMQoje0gggUoSzxTHFKcfq2uGkLjhCKIpjMr4qKjL+2HLucK +5mcVV8xVgPEbeepCGRyfLhbNXlWMXYn3cesZzJLc8QzZTW7PVgaI/uddb+NXUEjnBfr8sVHrVn5W 0MSYBeH4nVbHiXRQWPigv1KGYXGNB4HfR2ld4xF2ESBdVeI4ASYZw2WFE7F/g4Qzk8DTkMvgiS+ts /sNNuxmDNaq+8YcrzereoU27153UAz+8R/dbYwWJ2vmV9q/pmPDU0KRObiK5AY2nrNI1xnOxQssCE 8jaWDHZWliax3RDnQeWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0FP-00Dchm-Pp; Wed, 23 Mar 2022 12:37:55 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0FM-00Dcgp-HW for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 12:37:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=0tIk9V8VD5AtRCLLGr16uC8J1QyfJRaMrHIoDCtvAUw=; b=JxM+pbxpDceF19qUldOyoUWeHw TaMtGKOhzOL44VRCWkFKHRC6Xehodn1mGuNkRrfLBxi0rUESofO540+bJOJvnaErIgvwQLad1QHFY 4YpZUOenCF3xgdzkAa44Nswj++HFg72J1WmbwcTtrPxiSlS3Pv1s30Ix1/Sa/eweyunY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nX0F2-00CHHR-PF; Wed, 23 Mar 2022 13:37:32 +0100 Date: Wed, 23 Mar 2022 13:37:32 +0100 From: Andrew Lunn To: ryan_chen Cc: BMC-SW@aspeedtech.com, Rob Herring , Joel Stanley , Andrew Jeffery , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver Message-ID: References: <20220323004009.943298-1-ryan_chen@aspeedtech.com> <20220323004009.943298-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220323004009.943298-3-ryan_chen@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_053752_601791_854F6D3E X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 23, 2022 at 08:40:09AM +0800, ryan_chen wrote: > Add i2c new register mode driver to support AST2600 i2c > new register set. AST2600 i2c controller have legacy and > new register mode. The new register mode have global register > support 4 base clock for scl clock selection, and new clock > divider mode. And i2c new register mode have separate register > set to control i2c master and slave. > > Signed-off-by: Ryan Chen > --- > drivers/i2c/busses/Kconfig | 11 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/aspeed-i2c-new-global.c | 91 ++ > drivers/i2c/busses/aspeed-i2c-new-global.h | 19 + > drivers/i2c/busses/i2c-new-aspeed.c | 1698 ++++++++++++++++++++ I always find it funny when somebody uses 'new'. What is the next version going to be called? 'even-newer', and the version after that 'really-really-new'? > +static const struct of_device_id aspeed_new_i2c_bus_of_table[] = { > + { > + .compatible = "aspeed,ast2600-i2c-bus", > + }, Given this compatible string, why not call it i2c-aspeed-2600.c, and remove 'new' everywhere. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel