From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F4AC433FE for ; Wed, 23 Mar 2022 13:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244125AbiCWNJD (ORCPT ); Wed, 23 Mar 2022 09:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244140AbiCWNJA (ORCPT ); Wed, 23 Mar 2022 09:09:00 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 001687CDD7 for ; Wed, 23 Mar 2022 06:07:29 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id d7so2045027wrb.7 for ; Wed, 23 Mar 2022 06:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=7EDiYHM0/mHUHNh2nAcUtV8Mo87BBMJDjh2R3QaAEXuxurVdInHyGhkLnwH6gL3bPY ftLMYfyygow8mzkD5Dev2Iq+3cB/DbsVL3VVzYv3NYkRy77gO07thxxfnDuE/5vvFwiB SnNZc9jBzd7JxXBaPe5MmyMhQ/dZvf5IJrjHbztF2VDxy+YSXfGCFsGy91bzu0dpwUVD vLLzZ2UR7OCpthmgXf0+rBDgwrScxpIXhhh0aF66G9+NvYfooCnN6Ac965njTsu7vX7H 5rK015KemhcLQmxFbNnPmlRfVnVllLsShyU6SyQvhK65gIf9XVzlSMG1ZoK1rbNLFDgk 2K8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=x9wqMN71+sE9DZmv0W3TB8t/E83b9wdISFwfgaQungCd7KeHOcl/kq8NBvrE+PFvS7 NvUJVJSzMuDZt7dpAO6y1fpj1Iw4wUFRCmfuUD2Eg2vTpQUA/Pv1Iy4CRA1Dn6ePFKuj FUDAB2WnVfpCWfyJGUTu3X4XL77HmGpXuhGCUXcyDkRRYhqDNXePwLcpDbbMQ2pYifx4 vQfjZ2iZcItfnMyxIZnW9CniDgHMzxJhhr4YSVCf8KR7Q8VRRFTksY8dans0n4TV6ZJA xYRjmpj9AJLelkXJkIh3epOigYmWvEjW9zOwqagbQj1Iv37pmJTSOX9KnbLVqjkwgfNl 3iTg== X-Gm-Message-State: AOAM530Yz/Rfg+R57UokNHuwsX/umkhxET02gQkSW2CNeUjxiJyZ3nGB mpc2Ixnrxl/wnYFZo0fQhlpXLg== X-Google-Smtp-Source: ABdhPJwlHTs/jXded6YR+bEyG9ABUfL/AlSP0pBeJMmhWDxUYvyYfFnDLfkgPcSrNXyLqFblB0f+cw== X-Received: by 2002:a5d:5509:0:b0:204:f77:c2d with SMTP id b9-20020a5d5509000000b002040f770c2dmr13533390wrv.432.1648040848448; Wed, 23 Mar 2022 06:07:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id n20-20020a05600c4f9400b0038cbd13e06esm2794951wmq.2.2022.03.23.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:07:27 -0700 (PDT) Date: Wed, 23 Mar 2022 14:07:25 +0100 From: LABBE Corentin To: Robin Murphy Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 06/26] crypto: rockchip: add fallback for cipher Message-ID: References: <20220321200739.3572792-1-clabbe@baylibre.com> <20220321200739.3572792-7-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le Tue, Mar 22, 2022 at 11:25:25AM +0000, Robin Murphy a écrit : > On 2022-03-21 20:07, Corentin Labbe wrote: > > The hardware does not handle 0 size length request, let's add a > > fallback. > > Furthermore fallback will be used for all unaligned case the hardware > > cannot handle. > > > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/Kconfig | 4 + > > drivers/crypto/rockchip/rk3288_crypto.h | 2 + > > .../crypto/rockchip/rk3288_crypto_skcipher.c | 105 +++++++++++++++--- > > 3 files changed, 98 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > > index 7b2d138bc83e..84ab14afcbd9 100644 > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -784,6 +784,10 @@ config CRYPTO_DEV_IMGTEC_HASH > > config CRYPTO_DEV_ROCKCHIP > > tristate "Rockchip's Cryptographic Engine driver" > > depends on OF && ARCH_ROCKCHIP > > + depends on PM > > This appears to belong to patch #13 rather than this one. > Hello Yes this is an error, I will move it this line on the right patch. > My initial thought was that it probably shouldn't be something for > random consumers to care about at all, but there do seem to be a handful > of other drivers relying on pm_runtime_resume to enable their clocks, so > I guess maybe it's an acceptable idiom :/ > Depending on PM made the driver easier to understand (no more if PM/if not PM). And anyway, since it's embedded device, PM should be always enabled. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1D61C433EF for ; Wed, 23 Mar 2022 13:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/o8Idq/FF4W3XgAh8xXN1jxVVNcz6L4jqFfuhTkRLtM=; b=X6x50X5O+iGksa fXJ86qIfDktWhGvNVz7Et9NQM+ggXjLfJ3JhyqFUy5pkIv5o87P0j79ho6iHSNHm4H+HimZlV4o8y ohLmvXxBTs+8NUCv10loBwIJhVsgJJBR3k5H5uHLH/6KB6r4aCo8mwCnarm2cyz14+Q1fTlIV3hzP YvKdXoAoat3EguNTL9tWnBOqNQPvfOD0RumZq0Btl0jrmfQhvKkKI7pbRNLV/7dHT24BQb+TIph6T G9XfALSqVY+CLBzCPNM3mHCp9HQwmAk0mfPHc7+f0eZ6BlTxVAzp9ms4w8et9IgEQHxv02HMSZbBc nJ81vvURYWcW/HA9g1yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0i6-00DgCC-Ek; Wed, 23 Mar 2022 13:07:34 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0i2-00DgAn-Rn for linux-rockchip@lists.infradead.org; Wed, 23 Mar 2022 13:07:33 +0000 Received: by mail-wr1-x431.google.com with SMTP id h4so2014593wrc.13 for ; Wed, 23 Mar 2022 06:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=7EDiYHM0/mHUHNh2nAcUtV8Mo87BBMJDjh2R3QaAEXuxurVdInHyGhkLnwH6gL3bPY ftLMYfyygow8mzkD5Dev2Iq+3cB/DbsVL3VVzYv3NYkRy77gO07thxxfnDuE/5vvFwiB SnNZc9jBzd7JxXBaPe5MmyMhQ/dZvf5IJrjHbztF2VDxy+YSXfGCFsGy91bzu0dpwUVD vLLzZ2UR7OCpthmgXf0+rBDgwrScxpIXhhh0aF66G9+NvYfooCnN6Ac965njTsu7vX7H 5rK015KemhcLQmxFbNnPmlRfVnVllLsShyU6SyQvhK65gIf9XVzlSMG1ZoK1rbNLFDgk 2K8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=qxXUpjnzjRHxupuam+kguZ4Ln+UhEHz+shVoNzIeLAwD8NwuecmxWvB0gflsx0bTsM wodx6wILeeUQmi1JXCqrfM01+ZmWNF0dKEh7IQJ6jxhhJR4GMpxZQG+1bSeSOyf9BsBF QPKB1aFBaAGiyEjLAcmIMYtNUlW9hJhxdOgP/dRE3eNpVh1jq/ehKXmLXCVilH5aDDEk UuAwav5XHLfzs72yNIAjpDuTGBfRfExqUws7VTZXIa3dMxbEA26QMhPuQF0GNcanKMMt gjjshTtVjNqPW+KL2EsHFElqTDSwzrVoP2YQ43T6wUSXNvfLWYSOeb57vjOxd/MWkKxB y88g== X-Gm-Message-State: AOAM530cxg32J+9L3ikvP6FzOe80Qf4QgyIU+6FfYbeDJVlkJ8osgIWf JmA+vW7mIpjiPpEFfL5a+yJ1Gg== X-Google-Smtp-Source: ABdhPJwlHTs/jXded6YR+bEyG9ABUfL/AlSP0pBeJMmhWDxUYvyYfFnDLfkgPcSrNXyLqFblB0f+cw== X-Received: by 2002:a5d:5509:0:b0:204:f77:c2d with SMTP id b9-20020a5d5509000000b002040f770c2dmr13533390wrv.432.1648040848448; Wed, 23 Mar 2022 06:07:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id n20-20020a05600c4f9400b0038cbd13e06esm2794951wmq.2.2022.03.23.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:07:27 -0700 (PDT) Date: Wed, 23 Mar 2022 14:07:25 +0100 From: LABBE Corentin To: Robin Murphy Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 06/26] crypto: rockchip: add fallback for cipher Message-ID: References: <20220321200739.3572792-1-clabbe@baylibre.com> <20220321200739.3572792-7-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_060730_991102_96F93C81 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Le Tue, Mar 22, 2022 at 11:25:25AM +0000, Robin Murphy a =E9crit : > On 2022-03-21 20:07, Corentin Labbe wrote: > > The hardware does not handle 0 size length request, let's add a > > fallback. > > Furthermore fallback will be used for all unaligned case the hardware > > cannot handle. > > = > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/Kconfig | 4 + > > drivers/crypto/rockchip/rk3288_crypto.h | 2 + > > .../crypto/rockchip/rk3288_crypto_skcipher.c | 105 +++++++++++++++--- > > 3 files changed, 98 insertions(+), 13 deletions(-) > > = > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > > index 7b2d138bc83e..84ab14afcbd9 100644 > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -784,6 +784,10 @@ config CRYPTO_DEV_IMGTEC_HASH > > config CRYPTO_DEV_ROCKCHIP > > tristate "Rockchip's Cryptographic Engine driver" > > depends on OF && ARCH_ROCKCHIP > > + depends on PM > = > This appears to belong to patch #13 rather than this one. > = Hello Yes this is an error, I will move it this line on the right patch. > My initial thought was that it probably shouldn't be something for = > random consumers to care about at all, but there do seem to be a handful = > of other drivers relying on pm_runtime_resume to enable their clocks, so = > I guess maybe it's an acceptable idiom :/ > = Depending on PM made the driver easier to understand (no more if PM/if not = PM). And anyway, since it's embedded device, PM should be always enabled. Thanks _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19079C433EF for ; Wed, 23 Mar 2022 13:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+rnSKzBTH3XKyM5Zvl9+MG3tkNgbsIdwSq4eWKL5ZYs=; b=P8ZX0uiuIsUCjF RbS+rLkl3M3LRngGChPq8gvGRvZ2Y3tA9gilLeMs5pWrAE7uivTx/xxSIVi1p6yAJmsi2oKDb0rU8 V0yyjpM0Wd4yKwnpNMc2xjgFSoOg2lpoZGJoqseqPa2HvJZCBd8YPC0qawu8ZBvZNHIUKv1jHS8/2 vmTy0ZHPRrscHA/BNCONVRR+rGFQvGVALUMuEdNMlL8yR3EizGHulP9vmt/zyqfbZm2WnuS6Xqs/Z ZlcLHdFmd3j5tpXU/Oh31fOK4VJD/etjbewT5JtAbX2xkGHWAKm7EzjUkfcVxkaU5ilHkByob2sJa 9PDmlyC5Ehlji2Bx8+yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0i7-00DgCI-NQ; Wed, 23 Mar 2022 13:07:35 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX0i2-00DgAm-Rx for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 13:07:33 +0000 Received: by mail-wr1-x430.google.com with SMTP id j18so2047043wrd.6 for ; Wed, 23 Mar 2022 06:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=7EDiYHM0/mHUHNh2nAcUtV8Mo87BBMJDjh2R3QaAEXuxurVdInHyGhkLnwH6gL3bPY ftLMYfyygow8mzkD5Dev2Iq+3cB/DbsVL3VVzYv3NYkRy77gO07thxxfnDuE/5vvFwiB SnNZc9jBzd7JxXBaPe5MmyMhQ/dZvf5IJrjHbztF2VDxy+YSXfGCFsGy91bzu0dpwUVD vLLzZ2UR7OCpthmgXf0+rBDgwrScxpIXhhh0aF66G9+NvYfooCnN6Ac965njTsu7vX7H 5rK015KemhcLQmxFbNnPmlRfVnVllLsShyU6SyQvhK65gIf9XVzlSMG1ZoK1rbNLFDgk 2K8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/7GPfWTScrdUPxYCfpF4p4gmdocaWvB3DedYIkySiRQ=; b=mlRIr9+yf4Guib25zD9zg08irwL6lNfODA7s9Gr5YdrcYUqpV3a37Gag97i/hqdMOk wnRx3Ng8neEwi1b57FosCEPh2+jSwXrfV8Sm4p/3qNTQjG7yLT9D7D9I0ExM2KaYGBHx vNrJ91QPB5ghkZ00lnP0f6kOSKxrkUBwaw1ckyTHF854zIfcpFOoPLAWl0C2Y9rqfrLL jQP/jswySYHQUJTVR+voofHieAdxp/AHNFImlpuwWuCew4Yd7SkOZ8O4w0ZWGRKjSJ4M Lyxq/Dfqkw+MLZl7HyztNcxIY0G8mxswR75H5JA6mytCmjo/VHzS56Z5/a5kyPSXijeK FnUg== X-Gm-Message-State: AOAM533jkn0aDyHdFXUViYKpqTuLiKMEQj60YPxWZ7As5oGc1pAs80fN YjgoyVI+q5rSCWpO5VcnQQqAMg== X-Google-Smtp-Source: ABdhPJwlHTs/jXded6YR+bEyG9ABUfL/AlSP0pBeJMmhWDxUYvyYfFnDLfkgPcSrNXyLqFblB0f+cw== X-Received: by 2002:a5d:5509:0:b0:204:f77:c2d with SMTP id b9-20020a5d5509000000b002040f770c2dmr13533390wrv.432.1648040848448; Wed, 23 Mar 2022 06:07:28 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id n20-20020a05600c4f9400b0038cbd13e06esm2794951wmq.2.2022.03.23.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:07:27 -0700 (PDT) Date: Wed, 23 Mar 2022 14:07:25 +0100 From: LABBE Corentin To: Robin Murphy Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 06/26] crypto: rockchip: add fallback for cipher Message-ID: References: <20220321200739.3572792-1-clabbe@baylibre.com> <20220321200739.3572792-7-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_060730_989992_58F6D02D X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Tue, Mar 22, 2022 at 11:25:25AM +0000, Robin Murphy a =E9crit : > On 2022-03-21 20:07, Corentin Labbe wrote: > > The hardware does not handle 0 size length request, let's add a > > fallback. > > Furthermore fallback will be used for all unaligned case the hardware > > cannot handle. > > = > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/Kconfig | 4 + > > drivers/crypto/rockchip/rk3288_crypto.h | 2 + > > .../crypto/rockchip/rk3288_crypto_skcipher.c | 105 +++++++++++++++--- > > 3 files changed, 98 insertions(+), 13 deletions(-) > > = > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > > index 7b2d138bc83e..84ab14afcbd9 100644 > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -784,6 +784,10 @@ config CRYPTO_DEV_IMGTEC_HASH > > config CRYPTO_DEV_ROCKCHIP > > tristate "Rockchip's Cryptographic Engine driver" > > depends on OF && ARCH_ROCKCHIP > > + depends on PM > = > This appears to belong to patch #13 rather than this one. > = Hello Yes this is an error, I will move it this line on the right patch. > My initial thought was that it probably shouldn't be something for = > random consumers to care about at all, but there do seem to be a handful = > of other drivers relying on pm_runtime_resume to enable their clocks, so = > I guess maybe it's an acceptable idiom :/ > = Depending on PM made the driver easier to understand (no more if PM/if not = PM). And anyway, since it's embedded device, PM should be always enabled. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel